mirror of
https://github.com/selfxyz/self.git
synced 2026-02-19 02:24:25 -05:00
8da076cf0d
* Update dependency versions * Fix gesture handler Android dependency (#1611) * Patch screens codegen type (#1609) * Downgrade Sentry React Native (#1612) * fix patches and packages * downgrade versions for gesture handler and screens * agent feedback * fix ios building * allow ios tets to pass * formatting * make cache more resilient * Address CodeRabbitAI review comments This commit addresses all 7 unresolved CodeRabbitAI comments on PR #1606: Patch-package error handling (comments #1, #2, #3): - stderr capture already implemented in both root and workspace patch runs - Add CI warning when patches fail silently instead of exiting with 0 - Log completion status in CI mode for visibility Critical Mixpanel dependency fix (comment #5): - Add explicit Mixpanel-swift pod declaration to fix E2E build failures - Ensures Mixpanel is available even when NFCPassportReader is skipped during E2E testing React-native-web validation (comment #4): - Verified no usage of deprecated findNodeHandle, pointerEvents: 'box-none', or createPortal - Safe to upgrade from 0.19 to 0.21.2 CI workflow improvements (comments #6, #7): - Create cache-sdk-build composite action for consistent SDK build artifact caching - Replace all direct actions/cache@v4 usage with cache-yarn composite action - Replace all direct actions/cache/restore@v4 and save@v4 with cache-sdk-build - Add nested require() validation step before tests to fail fast on problematic patterns All changes follow repository coding guidelines for CI caching and test memory optimization. * Extend cache composite actions to all SDK workflows This commit extends the caching standardization from PR #1606 to include mobile-sdk-ci.yml and core-sdk-ci.yml workflows. New composite actions created: - cache-mobile-sdk-build: For mobile SDK build artifacts - cache-core-sdk-build: For core SDK build artifacts Workflow updates: - mobile-sdk-ci.yml: Replaced 5 instances of direct actions/cache with cache-mobile-sdk-build - core-sdk-ci.yml: Replaced 4 instances of direct actions/cache with cache-core-sdk-build All SDK CI workflows now use consistent caching patterns via composite actions, following the AGENTS.md guideline: "Use shared composite actions from .github/actions for CI caching instead of calling actions/cache directly." Benefits: - Consistent caching across all SDK workflows (qrcode, mobile, core) - Centralized cache configuration - easier to maintain - Follows established patterns from qrcode-sdk-ci.yml * downgrade react-native-svg * update pod lock file * sort
296 lines
9.3 KiB
YAML
296 lines
9.3 KiB
YAML
name: QRCode SDK CI
|
|
|
|
env:
|
|
# Build environment versions
|
|
# Node version is read from .nvmrc during workflow execution
|
|
# Cache versioning - increment these to bust caches when needed
|
|
GH_CACHE_VERSION: v1 # Global cache version
|
|
GH_YARN_CACHE_VERSION: v1 # Yarn-specific cache version
|
|
GH_SDK_CACHE_VERSION: v1 # SDK build cache version
|
|
|
|
on:
|
|
pull_request:
|
|
branches:
|
|
- dev
|
|
- staging
|
|
- main
|
|
paths:
|
|
- "sdk/qrcode/**"
|
|
- "common/**"
|
|
- ".github/workflows/qrcode-sdk-ci.yml"
|
|
- ".github/actions/**"
|
|
|
|
jobs:
|
|
# Build dependencies once and cache for other jobs
|
|
build:
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v6
|
|
- name: Read and sanitize Node.js version
|
|
shell: bash
|
|
run: |
|
|
if [ ! -f .nvmrc ] || [ -z "$(cat .nvmrc)" ]; then
|
|
echo "❌ .nvmrc is missing or empty"; exit 1;
|
|
fi
|
|
VERSION="$(tr -d '\r\n' < .nvmrc)"
|
|
VERSION="${VERSION#v}"
|
|
if ! [[ "$VERSION" =~ ^[0-9]+(\.[0-9]+){0,2}$ ]]; then
|
|
echo "Invalid .nvmrc content: '$VERSION'"; exit 1;
|
|
fi
|
|
echo "NODE_VERSION=$VERSION" >> "$GITHUB_ENV"
|
|
echo "NODE_VERSION_SANITIZED=${VERSION//\//-}" >> "$GITHUB_ENV"
|
|
|
|
- name: Use Node.js ${{ env.NODE_VERSION }}
|
|
uses: actions/setup-node@v4
|
|
with:
|
|
node-version: ${{ env.NODE_VERSION }}
|
|
|
|
- name: Enable Corepack
|
|
run: corepack enable
|
|
|
|
- name: Cache Yarn dependencies
|
|
id: yarn-cache
|
|
uses: ./.github/actions/cache-yarn
|
|
with:
|
|
path: |
|
|
.yarn/cache
|
|
node_modules
|
|
sdk/qrcode/node_modules
|
|
common/node_modules
|
|
cache-version: ${{ env.GH_YARN_CACHE_VERSION }}-node-${{ env.NODE_VERSION_SANITIZED }}
|
|
|
|
- name: Install Dependencies
|
|
uses: ./.github/actions/yarn-install
|
|
|
|
- name: Build dependencies
|
|
shell: bash
|
|
run: |
|
|
yarn workspace @selfxyz/common build
|
|
yarn workspace @selfxyz/sdk-common build
|
|
yarn workspace @selfxyz/qrcode build
|
|
|
|
- name: Cache build artifacts
|
|
uses: ./.github/actions/cache-sdk-build
|
|
with:
|
|
mode: save
|
|
cache-version: ${{ env.GH_SDK_CACHE_VERSION }}
|
|
|
|
# Quality checks job
|
|
quality-checks:
|
|
runs-on: ubuntu-latest
|
|
needs: build
|
|
steps:
|
|
- uses: actions/checkout@v6
|
|
- name: Read and sanitize Node.js version
|
|
shell: bash
|
|
run: |
|
|
if [ ! -f .nvmrc ] || [ -z "$(cat .nvmrc)" ]; then
|
|
echo "❌ .nvmrc is missing or empty"; exit 1;
|
|
fi
|
|
VERSION="$(tr -d '\r\n' < .nvmrc)"
|
|
VERSION="${VERSION#v}"
|
|
if ! [[ "$VERSION" =~ ^[0-9]+(\.[0-9]+){0,2}$ ]]; then
|
|
echo "Invalid .nvmrc content: '$VERSION'"; exit 1;
|
|
fi
|
|
echo "NODE_VERSION=$VERSION" >> "$GITHUB_ENV"
|
|
echo "NODE_VERSION_SANITIZED=${VERSION//\//-}" >> "$GITHUB_ENV"
|
|
|
|
- name: Use Node.js ${{ env.NODE_VERSION }}
|
|
uses: actions/setup-node@v4
|
|
with:
|
|
node-version: ${{ env.NODE_VERSION }}
|
|
|
|
- name: Enable Corepack
|
|
run: corepack enable
|
|
|
|
- name: Cache Yarn dependencies
|
|
id: yarn-cache
|
|
uses: ./.github/actions/cache-yarn
|
|
with:
|
|
path: |
|
|
.yarn/cache
|
|
node_modules
|
|
sdk/qrcode/node_modules
|
|
common/node_modules
|
|
cache-version: ${{ env.GH_YARN_CACHE_VERSION }}-node-${{ env.NODE_VERSION_SANITIZED }}
|
|
|
|
- name: Install Dependencies
|
|
uses: ./.github/actions/yarn-install
|
|
|
|
- name: Restore build artifacts
|
|
id: restore-build
|
|
uses: ./.github/actions/cache-sdk-build
|
|
with:
|
|
mode: restore
|
|
cache-version: ${{ env.GH_SDK_CACHE_VERSION }}
|
|
fail-on-cache-miss: false
|
|
|
|
- name: Build dependencies (fallback on cache miss)
|
|
if: steps.restore-build.outputs.cache-hit != 'true'
|
|
run: |
|
|
yarn workspace @selfxyz/common build
|
|
yarn workspace @selfxyz/sdk-common build
|
|
yarn workspace @selfxyz/qrcode build
|
|
|
|
- name: Run linter
|
|
run: yarn workspace @selfxyz/qrcode lint:imports:check
|
|
|
|
- name: Check Prettier formatting
|
|
run: yarn workspace @selfxyz/qrcode lint
|
|
|
|
- name: Type checking
|
|
run: yarn workspace @selfxyz/qrcode types
|
|
|
|
- name: Log cache status
|
|
run: |
|
|
echo "Cache hit results:"
|
|
echo "- Yarn cache hit: ${{ steps.yarn-cache.outputs.cache-hit }}"
|
|
|
|
# Build verification job
|
|
build-verification:
|
|
runs-on: ubuntu-latest
|
|
needs: build
|
|
steps:
|
|
- uses: actions/checkout@v6
|
|
- name: Read and sanitize Node.js version
|
|
shell: bash
|
|
run: |
|
|
if [ ! -f .nvmrc ] || [ -z "$(cat .nvmrc)" ]; then
|
|
echo "❌ .nvmrc is missing or empty"; exit 1;
|
|
fi
|
|
VERSION="$(tr -d '\r\n' < .nvmrc)"
|
|
VERSION="${VERSION#v}"
|
|
if ! [[ "$VERSION" =~ ^[0-9]+(\.[0-9]+){0,2}$ ]]; then
|
|
echo "Invalid .nvmrc content: '$VERSION'"; exit 1;
|
|
fi
|
|
echo "NODE_VERSION=$VERSION" >> "$GITHUB_ENV"
|
|
echo "NODE_VERSION_SANITIZED=${VERSION//\//-}" >> "$GITHUB_ENV"
|
|
|
|
- name: Use Node.js ${{ env.NODE_VERSION }}
|
|
uses: actions/setup-node@v4
|
|
with:
|
|
node-version: ${{ env.NODE_VERSION }}
|
|
|
|
- name: Enable Corepack
|
|
run: corepack enable
|
|
|
|
- name: Cache Yarn dependencies
|
|
id: yarn-cache
|
|
uses: ./.github/actions/cache-yarn
|
|
with:
|
|
path: |
|
|
.yarn/cache
|
|
node_modules
|
|
sdk/qrcode/node_modules
|
|
common/node_modules
|
|
cache-version: ${{ env.GH_YARN_CACHE_VERSION }}-node-${{ env.NODE_VERSION_SANITIZED }}
|
|
|
|
- name: Install Dependencies
|
|
uses: ./.github/actions/yarn-install
|
|
|
|
- name: Restore build artifacts
|
|
id: restore-build
|
|
uses: ./.github/actions/cache-sdk-build
|
|
with:
|
|
mode: restore
|
|
cache-version: ${{ env.GH_SDK_CACHE_VERSION }}
|
|
fail-on-cache-miss: false
|
|
|
|
- name: Build dependencies (fallback on cache miss)
|
|
if: steps.restore-build.outputs.cache-hit != 'true'
|
|
run: |
|
|
yarn workspace @selfxyz/common build
|
|
yarn workspace @selfxyz/sdk-common build
|
|
yarn workspace @selfxyz/qrcode build
|
|
|
|
- name: Verify build artifacts
|
|
run: |
|
|
echo "Verifying build artifacts..."
|
|
ls -la common/dist/
|
|
ls -la sdk/sdk-common/dist/
|
|
ls -la sdk/qrcode/dist/
|
|
echo "✅ Build artifacts verified"
|
|
|
|
# Integration test job
|
|
integration-test:
|
|
runs-on: ubuntu-latest
|
|
needs: build
|
|
steps:
|
|
- uses: actions/checkout@v6
|
|
- name: Read and sanitize Node.js version
|
|
shell: bash
|
|
run: |
|
|
if [ ! -f .nvmrc ] || [ -z "$(cat .nvmrc)" ]; then
|
|
echo "❌ .nvmrc is missing or empty"; exit 1;
|
|
fi
|
|
VERSION="$(tr -d '\r\n' < .nvmrc)"
|
|
VERSION="${VERSION#v}"
|
|
if ! [[ "$VERSION" =~ ^[0-9]+(\.[0-9]+){0,2}$ ]]; then
|
|
echo "Invalid .nvmrc content: '$VERSION'"; exit 1;
|
|
fi
|
|
echo "NODE_VERSION=$VERSION" >> "$GITHUB_ENV"
|
|
echo "NODE_VERSION_SANITIZED=${VERSION//\//-}" >> "$GITHUB_ENV"
|
|
|
|
- name: Use Node.js ${{ env.NODE_VERSION }}
|
|
uses: actions/setup-node@v4
|
|
with:
|
|
node-version: ${{ env.NODE_VERSION }}
|
|
|
|
- name: Enable Corepack
|
|
run: corepack enable
|
|
|
|
- name: Cache Yarn dependencies
|
|
id: yarn-cache
|
|
uses: ./.github/actions/cache-yarn
|
|
with:
|
|
path: |
|
|
.yarn/cache
|
|
node_modules
|
|
sdk/qrcode/node_modules
|
|
common/node_modules
|
|
cache-version: ${{ env.GH_YARN_CACHE_VERSION }}-node-${{ env.NODE_VERSION_SANITIZED }}
|
|
|
|
- name: Install Dependencies
|
|
uses: ./.github/actions/yarn-install
|
|
|
|
- name: Restore build artifacts
|
|
id: restore-build
|
|
uses: ./.github/actions/cache-sdk-build
|
|
with:
|
|
mode: restore
|
|
cache-version: ${{ env.GH_SDK_CACHE_VERSION }}
|
|
fail-on-cache-miss: false
|
|
|
|
- name: Build dependencies (fallback on cache miss)
|
|
if: steps.restore-build.outputs.cache-hit != 'true'
|
|
run: |
|
|
yarn workspace @selfxyz/common build
|
|
yarn workspace @selfxyz/sdk-common build
|
|
yarn workspace @selfxyz/qrcode build
|
|
|
|
- name: Check for nested require() in tests
|
|
run: |
|
|
# Check SDK tests for nested require patterns that cause OOM
|
|
if grep -rE "require\(['\"]react(-native)?['\"])" sdk/qrcode/src/ sdk/qrcode/tests/ 2>/dev/null; then
|
|
echo "❌ Found nested require() patterns that cause OOM in CI"
|
|
exit 1
|
|
fi
|
|
echo "✅ No nested require() patterns found"
|
|
|
|
- name: Run tests
|
|
run: yarn workspace @selfxyz/qrcode test
|
|
|
|
- name: Test package import
|
|
run: |
|
|
echo "Testing package import..."
|
|
node -e "
|
|
const pkg = require('./sdk/qrcode/dist/cjs/index.cjs');
|
|
console.log('✅ Package imported successfully');
|
|
console.log('Package exports:', Object.keys(pkg));
|
|
"
|
|
|
|
- name: Log cache status
|
|
run: |
|
|
echo "Cache hit results:"
|
|
echo "- Yarn cache hit: ${{ steps.yarn-cache.outputs.cache-hit }}"
|