From 0014365453f7e9d6603a75b75df3cbd0bb2b5e22 Mon Sep 17 00:00:00 2001 From: cedoor Date: Thu, 28 Mar 2024 13:04:58 +0000 Subject: [PATCH] refactor(group): remove check on generateMerkleProof function Contracts actually need devs to generate a Merkle proof of a removed member. re #717 --- packages/group/src/index.ts | 4 ---- packages/group/tests/index.test.ts | 10 ---------- 2 files changed, 14 deletions(-) diff --git a/packages/group/src/index.ts b/packages/group/src/index.ts index 499fea8f..74500160 100644 --- a/packages/group/src/index.ts +++ b/packages/group/src/index.ts @@ -124,10 +124,6 @@ export class Group { * @returns The {@link MerkleProof} object. */ public generateMerkleProof(index: number): LeanIMTMerkleProof { - if (this.members[index] === 0n) { - throw new Error("Failed to generate Merkle proof: member has been removed") - } - return this.leanIMT.generateProof(index) } diff --git a/packages/group/tests/index.test.ts b/packages/group/tests/index.test.ts index bb76bec6..fd095b83 100644 --- a/packages/group/tests/index.test.ts +++ b/packages/group/tests/index.test.ts @@ -125,16 +125,6 @@ describe("Group", () => { expect(proof.leaf).toBe(1n) }) - - it("Should not generate a proof of membership if the member has been removed", () => { - const group = new Group() - group.addMembers([1n, 3n]) - group.removeMember(0) - - const fun = () => group.generateMerkleProof(0) - - expect(fun).toThrow("Failed to generate Merkle proof: member has been removed") - }) }) describe("# export", () => {