Merge pull request #2429 from rstudio/wch-fastmap

Use fastmap as backing store for Map class
This commit is contained in:
Winston Chang
2019-05-31 15:39:34 -05:00
committed by GitHub
7 changed files with 85 additions and 85 deletions

View File

@@ -94,12 +94,12 @@ test_that("ReactiveValues", {
# Initializing with NULL value
values <- reactiveValues(a=NULL, b=2)
# a should exist and be NULL
expect_equal(isolate(names(values)), c("a", "b"))
expect_setequal(isolate(names(values)), c("a", "b"))
expect_true(is.null(isolate(values$a)))
# Assigning NULL should keep object (not delete it), and set value to NULL
values$b <- NULL
expect_equal(isolate(names(values)), c("a", "b"))
expect_setequal(isolate(names(values)), c("a", "b"))
expect_true(is.null(isolate(values$b)))
@@ -517,12 +517,12 @@ test_that("names() and reactiveValuesToList()", {
})
# names() returns all names
expect_equal(sort(isolate(names(values))), sort(c(".B", "A")))
expect_setequal(isolate(names(values)), c(".B", "A"))
# Assigning names fails
expect_error(isolate(names(v) <- c('x', 'y')))
expect_equal(isolate(reactiveValuesToList(values)), list(A=1))
expect_equal(isolate(reactiveValuesToList(values, all.names=TRUE)), list(A=1, .B=2))
expect_mapequal(isolate(reactiveValuesToList(values)), list(A=1))
expect_mapequal(isolate(reactiveValuesToList(values, all.names=TRUE)), list(A=1, .B=2))
flushReact()
@@ -1137,10 +1137,10 @@ test_that("reactive domain works across async handlers", {
~{hasReactiveDomain <<- identical(getDefaultReactiveDomain(), obj)}
)
})
while (is.null(hasReactiveDomain) && !later::loop_empty()) {
later::run_now()
}
testthat::expect_true(hasReactiveDomain)
})