github/shiny
1
1
Fork 0
mirror of https://github.com/rstudio/shiny.git synced 2026-04-29 03:00:45 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2586 from rstudio/resourcePathChangesOption

Browse Source 
Suppress resource path changes by default
This commit is contained in:
Joe Cheng
2019-09-06 13:20:35 -07:00
committed by GitHub
parent 3b04c642ae 6f9c621774
commit 29d24d7e08
1 changed files with 19 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
R/server.R
View File

@@ -85,24 +85,25 @@ addResourcePath <- function(prefix, directoryPath) {
}
)
# Often times overwriting a resource path is "what you want",
# but sometimes it can lead to difficult to diagnose issues
# (e.g. an implict dependency might set a resource path that
# conflicts with what you, the app author, are trying to register)
# Note that previous versions of shiny used to warn about this case,
# but it was eventually removed since it caused confusion (#567).
# It seems a good comprimise is to throw a more information message.
if (prefix %in% names(.globals$resourcePaths)) {
existingPath <- .globals$resourcePaths[[prefix]]$path
if (normalizedPath != existingPath) {
message(
"The resource path '", prefix, "' used to point to ",
existingPath, ", but it now points to ", normalizedPath, ". ",
"If your app doesn't work as expected, you may want to ",
"choose a different prefix name."
)
}
}
# # Often times overwriting a resource path is "what you want",
# # but sometimes it can lead to difficult to diagnose issues
# # (e.g. an implict dependency might set a resource path that
# # conflicts with what you, the app author, are trying to register)
# # Note that previous versions of shiny used to warn about this case,
# # but it was eventually removed since it caused confusion (#567).
# # It seems a good compromise is to throw a more information message.
# if (getOption("shiny.resourcePathChanges", FALSE) &&
# prefix %in% names(.globals$resourcePaths)) {
# existingPath <- .globals$resourcePaths[[prefix]]$path
# if (normalizedPath != existingPath) {
# message(
# "The resource path '", prefix, "' used to point to ",
# existingPath, ", but it now points to ", normalizedPath, ". ",
# "If your app doesn't work as expected, you may want to ",
# "choose a different prefix name."
# )
# }
# }
# If a shiny app is currently running, dynamically register this path with
# the corresponding httpuv server object.