github/shiny
1
1
Fork 0
mirror of https://github.com/rstudio/shiny.git synced 2026-02-08 13:45:28 -05:00
Code Issues Packages Projects Releases Wiki Activity

missed input_binding_slider.js

Browse Source
This commit is contained in:
Carson Sievert
2019-05-03 15:48:47 -05:00
parent 370f1b51ee
commit 2d2cf96f5e
6 changed files with 13 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
srcjs/input_binding_slider.js
View File

@@ -130,10 +130,7 @@ $.extend(sliderInputBinding, textInputBinding, {
}
}
var escape_id = $escape(el.id);
var labelNode = $(el).parent().find('label[for="' + escape_id + '"]');
var labelHTML = "<label for='" + escape_id + "'></label>";
updateLabel(data.label, labelNode, labelHTML, el);
updateLabel(data.label, this._getLabelNode(el));
var domElements = ['data-type', 'time-format', 'timezone'];
for (var i = 0; i < domElements.length; i++) {
@@ -176,7 +173,9 @@ $.extend(sliderInputBinding, textInputBinding, {
$el.ionRangeSlider(opts);
},
_getLabelNode: function(el) {
return $(el).parent().find('label[for="' + $escape(el.id) + '"]');
},
// Number of values; 1 for single slider, 2 for range slider
_numValues: function(el) {
if ($(el).data('ionRangeSlider').options.type === 'double')

2
srcjs/input_binding_text.js
View File

@@ -36,7 +36,7 @@ $.extend(textInputBinding, {
},
getState: function(el) {
return {
label: this._getLabelNode().text(),
label: this._getLabelNode(el).text(),
value: el.value,
placeholder: el.placeholder
};