From 0ef15fa6621b39d977c3239b63cd9ec4bfd25b23 Mon Sep 17 00:00:00 2001 From: Winston Chang Date: Fri, 24 Feb 2017 15:20:58 -0600 Subject: [PATCH 1/2] Remove redundant calls to setInput --- srcjs/init_shiny.js | 4 ---- 1 file changed, 4 deletions(-) diff --git a/srcjs/init_shiny.js b/srcjs/init_shiny.js index 2a37e9b89..a99141cc6 100644 --- a/srcjs/init_shiny.js +++ b/srcjs/init_shiny.js @@ -160,10 +160,6 @@ function initShiny() { binding: binding, bindingType: 'input' }); - - if (shinyapp.isConnected()) { - valueChangeCallback(binding, el, false); - } } } From 5f8cd82a09ec32d1089a01adc842f56926caa009 Mon Sep 17 00:00:00 2001 From: Winston Chang Date: Fri, 24 Feb 2017 15:33:55 -0600 Subject: [PATCH 2/2] Update NEWS --- NEWS.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/NEWS.md b/NEWS.md index 150aab705..f89472b14 100644 --- a/NEWS.md +++ b/NEWS.md @@ -32,6 +32,8 @@ in shiny apps. For more info, see the documentation (`?updateQueryString` and `? * Fixed [#1472](https://github.com/rstudio/shiny/issues/1472): With a Progress object, calling `set(value=NULL)` made the progress bar go to 100%. Now it does not change the value of the progress bar. The documentation also incorrectly said that setting the `value` to `NULL` would hide the progress bar. ([#1547](https://github.com/rstudio/shiny/pull/1547)) +* Removed redundant call to `inputs.setInput`. ([#1595](https://github.com/rstudio/shiny/pull/1595)) + ### Library updates * Closed [#1500](https://github.com/rstudio/shiny/issues/1500): Updated ion.rangeSlider to 2.1.6. ([#1540](https://github.com/rstudio/shiny/pull/1540))