github/shiny
1
1
Fork 0
mirror of https://github.com/rstudio/shiny.git synced 2026-02-08 13:45:28 -05:00
Code Issues Packages Projects Releases Wiki Activity

Code review feedback--use an arrow function instead of aliasing this

Browse Source
This commit is contained in:
Joe Cheng
2018-09-18 10:52:50 -07:00
parent ef63679ff0
commit 3b62400298
4 changed files with 23 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
srcjs/input_binding_select.js
View File

@@ -115,12 +115,11 @@ $.extend(selectInputBinding, {
$(el).trigger('change');
},
subscribe: function(el, callback) {
var thiz = this;
$(el).on('change.selectInputBinding', function(event) {
$(el).on('change.selectInputBinding', event => {
// https://github.com/rstudio/shiny/issues/2162
// Prevent spurious events that are gonna be squelched in
// a second anyway by the onItemRemove down below
if (el.nonempty && thiz.getValue(el) === "") {
if (el.nonempty && this.getValue(el) === "") {
return;
}
callback();