From 4e78ed95bc3b5036ca8ca856d615fd4a87c8e29f Mon Sep 17 00:00:00 2001 From: Carson Date: Wed, 2 Jul 2025 20:00:02 -0500 Subject: [PATCH] Minimal fix to address the regression in #4239 Ideally we'd fix this issue, and also get updateActionButton() working with HTML labels, but thanks to today's release of kinesis (which snapshots all of actionButton()s markup), and CRAN dragging their feet to accept our original submission (which was fine, by the way), we can't have nice things --- R/update-input.R | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/R/update-input.R b/R/update-input.R index 85cfffb24..74e49f92b 100644 --- a/R/update-input.R +++ b/R/update-input.R @@ -181,22 +181,14 @@ updateCheckboxInput <- function(session = getDefaultReactiveDomain(), inputId, l updateActionButton <- function(session = getDefaultReactiveDomain(), inputId, label = NULL, icon = NULL, disabled = NULL) { validate_session_object(session) - message <- dropNulls(list( - label = if (!is.null(label)) processDeps(label, session), - icon = if (!is.null(icon)) processDeps(validateIcon(icon), session), - disabled = disabled - )) + if (!is.null(icon)) icon <- as.character(validateIcon(icon)) + message <- dropNulls(list(label=label, icon=icon, disabled=disabled)) session$sendInputMessage(inputId, message) } #' @rdname updateActionButton #' @export updateActionLink <- function(session = getDefaultReactiveDomain(), inputId, label = NULL, icon = NULL) { - updateActionButton( - session, - inputId = inputId, - label = label, - icon = icon - ) + updateActionButton(session, inputId=inputId, label=label, icon=icon) }