From a01fcc51949456a387343813dbcdbd3cff5ef1d4 Mon Sep 17 00:00:00 2001 From: Barret Schloerke Date: Fri, 10 Oct 2025 16:30:47 -0400 Subject: [PATCH] chore(check): Fix minor check warnings (#4299) --- .Rbuildignore | 1 + npm-README.md => README-npm.md | 0 package.json | 2 +- tests/testthat/test-plot-coordmap.R | 10 +++++++++- 4 files changed, 11 insertions(+), 2 deletions(-) rename npm-README.md => README-npm.md (100%) diff --git a/.Rbuildignore b/.Rbuildignore index 831f19124..913e64a7f 100644 --- a/.Rbuildignore +++ b/.Rbuildignore @@ -32,3 +32,4 @@ ^eslint\.config\.mjs$ ^_dev$ ^.claude$ +^README-npm\.md$ diff --git a/npm-README.md b/README-npm.md similarity index 100% rename from npm-README.md rename to README-npm.md diff --git a/package.json b/package.json index 72bfddb12..9bd1ad4b1 100644 --- a/package.json +++ b/package.json @@ -70,7 +70,7 @@ "coverage_detailed": "npx --yes type-check --detail", "coverage": "type-coverage -p tsconfig.json --at-least 90", "circular": "npx --yes dpdm --transform ./srcts/src/index.ts", - "prepack": "cp README.md README-orig.md && cp npm-README.md README.md", + "prepack": "cp README.md README-orig.md && cp README-npm.md README.md", "postpack": "test -f README-orig.md && cp README-orig.md README.md && rm README-orig.md" }, "prettier": { diff --git a/tests/testthat/test-plot-coordmap.R b/tests/testthat/test-plot-coordmap.R index db20f16a8..72a857534 100644 --- a/tests/testthat/test-plot-coordmap.R +++ b/tests/testthat/test-plot-coordmap.R @@ -348,12 +348,20 @@ test_that("ggplot coordmap with various scales and coords", { sortList(list(left=10, right=20, bottom=0, top=5)) ) + coord_transform_universal <- function(...) { + if (packageVersion("ggplot2") >= "4.0.0") { + coord_transform(...) + } else { + coord_trans(...) + } + } + # Log scales and log coord transformations dat <- data.frame(xvar = c(10^-1, 10^3), yvar = c(2^-2, 2^4)) p <- ggplot(dat, aes(xvar, yvar)) + geom_point() + scale_x_log10(expand = c(0 ,0)) + scale_y_continuous(expand = c(0, 0)) + - coord_trans(y = "log2") + coord_transform_universal(y = "log2") png(tmpfile) m <- getGgplotCoordmap(print(p), 500, 400, 72) dev.off()