github/shiny
1
1
Fork 0
mirror of https://github.com/rstudio/shiny.git synced 2026-02-08 13:45:28 -05:00
Code Issues Packages Projects Releases Wiki Activity

Updates to Winston's feedback: removed for ... of iteration that is not supported in IE.

Browse Source
This commit is contained in:
Timothy Mastny
2018-06-21 16:17:42 -05:00
parent 881fe0cfce
commit a24bdabf08
2 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
srcjs/input_binding_slider.js
View File

@@ -123,17 +123,22 @@ $.extend(sliderInputBinding, textInputBinding, {
}
}
var sliderFeatures = ['min', 'max', 'step'];
for (var feats of sliderFeatures) {
if (data.hasOwnProperty(feats)) msg[feats] = data[feats];
for (var i = 0; i < sliderFeatures.length; i++) {
var feats = sliderFeatures[i];
if (data.hasOwnProperty(feats)) {
msg[feats] = data[feats];
}
}
if (data.hasOwnProperty('label'))
$el.parent().find('label[for="' + $escape(el.id) + '"]').text(data.label);
var domElements = ['data-type', 'time-format', 'timezone'];
for (var elm of domElements) {
if (data.hasOwnProperty(elm))
$el.data(elm, data[elm]);
for (var i = 0; i < domElements.length; i++) {
var elem = domElements[i];
if (data.hasOwnProperty(elem)) {
$el.data(elem, data[elem]);
}
}
var dataType = $el.data('data-type');