github/shiny
1
1
Fork 0
mirror of https://github.com/rstudio/shiny.git synced 2026-04-29 03:00:45 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(input_slider): Make sure last used handle is always above others (#4131)

Browse Source
This commit is contained in:
Garrick Aden-Buie
2024-09-27 10:09:43 -04:00
committed by GitHub
parent 9d12b0fca7
commit c489fef4ff
4 changed files with 21 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
NEWS.md
View File

@@ -4,14 +4,18 @@
* Small improvements to the default pulse busy indicator to better blend with any background. It's also now slightly smaller by default. (#4122) * Small improvements to the default pulse busy indicator to better blend with any background. It's also now slightly smaller by default. (#4122)
## Bug fixes
* Fixed a bug in `conditionalPanel()` that would cause the panel to repeatedly show/hide itself when the provided condition was not boolean. (@kamilzyla, #4127)
* Fixed a bug with `input_slider()` when used as a range slider that made it impossible to change the slider value when both handles were at the maximum value. (#4131)
# shiny 1.9.1 # shiny 1.9.1
## Bug fixes ## Bug fixes
* Fixed a bug introduced in v1.9.0 where the boundaries of hover/click/brush regions on plots were being incorrectly scaled when browser zoom was used. (#4111) * Fixed a bug introduced in v1.9.0 where the boundaries of hover/click/brush regions on plots were being incorrectly scaled when browser zoom was used. (#4111)
* Fixed a bug in `conditionalPanel()` that would cause the panel to repeatedly show/hide itself when the provided condition was not boolean. (@kamilzyla, #4127)
# shiny 1.9.0 # shiny 1.9.0
## New busy indication feature ## New busy indication feature

4
inst/www/shared/ionrangeslider/css/ion.rangeSlider.css
View File

@@ -235,6 +235,10 @@
z-index: 2; z-index: 2;
} }
.irs--shiny .irs-handle.type_last {
z-index: 3;
}
.irs--shiny .irs-handle.state_hover, .irs--shiny .irs-handle:hover { .irs--shiny .irs-handle.state_hover, .irs--shiny .irs-handle:hover {
background: #fff; background: #fff;
} }

5
inst/www/shared/ionrangeslider/scss/shiny.scss
View File

@@ -143,6 +143,11 @@ $font-family: $font-family-base !default;
border-radius: $handle_width; border-radius: $handle_width;
z-index: 2; z-index: 2;
&.type_last {
// Ensure last-used handle is on top if it overlaps with another handle
z-index: 3;
}
&.state_hover, &.state_hover,
&:hover { &:hover {
background: $handle_color_hover; background: $handle_color_hover;

7
tools/ion.rangeSlider-patches/0001-Add-skin-customized-for-Shiny.patch
View File

@@ -3,7 +3,7 @@ new file mode 100644
index 00000000..ba052f8b index 00000000..ba052f8b
--- /dev/null --- /dev/null
+++ b/inst/www/shared/ionrangeslider/scss/shiny.scss +++ b/inst/www/shared/ionrangeslider/scss/shiny.scss
@@ -0,0 +1,201 @@ @@ -0,0 +1,206 @@
+/* 'shiny' skin for Ion.RangeSlider, largely based on the 'big' skin, but with smaller dimensions, grayscale grid text, and without gradients +/* 'shiny' skin for Ion.RangeSlider, largely based on the 'big' skin, but with smaller dimensions, grayscale grid text, and without gradients
+© Posit, PBC, 2023 +© Posit, PBC, 2023
+© RStudio, Inc, 2014 +© RStudio, Inc, 2014
@@ -149,6 +149,11 @@ index 00000000..ba052f8b
+ border-radius: $handle_width; + border-radius: $handle_width;
+ z-index: 2; + z-index: 2;
+ +
+ &.type_last {
+ // Ensure last-used handle is on top if it overlaps with another handle
+ z-index: 3;
+ }
+
+ &.state_hover, + &.state_hover,
+ &:hover { + &:hover {
+ background: $handle_color_hover; + background: $handle_color_hover;