* Use double-tilde for strikethrough in Markdown tests
The current dev version of commonmark has disabled single tilde for strikethrough: https://github.com/r-lib/commonmark/pull/33 Using double-tilde will make it consistent with Pandoc's Markdown (where single-tilde is for subscripts).
* Skip tests if commonmark is outdated
* Revert "Skip tests if commonmark is outdated"
This reverts commit 97bee20863.
---------
Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
* First pass at a proper state machine for managing output progress state
* `yarn build` (GitHub Actions)
* Add useBusyIndicators(), spinnerOptions(), and pulseOptions()
* Bring in new spinner defaults
* Use an actual div instead of a pseudo-element since chromium can't be trusted to show them when animated
* Revert "Use an actual div instead of a pseudo-element since chromium can't be trusted to show them when animated"
This reverts commit 6167c1dfd7.
* Embed animation inside svg (to avoid Chromium bug). Consolidate options into a singular busyIndicatorOptions()
* Add to pkgdown reference
* `devtools::document()` (GitHub Actions)
* `yarn build` (GitHub Actions)
* Bump version
* `yarn build` (GitHub Actions)
* Sync package version (GitHub Actions)
* Apply suggestions from code review
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com>
* Update snapshots
* `devtools::document()` (GitHub Actions)
* Address feedback
* Bring in more spinner type options
* fix use of fs
* Code review
* `devtools::document()` (GitHub Actions)
* Sync package version (GitHub Actions)
* Update snapshots
* Fix comments
* Make snapshot consistent cross-platform
* Fix namespace issue
* Reduce specificity of position relative
* Skip snapshot on windows; update news
* Whoops
* Scope spinner customizations to parent element by default
* Update snapshots
* Reorder spinner types
* Set a private random seed in tests
* Better id naming
---------
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com>
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com>
* Close#4011. Fix and simplify reactlog's version check approach.
* Better variable name
* Use test_path() for consistent path location
* Just use packageDescription()
* Update tests/testthat/test-reactlog.R
* Update tests/testthat/test-reactlog.R
* Update DESCRIPTION
* Revert "feat: Deprecate with warnings, expect `renderDataTable()` to be deprecated (#4007)"
This reverts commit a8c6065b9f.
* Use shiny's datatables implementation when testing
* feat: Deprecate with a warning
Use `rlang::warn()` instead of `rlang::inform()` and use the lifecycle warning class so that lifecycle infrastructure works
* tests: expect that renderDataTable is deprecated
* tests: invert warning and error expectation
* feat(shiny.error.unhandled): Allow users to provide an unhandled error handler
* Extract `shinyUserErrorUnhandled()` to use in MockSession too
* tests(shiny.error.unhandled): Test that unhandled errors are handled safely
* docs: Clarify that session still ends with an unhandled error
* docs: Add news item
* Start release candidate
* Get rid of warnings about qplot() usage in tests
* Clean up news
* `yarn build` (GitHub Actions)
* Sync package version (GitHub Actions)
* Remote remotes (htmltools is now in CRAN)
* Change header syntax in NEWS.md (to match what usethis does)
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com>
* Close#1409: don't supply width/height to the device if they aren't defined
* Update news
* Update unit tests to reflect that plotPNG()/startPNG() now handles NULL dimensions
* Add a note about NULL dimensions on plotPNG() help page
* Update news
* Close#3704. Close#3735. Close#1409. Throw informative error in renderPlot() early if height/width of a plot aren't yet defined
* `devtools::document()` (GitHub Actions)
* Add unit tests
* Use consistent filename; add intentional failure (to get artifact uploads)
* Make output id argument name more unique
* Update news
* plotPNG() test isn't worth it
* Don't try to provide a suggestion on how to fix the issue (it's no worse than what we currently have, and we probably should be defaulting to an 'arbitrary' size anyway
* update news
* minimize diff
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com>
* Fix#3250
pruneStackTrace was interacting badly with dplyr errors. I'm still
not sure what causes these new cases, but the new behavior seems to
be much better, with no downside that I can think of.
* Fix existing unit tests
* Update news
Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
* Don't kill the session when a debounced/throttled reactive expr errors
Fixes#3581
* Update NEWS with PR number
Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
* Follow up to #3366: don't change sliderInput()'s default accent color
* Update news
* nav_append not tab_append 🤦
* bslib no longer tries to mark a non-tabPanel as active
* Use `fontawesome::fa_i()` for FA <i> tags
* Remove fontawesome vendor files
* Add fontawesome pkg to Imports & Remotes
* Remove FontAwesome `person()` entry
* Remove Font Awesome license info
* Delete font-awesome.R
* Update 'Collate' field (removes 'font-awesome.R')
* Delete updateFontAwesome.R
* Prefer use of `fontawesome::fa()`
* Improve function documentation
* Update help file using roxygen
* Modify icon name
* Update icon name in example
* Modify icon name in example
* Update help files
* Update bootstrap.R
* Update icon.Rd
* Update bootstrap.R
* Revert `showcaseCodeTabs()` to use FA v4 name
* Revert icon name in example (back to FA v4)
* Remove `call. = FALSE` in `stop()`
* Remove `fontawesome` from Remotes
* Add min version req for the fontawesome pkg
* Increase minimum version requirement for fontawesome
* Update roxygen docs for `icon()`
* Document (GitHub Actions)
* Update icon.Rd
* Generate early return <i> tag for tabsetPanel logic
* Close#3384 and #3383: simplify and correct icon() logic
* Install htmltools PR for now
* Document (GitHub Actions)
* Avoid using tag attribs to hold non-attribute values
* Better legacy support
* No need to call prepTabIcon() twice
* code review
* Fix glyphicon class creation
* update news
Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
Co-authored-by: rich-iannone <rich-iannone@users.noreply.github.com>
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com>
