* Put action icon and label into containers
* Update snaps
* More robust test
* Don't include container if icon/label isn't specified
* `yarn build` (GitHub Actions)
* Send HTML string/deps on update; update news
---------
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com>
* v1.11.1 release candidate
* `yarn build` (GitHub Actions)
* Revert actionButton()/actionLink() implementation to v1.11.0's behavior (re-introducing #4239)
* Minimal fix to address the regression in #4239
Ideally we'd fix this issue, and also get updateActionButton() working with HTML labels, but thanks to today's release of kinesis (which snapshots all of actionButton()s markup), and CRAN dragging their feet to accept our original submission (which was fine, by the way), we can't have nice things
* `yarn build` (GitHub Actions)
---------
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com>
* Revert the addition of spacing between icon and label in actionButton()
* `yarn build` (GitHub Actions)
---------
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com>
* Close#4239: fix front-end action button label updating logic (follow up to #3996)
* Update news
* Use a separator instead of putting markup in attributes
* `yarn build` (GitHub Actions)
* Address feedback
* Cleanup
* Refactor into a single method to split icon/label
* `yarn build` (GitHub Actions)
* Better naming
* Add some padding to the separator
* Add some unit tests for R logic
* Update NEWS.md
* Update NEWS.md
* Update NEWS.md
* Update NEWS.md
* Increase backcompat (keep same R structure when no icon is provided)
* Refine comment
---------
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com>
* Cleaner logic for conditional CSS styles
It's really only plotOutput() that behaves differently;
previously it was not possible to specify a NULL width
or height and not get broken styles
* require dev version of htmltools
Co-authored-by: Joe Cheng <joe@rstudio.com>
* adding section to roxygen docs for server value of input funcs
* add more server values to roxygen docs
* add more server values
* update more server values in documentation
* Address PR feedback
I reflowed the comments to have a max width of 80 on some files, so there were a flurry of line changes, but the only substantive changes were around Joe's comments.
* Update R/input-slider.R
Co-Authored-By: Hadley Wickham <h.wickham@gmail.com>
* Apply suggestions from code review
Co-Authored-By: Carson Sievert <cpsievert1@gmail.com>
* PR feedback, regenerate docs.
* PR Feedback
* Eliminate extra newline
* passwordInput()'s server value
* varSelectInput()'s server value
* document