Joe Cheng
1d04b21876
Fix reactlog session token for "exit" actions
...
The "exit" actions were not being saved with the correct session
token, because on.exit() calls inside of withReactiveDomain() get
executed *after* the end of the withReactiveDomain.
2016-07-22 15:55:35 -07:00
Joe Cheng
e38c9443d9
Remove extraneous self$ prefixes
2016-07-22 15:26:07 -07:00
Joe Cheng
fb4ad55cac
Fix #931 : Observer memory leak
...
Observers were being prevented from being garbage collected by
their own onReactiveDomainEnded() event handlers. This commit
fixes that by making sure that those event handlers are only
registered when autoDestroy=TRUE, and that they are unregistered
both on destruction and when autoDestroy is changed.
2016-07-22 15:23:49 -07:00
Winston Chang
28547e90d1
Fix memory leak ( #1254 )
...
* When observer is destroyed, invalidate context. Closes #1253
* Update NEWS
2016-07-20 21:01:29 -07:00
Joe Cheng
f70187597f
Merge pull request #1222 from rstudio/joe/bugfix/chrome-unsafe-ports
...
Don't use randomly-chosen port numbers that Chrome deems unsafe
2016-07-20 13:36:05 -07:00
Dean Attali
faccc42b22
fix typo
2016-07-17 02:42:41 -04:00
Barbara Borges Ribeiro
2c5e9a5e76
moved multiple to 4th argument
2016-07-06 21:44:52 +01:00
Barbara Borges Ribeiro
26d6e4da2c
allows callback to be garbage collected
2016-07-06 21:29:12 +01:00
Barbara Borges Ribeiro
24aab4d5d3
Merge branch 'master' of https://github.com/rstudio/shiny
2016-07-06 14:18:49 +01:00
Barbara Borges Ribeiro
2eb69d421a
fix to outputOptions
2016-07-06 14:18:38 +01:00
Joe Cheng
8b3aff599b
Don't use randomly-chosen port numbers that Chrome deems unsafe
...
Still OK to use these ports if the user asks for them explicitly
2016-06-25 22:37:22 -07:00
Joe Cheng
4c652389c5
Support pool package
2016-06-14 12:58:50 -07:00
Winston Chang
bf52075d1b
Merge pull request #1197 from rstudio/joe/feature/resetBrush
...
Add ability to reset brush with session$resetBrush/Shiny.resetBrush
2016-06-03 13:04:01 -05:00
Winston Chang
77a9b66028
Merge pull request #1201 from rstudio/bugfix/avoid-radix-sort-overflow
...
avoid overflow in R 3.3.0 radix sort
2016-05-27 21:39:15 -05:00
Kevin Ushey
e813dab81c
avoid overflow in R 3.3.0 radix sort
2016-05-27 14:48:44 -07:00
Joe Cheng
360c1d5953
Add ability to reset brush with session$resetBrush/Shiny.resetBrush
2016-05-25 15:37:27 -07:00
Winston Chang
9588c36abb
Merge branch 'joe/feature/insert-UI'
2016-05-18 15:53:50 -05:00
Barbara Borges Ribeiro
f9200ac135
small fixes; documentation; got rid of unnecassary things
2016-05-18 12:35:25 +01:00
Winston Chang
fffb9606ec
Merge pull request #1185 from rstudio/barbara/showcase-update
...
Barbara/showcase update
2016-05-16 10:04:24 -05:00
Barbara Borges Ribeiro
e92eee5ffc
removed constraint that forced elements inserted with insertUI to be wrapped in a div/span
2016-05-13 15:28:02 -05:00
Barbara Borges Ribeiro
293c1d471c
tiny fix
2016-05-13 14:34:07 -05:00
Barbara Borges Ribeiro
2269e05058
code highliting; dropdown menu for the www files
2016-05-12 15:12:04 -05:00
Barbara Borges Ribeiro
dd7a3269ad
added wwwFiles boolean option to DESCRIPTION file
2016-05-07 17:21:59 +01:00
Winston Chang
157d1b20c5
Fixes for R CMD check
2016-05-06 15:14:09 -05:00
Winston Chang
91092b8a96
Fix function labels for profiling
2016-05-06 15:03:00 -05:00
Barbara Borges Ribeiro
1ed237cfcc
init commit
2016-05-05 16:11:43 +01:00
Joe Cheng
1d2a2fbcae
Merge remote-tracking branch 'origin/joe/feature/insert-UI'
2016-05-04 11:34:54 -07:00
Barbara Borges Ribeiro
9b015e8cae
documentation update
2016-05-03 13:57:10 +01:00
Barbara Borges Ribeiro
506de72666
fixed typos; included argument defaults; removed 'shown', 'hidden' triggers following chat with Winston
2016-05-02 18:27:15 +01:00
Barbara Borges Ribeiro
53790f8247
various updates
2016-05-02 14:48:05 +01:00
Barbara Borges Ribeiro
69780d4727
added sendImage and sendOUtputHIddenState
2016-04-29 06:33:06 +01:00
Barbara Borges Ribeiro
aa2b644684
updated documentation; added ... argument to onFlush() and onFlushed() in order to be able to pass in arguments to the func
2016-04-29 05:27:26 +01:00
Barbara Borges Ribeiro
a12e8875a6
changed everything from sendCustomMessage to session$sendMessage
2016-04-29 05:16:22 +01:00
Barbara Borges Ribeiro
9e91b265ce
sendInsertUI now uses sendMessage instead of sendCustomMessage
2016-04-29 04:46:09 +01:00
Barbara Borges Ribeiro
8c12e3ab90
added insertAdjacentElement for compatibility with Firefox
2016-04-28 12:03:15 +01:00
Winston Chang
7e303b4fc0
Merge pull request #1157 from rstudio/modal
...
Add modal dialogs
2016-04-27 15:30:02 -05:00
Winston Chang
40e0fcff30
Change modal example
2016-04-27 15:29:18 -05:00
Barbara Borges Ribeiro
6b001eb7c3
updated insertUI; added removeUI
2016-04-25 23:03:18 +01:00
Winston Chang
f81621aa66
Merge pull request #1158 from rstudio/example-cleanup
...
Clean up examples
2016-04-22 13:05:36 -05:00
Winston Chang
08c7484087
Rename argument
2016-04-21 15:22:43 -05:00
Barbara Borges Ribeiro
a8c68f3e30
updated shiny-options text
2016-04-18 17:28:45 +01:00
Barbara Borges Ribeiro
f3d4f9ff23
Merge pull request #1156 from rstudio/barbara/error-hiding
...
Barbara/error hiding
2016-04-18 01:56:26 +01:00
Barbara Borges Ribeiro
d711f17081
changed sanitization default to FALSE (on local development)
2016-04-18 01:44:43 +01:00
Barbara Borges Ribeiro
d35eba45c5
tiny fix
2016-04-18 01:34:50 +01:00
Barbara Borges Ribeiro
cd53e79b19
removed classError argument to safeError function
2016-04-18 01:27:37 +01:00
Barbara Borges Ribeiro
3db7029534
Merge branch 'master' of https://github.com/rstudio/shiny
2016-04-15 16:50:19 +01:00
Barbara Borges Ribeiro
ad1e52bf19
got rid of warning that popped up when renderFunc took no arguments; there really isn't a good reason to require this (not at this point at least)
2016-04-15 16:49:52 +01:00
Barbara Borges Ribeiro
e08791a284
update to safeError
2016-04-14 18:20:49 +01:00
Barbara Borges Ribeiro
033d513aee
added version to shinyDeprecated call; updated NEWS
2016-04-14 17:43:24 +01:00
Barbara Borges Ribeiro
fb3e4e4881
Changed customStop to stop(safeError). Refactored some middleware.R code. Fixed downloadHandler's bug of not responding to safeError.
2016-04-14 17:31:34 +01:00