Barbara Borges Ribeiro
751e8c189e
fixes #1093 ( #1291 )
...
* fixes #1093
* check if NULL
2016-08-11 14:29:24 -07:00
Winston Chang
183e9a3d0b
Bookmarking fixes ( #1281 )
...
* Rename invalidateReactiveValue to freezeReactiveValue
* Make onFlush and onFlushed use 'once' argument
* session$flushOutput: schedule another flush if needed
* Catch all errors before they propagate to websocket
* Restore original logic for progressKeys
2016-08-11 11:58:07 -07:00
Winston Chang
5f0f4dd485
Merge pull request #1285 from rstudio/joe/bugfix/update-radio-buttons-modules
...
Fix #1144 : RadioButtons and checkBoxGroup do not work in modules when they are updated
2016-08-11 13:17:15 -05:00
Barbara Borges Ribeiro
20f05662aa
fixes #1289
2016-08-11 15:57:31 +01:00
Joe Cheng
963471b43f
Fix #1144 : RadioButtons and checkBoxGroup do not work in modules when they are updated
...
The unqualified input ID was being used to generate name attributes
on radio and checkboxes.
2016-08-10 15:52:01 -07:00
Winston Chang
d1e4483f98
Upgrade to Font-Awesome 4.6.3. Closes #1274
2016-08-10 15:40:10 -05:00
Winston Chang
b194ada316
Upgrade to Bootstrap 3.3.7
2016-08-10 15:34:51 -05:00
Winston Chang
3a25a2dcbf
Upgrade to jQuery 1.12.4. Closes #1251
2016-08-10 15:24:08 -05:00
Barbara Borges Ribeiro
85e4497fbe
fixes #1270 ; improves docs; export isTruthy()
2016-08-10 20:45:40 +01:00
Barbara Borges Ribeiro
013599890f
Solve updateSelectInput bug in IE 11.0 ( #1277 )
2016-08-09 19:08:30 +01:00
Winston Chang
519e552405
Unset shinyOptions when set to NULL
2016-08-08 13:03:07 -05:00
Winston Chang
3223332906
Merge pull request #1209 from wch/bookmarkable-state
...
Bookmarkable state
2016-08-05 16:15:12 -05:00
Winston Chang
f78bd08440
Correctly handle bookmark options for global.R and app.R
2016-08-05 16:08:49 -05:00
Winston Chang
99b5f92d7a
Add showBookmarkUrlModal
2016-08-03 16:07:49 -05:00
Barbara Borges Ribeiro
1cc5e84104
Barbara/error handling/port as socket ( #1263 )
...
* catch if `port` is being used incorrectly (see issue #971 )
* better error msg
2016-08-03 15:50:30 -05:00
Winston Chang
8346f5ab08
Fix enableBookmarking references
2016-08-03 14:41:37 -05:00
Winston Chang
75e7c4b2ca
More informative error messages
2016-08-02 11:10:17 -05:00
Barbara Borges Ribeiro
8a2846461b
removed extra line at end of example section
2016-08-02 03:40:56 +01:00
Winston Chang
6bfb9a2f57
More details in enableBookmarking man page
2016-08-01 20:46:43 -05:00
Winston Chang
85dfb2d4eb
urlModal: always show Ctrl/Cmd-C copy message
2016-08-01 20:00:05 -05:00
Winston Chang
829494c03e
Make bookmark button work when there's a submitButton
2016-08-01 16:13:43 -05:00
Winston Chang
f89fade28d
Rename updateLocationBar to updateQueryString
2016-08-01 16:13:25 -05:00
Winston Chang
9081b1dadd
Simplify list2env
2016-08-01 14:22:23 -05:00
Winston Chang
84dac544af
Make sure state ID doesn't have invalid chars
2016-08-01 14:16:50 -05:00
Winston Chang
49f1ac333d
Always get appDir when shinyApp object is created
2016-08-01 14:01:16 -05:00
Winston Chang
54bd3d480f
Fixes for R CMD check
2016-07-29 15:59:56 -05:00
Winston Chang
b281f8fa32
Merge branch 'master' into bookmarkable-state
2016-07-29 15:47:31 -05:00
Winston Chang
a3732f845e
Update bookmarking documentation
2016-07-27 16:17:21 -05:00
Winston Chang
38f6d0a020
When restoring modules, only provide state$dir if present
2016-07-26 16:24:36 -05:00
Winston Chang
a0e5da758a
Ensure that state$values can't be replaced
2016-07-26 16:24:02 -05:00
Winston Chang
dcbe10c1c7
Keep state$values as an environment for save and restore
2016-07-26 14:33:04 -05:00
Joe Cheng
1f823d2a1b
Fix #931 : Observer memory leak ( #1256 )
...
* Fix #931 : Observer memory leak
Observers were being prevented from being garbage collected by
their own onReactiveDomainEnded() event handlers. This commit
fixes that by making sure that those event handlers are only
registered when autoDestroy=TRUE, and that they are unregistered
both on destruction and when autoDestroy is changed.
* Remove extraneous self$ prefixes
* Add comment explaining autoDestroyHandle
2016-07-26 11:56:47 -07:00
Winston Chang
12d0a9e11a
For session_proxy, add [[ and disallow $<- and [[<- ( #1262 )
2016-07-26 11:21:38 -07:00
Winston Chang
50f213ae71
Fixes for R CMD check
2016-07-26 10:32:13 -05:00
Winston Chang
91d4fd8849
Fix behavior when onBookmark() is called multiple times in a module
2016-07-25 22:29:55 -05:00
Winston Chang
3f1985a9dc
Allow modules to exclude their inputs
2016-07-25 22:10:38 -05:00
Winston Chang
573a71f09d
New version of reactiveValuesToList
2016-07-25 16:32:01 -05:00
Winston Chang
57900fa287
Move methods out of ShinySaveState
2016-07-25 16:31:47 -05:00
Winston Chang
fa721d9614
More informative comments
2016-07-25 16:31:47 -05:00
Winston Chang
e64bbacf68
Define filterNamespace and unNamespace locally
2016-07-25 16:31:47 -05:00
Winston Chang
6ee2edc757
Add namespace support to reactiveValuesToList
2016-07-25 13:58:21 -05:00
Winston Chang
9ec4faf0d0
Allow modules to call onBookmark, onRestore, onRestored
2016-07-25 10:52:41 -05:00
Winston Chang
5be3ba2ffa
Use Callbacks objects for bookmarking callbacks
2016-07-21 15:28:43 -05:00
Winston Chang
a5ee96656b
Add onFlush, onFlushed, and onSessionEnded functions
2016-07-21 14:33:43 -05:00
Winston Chang
dcf321047f
When bookmarkStore="disable", don't restore
2016-07-21 13:55:45 -05:00
Winston Chang
4982110be9
configureBookmarking affect next shinyApp object creation
2016-07-21 12:49:36 -05:00
Winston Chang
28547e90d1
Fix memory leak ( #1254 )
...
* When observer is destroyed, invalidate context. Closes #1253
* Update NEWS
2016-07-20 21:01:29 -07:00
Joe Cheng
f70187597f
Merge pull request #1222 from rstudio/joe/bugfix/chrome-unsafe-ports
...
Don't use randomly-chosen port numbers that Chrome deems unsafe
2016-07-20 13:36:05 -07:00
Winston Chang
1c970c8176
Remove configureBookmarking; add onBookmark, onBookmarked, onRestore, onRestored
2016-07-19 14:31:57 -05:00
Dean Attali
faccc42b22
fix typo
2016-07-17 02:42:41 -04:00
