Winston Chang
ce0f2c51a9
Use explicit namespaces
2016-01-12 13:33:14 -06:00
Joe Cheng
7e6a68a2b1
CRAN maintainers prefer \donttest over \dontrun
2016-01-12 10:10:16 -08:00
Joe Cheng
caca515ba0
Tweaks for improved staticdocs rendering
...
- \donttest -> \dontrun, otherwise staticdocs hangs
- Put NS before ns.sep so usage entries are in a better order
2016-01-11 12:20:19 -08:00
Winston Chang
be1081a4b9
Add note about printing ggplot2 graphics
2016-01-06 14:11:16 -06:00
Joe Cheng
1608b652d7
Fix unnecessary :::
2016-01-05 14:02:16 -08:00
Winston Chang
f477dcba4a
Merge pull request #1068 from rstudio/template-bootstrap
...
Pull out bootstrapLib into separate function
2016-01-05 15:30:32 -06:00
Winston Chang
6c5f0c5379
Pull out bootstrapLib into separate function
2016-01-05 14:57:53 -06:00
Joe Cheng
9c4d142c2d
Fix progress for Shiny modules
...
Too-specific class check was being used, interfered with the
"duck typed" session-like objects we use for modules.
2016-01-05 09:41:52 -08:00
Joe Cheng
0d26857e31
Merge pull request #1031 from rstudio/template
...
Use templates from htmltools
2015-12-31 11:03:14 -08:00
Joe Cheng
85bea95f6b
Merge pull request #1029 from rstudio/joe/feature/knit_print.reactive
...
Add knit_print.reactive
2015-12-30 14:31:26 -08:00
Joe Cheng
d35d76e1d0
Use flex box layout vendor prefixes
...
This fixes fillRow/fillCol for RStudio on Windows and Linux
2015-12-29 15:59:04 -08:00
Joe Cheng
aaa05b22df
Return stopApp value without visibility info
2015-12-29 15:57:23 -08:00
Joe Cheng
aa296fcb69
Don't show call when user cancels gadget
2015-12-28 13:56:01 -08:00
Joe Cheng
b9c7023489
Refactor server function arg matching
2015-12-28 12:43:06 -08:00
Joe Cheng
efcd286039
Code review feedback
2015-12-28 11:56:13 -08:00
Joe Cheng
98014f9495
Code review feedback
2015-12-28 11:53:52 -08:00
Joe Cheng
4a8da3e1e2
runGadget handles cancel automatically (by default)
2015-12-27 23:46:47 -08:00
Joe Cheng
cfe38c00f3
Proper visibility and error handling from stopApp
2015-12-27 23:35:09 -08:00
Joe Cheng
c02f4691e0
Merge pull request #1054 from rstudio/joe/feature/runGadget
...
Migrate runGadget and viewer functions from shinygadgets
2015-12-23 17:45:12 -08:00
Joe Cheng
e7ce28204b
Remove dependency on newer htmltools
...
The css function is in htmltools 0.2.11, which isn't on CRAN
yet. Due to a perfect storm of release scheduling we need to
get fillPage onto shiny master before we have a chance to
put htmltools on CRAN.
2015-12-23 17:32:46 -08:00
Joe Cheng
25a1493520
Add details to fillRow doc about containers
2015-12-23 17:31:10 -08:00
Joe Cheng
b18722f776
flex:none is more appropriate than flex:initial for weight=NA
2015-12-23 17:31:10 -08:00
Joe Cheng
6c2fea7926
Rename flexRow/flexCol to fillRow/fillCol, other tweaks
...
I decided against the name flexRow/flexCol as the "flex" prefix
is too general for these implementations, which are mostly just
useful for filling the space with the children. Flex box has a
lot more features than that, such as centering, wrapping,
justifying, etc., but I don't currently know how to design an
API that presents the full power of flex box without also
presenting the full complexity of it as well.
This commit also includes some tweaks to the impl of flexfill
to fix the behavior of children with 100% size along the main
axis, and also introduces support for NA flex values, which
sizes the flex item according to its contents.
2015-12-23 17:31:10 -08:00
Joe Cheng
e08fd47b0e
Add fillPage, flexRow, flexCol
2015-12-23 17:31:05 -08:00
Joe Cheng
0fd76e8768
Migrate runGadget and viewer functions from shinygadgets
2015-12-23 15:33:30 -08:00
Joe Cheng
e867dcfdb1
Upgrade Font Awesome to 4.5.0
2015-12-23 11:03:33 -08:00
Joe Cheng
2da9bc07ac
Defer subapp iframe loading until main app has loaded
...
Fixes #1047 defer loading of iframes
2015-12-22 11:14:12 -08:00
Joe Cheng
6d7a562b7a
Fix staticdocs
...
Without this fix, current version of staticdocs won't pull plotOutput
into the index page.
2015-12-21 11:57:01 -08:00
Joe Cheng
ed3b71e396
Remove unnecessary environment() call
2015-12-17 11:58:17 -08:00
Joe Cheng
3450a037a9
Further simplification and more tests for req()
2015-12-17 11:29:54 -08:00
Joe Cheng
f57626d256
req() simplification
2015-12-17 11:16:09 -08:00
Joe Cheng
c1c3fa4d3a
Fix a couple of req edge cases
2015-12-17 11:13:33 -08:00
Joe Cheng
300433f7de
req() now short-circuits on falsy values
2015-12-17 10:53:13 -08:00
Joe Cheng
eee6f4ed81
Add req function for validating required inputs/values
2015-12-16 10:04:05 -08:00
Joe Cheng
3a0ce86f51
Remove unnecessary check (feedback from @wch)
2015-12-15 15:36:43 -08:00
Joe Cheng
3ba8fcb7b8
Merge pull request #1036 from rstudio/joe/bugfix/validation-error-behavior
...
Fix validation error handling
2015-12-14 17:16:04 -08:00
Joe Cheng
739c162281
Fix warnings when renderXXX is called with explicit namespace
...
Calling shiny::renderText(...) instead of renderText(...) would
cause warnings.
2015-12-14 17:11:40 -08:00
Joe Cheng
a2700c900d
Fix validation error handling
...
Validation errors were behaving too much like real errors: they were
being printed with stack traces, and passed to the options(shiny.error)
function. Also, if a reactive() cached a validation error, on future
calls the error would be re-raised (which is correct) without the
custom class names attached (which is not).
2015-12-14 16:31:57 -08:00
Winston Chang
0e894cb043
Use templates from htmltools
2015-12-10 15:11:03 -06:00
Joe Cheng
26a0c3520c
Add knit_print.reactive
...
Allows us to drop reactive expressions right into Rmd docs
with runtime:shiny and have them stay up-to-date.
2015-12-09 16:34:55 -08:00
Yihui Xie
4202991ca5
Fixes #1018 : make sure the selected value is always returned from server-side selectize
2015-12-09 11:52:50 -06:00
Yihui Xie
b2d0505c7c
Check R version at runtime ( #968 )
2015-12-08 20:33:52 -06:00
Yihui Xie
a622f029a0
Fixes #1003 : when the source code can be represented via the native encoding on Windows, rewrite the code to a temporary file with the native encoding and parse it
2015-12-07 16:28:45 -06:00
Joe Cheng
02ea31be08
Fix #1020 : Graphics are cut off
2015-12-01 13:47:26 -08:00
Joe Cheng
b5e49a6619
Fix bugs reported by @daattali
...
- reactive srcrefToLabel call fails if code is pasted in at RStudio console
- Stack trace fails when promise (!?) is in call stack
2015-11-24 11:55:08 -08:00
Joe Cheng
4d3fa2c8ac
Merge pull request #1011 from rstudio/joe/feature/better-errors
...
Better errors
2015-11-20 12:56:24 -08:00
Joe Cheng
8e4f7387d0
Better stack traces for observeEvent and eventReactive
2015-11-16 13:10:53 -08:00
Joe Cheng
feb630b2c5
Catch errors when trying to print stack trace
...
No known errors will occur when printing the stack trace, but since
this is fairly complicated code executing when an error has already
happened, better to be on the defensive.
2015-11-16 13:08:34 -08:00
Joe Cheng
5c3ac75b34
Errors in ui function should get stack traces
2015-11-16 12:46:22 -08:00
Joe Cheng
1018b0d966
Errors in ui.R, server.R, server func, etc. all get stack traces
2015-11-16 10:48:16 -08:00
