Carson
5ddff1bd37
Merge branch 'master' into rc-v1.6.0
2021-01-15 14:46:44 -06:00
Carson Sievert
036f923e05
Run accessiblity plugin JS when DOM is loaded (via defer attribute) a… ( #3256 )
...
* Use bslib's patched version of bootstrap-accessibility plugin (see https://github.com/rstudio/bslib/pull/224 )
* Use new minified file
Co-authored-by: Barret Schloerke <schloerke@gmail.com >
2021-01-15 14:43:00 -06:00
Carson Sievert
130f4764a7
Documentation improvements for v1.6 ( #3255 )
2021-01-14 10:35:00 -06:00
Barret Schloerke
ecb21df941
Use url checker ( #3249 )
...
* Update rituals.yaml
* update docs links
* Fix 404 link
* http://fontawesome.io to https://fontawesome.com
* Update links (GitHub Actions)
* Update NEWS.md
* Only check urls in rc branches
* missing paren
Co-authored-by: schloerke <schloerke@users.noreply.github.com >
2021-01-13 14:18:12 -06:00
Carson Sievert
5b27d9258e
Don't change the return value of bootstrapPage() if bslib isn't relevant ( #3236 )
...
* Close #3235 : Don't change the return value of bootstrapPage() if bslib isn't relevant
Also, improved error message if theme is a character vector with 2 or more elements
* yarn build (GitHub Actions)
* bump version
* yarn build (GitHub Actions)
* Don't add an additional level to the returned tree structure
* More straightforward use of do.call()
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
Co-authored-by: Winston Chang <winston@stdout.org >
2021-01-05 13:21:38 -06:00
Nick Strayer
a9f7068b2f
bindCache() docs typos ( #3232 )
...
* vert -> very
* cachem::cache_mem() uses max_size argument to set size.
* Rebuilt docs after cache typo fixes
* Rerender docs with new roxygen version
* Installed cairo and rebuilt docs
2020-12-23 17:14:57 -06:00
Carson Sievert
1f9e4929a6
Follow up to #3228 . shinyAppDir() now throws a classed condition when appDir is not a directory ( #3229 )
2020-12-23 10:20:48 -06:00
Carson Sievert
d56afca33e
shinyAppDir() now throws an exception with a special class if no app.R/server.R file is found. ( #3228 )
...
shinytest:::is_app() can make use of this for better error reporting
2020-12-22 10:41:55 -06:00
Winston Chang
68cf1c5410
Check for empty list
2020-12-21 10:40:24 -06:00
Winston Chang
99207d1d8f
Simplify handling of empty options
2020-12-19 23:02:20 -06:00
Barret Schloerke
f4fc13fc2f
Add devmode() features ( #3174 )
...
Co-authored-by: Barret Schloerke <schloerke@gmail.com >
Co-authored-by: Winston Chang <winston@stdout.org >
2020-12-18 14:31:31 -05:00
Nick Strayer
95081c43a7
Make sure setCurrentTheme() doesn't try and change bootstrap versions ( #3210 )
...
* Added check to make sure setCurrentTheme() doesn't try and change bootstrap version
* Update R/shiny.R
Style improvements via Carson
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
* Update error message to be more specific
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
* Make it clearer where the new bs_theme() call should be made.
* Add a check to make sure setCurrentTheme() receive a bs_theme() object
Co-authored-by: Nick Strayer <nick.strayer@gmail.com >
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
2020-12-18 13:28:16 -06:00
Barret Schloerke
5e1afc61c1
Update private$currentThemeDependency label to be Theme Counter ( #3206 )
...
* Update `private$currentThemeDependency` label to be `Theme Iteration`
* Update R/shiny.R
Co-authored-by: Winston Chang <winston@stdout.org >
2020-12-16 15:31:50 -06:00
Malcolm Barrett
dca3722cb8
fix typo in docs ( #3204 )
...
Co-authored-by: runner <runner@Mac-1607960235106.local >
2020-12-16 13:37:16 -06:00
Stéphane Guillou
7eb0e93731
typos in documentation ( #3205 )
...
Co-authored-by: runner <runner@Mac-1607961254343.local >
2020-12-16 13:36:32 -06:00
Winston Chang
f5666bcba1
Respect shiny.minified for bootstrap-datepicker.js
2020-12-11 10:02:01 -06:00
Winston Chang
61aa7bb3b0
validate_session_object: Also work with modules
2020-12-10 12:25:30 -06:00
Winston Chang
196b220faf
All session parameters from the update* functions now default to getDefaultReactiveDomain() ( #3195 )
...
Co-authored-by: colin <colin@thinkr.fr >
2020-12-08 12:18:37 -06:00
Hadley Wickham
f41c484913
Respect reactiveConsole() in new errors ( #3193 )
2020-12-08 12:17:43 -06:00
Winston Chang
bbf9bee28e
Add a warning message when value < min | value > max in sliderInput ( #3194 )
...
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
Co-authored-by: colin <colin@thinkr.fr >
Co-authored-by: Colin Fay <contact@colinfay.me >
2020-12-08 10:55:18 -06:00
Carson Sievert
c5adef0a05
Add 'auto' brush fill and stroke ( #2864 )
...
* Add 'auto' brush fill and stroke
* getStyle() from utils
* Update getThematicOption()
* Use getThematicOption() helper in startPNG(), too
2020-12-04 16:49:08 -06:00
Carson Sievert
508c197446
getCurrentOutputInfo() bugfix ( #3189 )
2020-12-04 16:38:48 -06:00
Carson Sievert
473ec834fe
radioButtons() and checkboxGroup() accessibility ( #3187 )
...
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
Co-authored-by: JooYoung Seo <sjysky@gmail.com >
2020-12-04 15:53:53 -06:00
Carson Sievert
66968904bf
Cleaner logic for conditional CSS styles ( #2671 )
...
* Cleaner logic for conditional CSS styles
It's really only plotOutput() that behaves differently;
previously it was not possible to specify a NULL width
or height and not get broken styles
* require dev version of htmltools
Co-authored-by: Joe Cheng <joe@rstudio.com >
2020-12-04 15:52:50 -06:00
Hadley Wickham
f169792e59
Experiment with error message ( #3007 )
2020-12-04 14:20:30 -06:00
Winston Chang
72d81e8a85
Add label to private$currentThemeDependency
2020-12-04 12:32:55 -06:00
Carson Sievert
5c5974106d
Properly attach jqueryui dependency when drag_drop plugin is used ( #3185 )
...
* Properly attach jqueryui dependency when drag_drop plugin is used, closes #3183
* write a unit test
2020-12-04 10:52:26 -06:00
Winston Chang
c2cbd3a127
Create session$currentThemeDependency only when needed ( #3182 )
...
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
2020-12-04 09:47:18 -06:00
Winston Chang
8e5aedec00
Do correct assignment of resizeObserverCreated ( #3177 )
2020-12-04 08:58:52 -06:00
Winston Chang
13965acb37
getCurrentOutputInfo(): only create reactives when needed ( #3180 )
2020-12-03 17:16:33 -06:00
Winston Chang
8a99b9d401
Add label to reactive
...
Co-authored-by: Barret Schloerke <barret@rstudio.com >
2020-12-03 17:09:30 -06:00
Carson Sievert
f739a1d476
Set resolve = FALSE when getting thematic's bg option ( #3178 )
2020-12-03 17:02:12 -06:00
Winston Chang
87dd00be13
getCurrentOutputInfo(): only create reactives when needed
2020-12-03 16:15:04 -06:00
Winston Chang
b7366ef672
Remove outdated comments
2020-12-02 20:56:33 -06:00
Winston Chang
3d6329dee8
Add cacheWriteHook and cacheReadHook ( #3173 )
2020-12-02 16:17:08 -06:00
Winston Chang
2171420e0c
Fix NA check
2020-12-02 16:03:07 -06:00
Winston Chang
e44a9b1ded
Replace %OR% with %||% from rlang ( #3172 )
2020-12-02 12:14:07 -06:00
Carson Sievert
8eed42387c
Make sure dateInput() warns on empty string ( #3165 )
...
Co-authored-by: Winston Chang <winston@stdout.org >
2020-11-24 10:34:39 -06:00
Winston Chang
5b3366f35a
Replace renderCachedPlot() code with bindCache() ( #3163 )
2020-11-23 14:34:52 -06:00
Winston Chang
1bad0553b7
Fix labels for eventReactive
2020-11-20 15:46:18 -06:00
Winston Chang
ac0b723bb0
bindEvent(): alter observers in place and fix labels
2020-11-20 14:51:35 -06:00
Winston Chang
39454a6c09
Use enquos0, inject, and zap_srcref from rlang ( #3157 )
2020-11-20 11:07:06 -06:00
Winston Chang
569157aded
Add reactive session$getCurrentTheme() ( #3116 )
...
Co-authored-by: Carson <cpsievert1@gmail.com >
2020-11-20 10:54:51 -06:00
Carson Sievert
5da846f1ce
Always ship selectize HTML dependencies with name='selectize', closes #3125 ( #3155 )
2020-11-20 09:46:08 -06:00
Winston Chang
b3369616d2
bindCache: accept cache arg when used with renderPlot
2020-11-19 15:14:10 -06:00
Winston Chang
082b8ef080
bindCache: add documentation about renderPlot
2020-11-19 15:13:39 -06:00
Hadley Wickham
0fb9226a9b
Minor bindCache doc tweaks ( #3156 )
2020-11-19 15:04:26 -06:00
Winston Chang
bb55f45d94
More bindCache documentation edits
2020-11-18 13:21:03 -06:00
Winston Chang
5b12980b7a
Update bindEvent documentation
2020-11-18 12:39:20 -06:00
Winston Chang
493ef59dda
Update bindCache documentation
2020-11-18 12:37:06 -06:00