From 0b67500fb48bf3cf9e01b98873ef25eb22fe7b30 Mon Sep 17 00:00:00 2001 From: Vikhyath Mondreti Date: Tue, 20 Jan 2026 15:26:16 -0800 Subject: [PATCH] fix types --- apps/sim/app/api/files/parse/route.ts | 1 - apps/sim/app/chat/hooks/use-chat-streaming.ts | 8 ++++---- apps/sim/executor/utils/start-block.ts | 4 ++-- .../uploads/contexts/execution/execution-file-manager.ts | 4 ++-- apps/sim/lib/uploads/utils/user-file-base64.server.ts | 9 +++++---- 5 files changed, 13 insertions(+), 13 deletions(-) diff --git a/apps/sim/app/api/files/parse/route.ts b/apps/sim/app/api/files/parse/route.ts index f3bdd3c64..c2c49ef98 100644 --- a/apps/sim/app/api/files/parse/route.ts +++ b/apps/sim/app/api/files/parse/route.ts @@ -372,7 +372,6 @@ async function handleExternalUrl( logger.info(`Downloaded file from URL: ${url}, size: ${buffer.length} bytes`) - // Store file in execution storage if execution context is provided let userFile: UserFile | undefined const mimeType = response.headers.get('content-type') || getMimeTypeFromExtension(extension) diff --git a/apps/sim/app/chat/hooks/use-chat-streaming.ts b/apps/sim/app/chat/hooks/use-chat-streaming.ts index 2f19d073a..e02087093 100644 --- a/apps/sim/app/chat/hooks/use-chat-streaming.ts +++ b/apps/sim/app/chat/hooks/use-chat-streaming.ts @@ -2,7 +2,7 @@ import { useRef, useState } from 'react' import { createLogger } from '@sim/logger' -import { isUserFile } from '@/lib/core/utils/user-file' +import { isUserFileWithMetadata } from '@/lib/core/utils/user-file' import type { ChatFile, ChatMessage } from '@/app/chat/components/message/message' import { CHAT_ERROR_MESSAGES } from '@/app/chat/constants' @@ -17,7 +17,7 @@ function extractFilesFromData( return files } - if (isUserFile(data)) { + if (isUserFileWithMetadata(data)) { if (!seenIds.has(data.id)) { seenIds.add(data.id) files.push({ @@ -232,7 +232,7 @@ export function useChatStreaming() { return null } - if (isUserFile(value)) { + if (isUserFileWithMetadata(value)) { return null } @@ -285,7 +285,7 @@ export function useChatStreaming() { const value = getOutputValue(blockOutputs, config.path) - if (isUserFile(value)) { + if (isUserFileWithMetadata(value)) { extractedFiles.push({ id: value.id, name: value.name, diff --git a/apps/sim/executor/utils/start-block.ts b/apps/sim/executor/utils/start-block.ts index bfe21b689..31a8cc94b 100644 --- a/apps/sim/executor/utils/start-block.ts +++ b/apps/sim/executor/utils/start-block.ts @@ -1,4 +1,4 @@ -import { isUserFile } from '@/lib/core/utils/user-file' +import { isUserFileWithMetadata } from '@/lib/core/utils/user-file' import { classifyStartBlockType, getLegacyStarterMode, @@ -234,7 +234,7 @@ function getFilesFromWorkflowInput(workflowInput: unknown): UserFile[] | undefin return undefined } const files = workflowInput.files - if (Array.isArray(files) && files.every(isUserFile)) { + if (Array.isArray(files) && files.every(isUserFileWithMetadata)) { return files } return undefined diff --git a/apps/sim/lib/uploads/contexts/execution/execution-file-manager.ts b/apps/sim/lib/uploads/contexts/execution/execution-file-manager.ts index df3d380d3..bbf2a123e 100644 --- a/apps/sim/lib/uploads/contexts/execution/execution-file-manager.ts +++ b/apps/sim/lib/uploads/contexts/execution/execution-file-manager.ts @@ -1,5 +1,5 @@ import { createLogger } from '@sim/logger' -import { isUserFile } from '@/lib/core/utils/user-file' +import { isUserFileWithMetadata } from '@/lib/core/utils/user-file' import type { ExecutionContext } from '@/lib/uploads/contexts/execution/utils' import { generateExecutionFileKey, generateFileId } from '@/lib/uploads/contexts/execution/utils' import type { UserFile } from '@/executor/types' @@ -169,7 +169,7 @@ export async function uploadFileFromRawData( context: ExecutionContext, userId?: string ): Promise { - if (isUserFile(rawData)) { + if (isUserFileWithMetadata(rawData)) { return rawData } diff --git a/apps/sim/lib/uploads/utils/user-file-base64.server.ts b/apps/sim/lib/uploads/utils/user-file-base64.server.ts index 52b67bf8c..33f7e6259 100644 --- a/apps/sim/lib/uploads/utils/user-file-base64.server.ts +++ b/apps/sim/lib/uploads/utils/user-file-base64.server.ts @@ -23,7 +23,7 @@ interface HydrationState { } export interface Base64HydrationOptions { - requestId: string + requestId?: string executionId?: string logger?: Logger maxBytes?: number @@ -148,13 +148,14 @@ async function resolveBase64( } let buffer: Buffer | null = null + const requestId = options.requestId ?? 'unknown' if (file.key) { try { - buffer = await downloadFileFromStorage(file, options.requestId, logger) + buffer = await downloadFileFromStorage(file, requestId, logger) } catch (error) { logger.warn( - `[${options.requestId}] Failed to download ${file.name} from storage, trying URL fallback`, + `[${requestId}] Failed to download ${file.name} from storage, trying URL fallback`, error ) } @@ -164,7 +165,7 @@ async function resolveBase64( try { buffer = await downloadFileFromUrl(file.url, timeoutMs) } catch (error) { - logger.warn(`[${options.requestId}] Failed to download ${file.name} from URL`, error) + logger.warn(`[${requestId}] Failed to download ${file.name} from URL`, error) } }