From 606f0f3b8c3b74ddcabe1128b6bb5ab01f3aefdb Mon Sep 17 00:00:00 2001 From: Vikhyath Mondreti Date: Mon, 9 Feb 2026 17:25:55 -0800 Subject: [PATCH] address bugbot comments --- .../hooks/use-block-output-fields.ts | 30 +------------------ .../client/workflow/block-output-utils.ts | 16 +--------- 2 files changed, 2 insertions(+), 44 deletions(-) diff --git a/apps/sim/app/workspace/[workspaceId]/w/[workflowId]/hooks/use-block-output-fields.ts b/apps/sim/app/workspace/[workspaceId]/w/[workflowId]/hooks/use-block-output-fields.ts index e6cc8720a..3be40158a 100644 --- a/apps/sim/app/workspace/[workspaceId]/w/[workflowId]/hooks/use-block-output-fields.ts +++ b/apps/sim/app/workspace/[workspaceId]/w/[workflowId]/hooks/use-block-output-fields.ts @@ -1,10 +1,7 @@ 'use client' import { useMemo } from 'react' -import { - getEffectiveBlockOutputs, - getEvaluatorMetricOutputs, -} from '@/lib/workflows/blocks/block-outputs' +import { getEffectiveBlockOutputs } from '@/lib/workflows/blocks/block-outputs' import type { SchemaField } from '@/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/connection-blocks/components/field-item/field-item' import { getBlock } from '@/blocks' import { useSubBlockStore } from '@/stores/workflows/subblock/store' @@ -123,31 +120,6 @@ export function useBlockOutputFields({ return [] } - // Handle evaluator blocks - use metrics if available - if (blockType === 'evaluator') { - const metricOutputs = getEvaluatorMetricOutputs(mergedSubBlocks) - if (metricOutputs) { - return Object.entries(metricOutputs).map(([name, output]) => ({ - name, - type: - output && - typeof output === 'object' && - 'type' in output && - typeof output.type === 'string' - ? output.type - : 'number', - description: - output && - typeof output === 'object' && - 'description' in output && - typeof output.description === 'string' - ? output.description - : undefined, - })) - } - // Fall through to use blockConfig.outputs - } - // Handle variables blocks - use variable assignments if available if (blockType === 'variables') { const variablesValue = diff --git a/apps/sim/lib/copilot/tools/client/workflow/block-output-utils.ts b/apps/sim/lib/copilot/tools/client/workflow/block-output-utils.ts index 81d94b5f7..dc678b60e 100644 --- a/apps/sim/lib/copilot/tools/client/workflow/block-output-utils.ts +++ b/apps/sim/lib/copilot/tools/client/workflow/block-output-utils.ts @@ -1,7 +1,4 @@ -import { - getEffectiveBlockOutputPaths, - getEvaluatorMetricOutputs, -} from '@/lib/workflows/blocks/block-outputs' +import { getEffectiveBlockOutputPaths } from '@/lib/workflows/blocks/block-outputs' import { normalizeName } from '@/executor/constants' import { useVariablesStore } from '@/stores/panel/variables/store' import type { Variable } from '@/stores/panel/variables/types' @@ -97,17 +94,6 @@ export function computeBlockOutputPaths(block: BlockState, ctx: WorkflowContext) return ['results', ...insidePaths] } - if (block.type === 'evaluator') { - const metricOutputs = getEvaluatorMetricOutputs(mergedSubBlocks) - if (metricOutputs) { - return Object.keys(metricOutputs) - } - return getEffectiveBlockOutputPaths(block.type, mergedSubBlocks, { - triggerMode: Boolean(block.triggerMode), - preferToolOutputs: !block.triggerMode, - }) - } - if (block.type === 'variables') { const variablesValue = getSubBlockValue(blocks, subBlockValues, block.id, 'variables') if (variablesValue && Array.isArray(variablesValue) && variablesValue.length > 0) {