From 67c993d743e0b2d0168077a270cd30f7f2df0270 Mon Sep 17 00:00:00 2001 From: Waleed Date: Sat, 27 Sep 2025 22:37:28 -0700 Subject: [PATCH] fix(ci): remove atomic updates for trigger (#1478) --- .github/workflows/ci.yml | 12 ++------ .github/workflows/trigger-deploy.yml | 4 +-- .github/workflows/trigger-promote.yml | 42 --------------------------- 3 files changed, 4 insertions(+), 54 deletions(-) delete mode 100644 .github/workflows/trigger-promote.yml diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 736927dfd..b1c9e8b75 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -28,7 +28,7 @@ jobs: packages: write id-token: write - # Deploy Trigger.dev with skip-promotion (after builds complete to ensure atomicity) + # Deploy Trigger.dev (after builds complete) trigger-deploy: name: Deploy Trigger.dev needs: build-images @@ -49,18 +49,10 @@ jobs: uses: ./.github/workflows/migrations.yml secrets: inherit - # Promote Trigger.dev deployment after ECS completes - trigger-promote: - name: Promote Trigger.dev - needs: migrations - if: github.event_name == 'push' && (github.ref == 'refs/heads/main' || github.ref == 'refs/heads/staging') - uses: ./.github/workflows/trigger-promote.yml - secrets: inherit - # Process docs embeddings if needed process-docs: name: Process Docs - needs: trigger-promote + needs: migrations if: github.event_name == 'push' && (github.ref == 'refs/heads/main' || github.ref == 'refs/heads/staging') uses: ./.github/workflows/docs-embeddings.yml secrets: inherit diff --git a/.github/workflows/trigger-deploy.yml b/.github/workflows/trigger-deploy.yml index 7a7b7f281..e8a47275d 100644 --- a/.github/workflows/trigger-deploy.yml +++ b/.github/workflows/trigger-deploy.yml @@ -34,9 +34,9 @@ jobs: - name: Deploy to Trigger.dev (Staging) if: github.ref == 'refs/heads/staging' working-directory: ./apps/sim - run: npx --yes trigger.dev@4.0.4 deploy -e staging --skip-promotion + run: npx --yes trigger.dev@4.0.4 deploy -e staging - name: Deploy to Trigger.dev (Production) if: github.ref == 'refs/heads/main' working-directory: ./apps/sim - run: npx --yes trigger.dev@4.0.4 deploy --skip-promotion \ No newline at end of file + run: npx --yes trigger.dev@4.0.4 deploy \ No newline at end of file diff --git a/.github/workflows/trigger-promote.yml b/.github/workflows/trigger-promote.yml deleted file mode 100644 index 033a4cf48..000000000 --- a/.github/workflows/trigger-promote.yml +++ /dev/null @@ -1,42 +0,0 @@ -name: Trigger.dev Promote - -on: - workflow_call: - workflow_dispatch: - -jobs: - promote: - name: Promote Trigger.dev - runs-on: blacksmith-4vcpu-ubuntu-2404 - concurrency: - group: trigger-promote-${{ github.ref }} - cancel-in-progress: false - env: - TRIGGER_ACCESS_TOKEN: ${{ secrets.TRIGGER_ACCESS_TOKEN }} - - steps: - - name: Checkout code - uses: actions/checkout@v4 - - - name: Setup Node - uses: actions/setup-node@v4 - with: - node-version: latest - - - name: Setup Bun - uses: oven-sh/setup-bun@v2 - with: - bun-version: latest - - - name: Install dependencies - run: bun install - - - name: Promote Trigger.dev (Staging) - if: github.ref == 'refs/heads/staging' - working-directory: ./apps/sim - run: npx --yes trigger.dev@4.0.4 deploy promote --latest -e staging - - - name: Promote Trigger.dev (Production) - if: github.ref == 'refs/heads/main' - working-directory: ./apps/sim - run: npx --yes trigger.dev@4.0.4 deploy promote --latest \ No newline at end of file