fix(undo-redo): preserve trigger/advanced mode (#1566)

* fix(undo-redo): preserve trigger/advanced mode

* remove comments
This commit is contained in:
Vikhyath Mondreti
2025-10-07 14:27:46 -07:00
committed by GitHub
parent 991a020917
commit a63a7b0262
2 changed files with 49 additions and 6 deletions

View File

@@ -429,7 +429,15 @@ export function useUndoRedo() {
blockSnapshot.position,
blockSnapshot.data,
blockSnapshot.data?.parentId,
blockSnapshot.data?.extent
blockSnapshot.data?.extent,
{
enabled: blockSnapshot.enabled,
horizontalHandles: blockSnapshot.horizontalHandles,
isWide: blockSnapshot.isWide,
advancedMode: blockSnapshot.advancedMode,
triggerMode: blockSnapshot.triggerMode,
height: blockSnapshot.height,
}
)
// Set subblock values for the main block locally
@@ -471,7 +479,15 @@ export function useUndoRedo() {
snap.position,
snap.data,
snap.data?.parentId,
snap.data?.extent
snap.data?.extent,
{
enabled: snap.enabled,
horizontalHandles: snap.horizontalHandles,
isWide: snap.isWide,
advancedMode: snap.advancedMode,
triggerMode: snap.triggerMode,
height: snap.height,
}
)
// Send to server with subBlocks included in payload
@@ -801,7 +817,15 @@ export function useUndoRedo() {
snap.position,
snap.data,
snap.data?.parentId,
snap.data?.extent
snap.data?.extent,
{
enabled: snap.enabled,
horizontalHandles: snap.horizontalHandles,
isWide: snap.isWide,
advancedMode: snap.advancedMode,
triggerMode: snap.triggerMode,
height: snap.height,
}
)
// Set subblock values for the main block locally
@@ -841,7 +865,15 @@ export function useUndoRedo() {
snapNested.position,
snapNested.data,
snapNested.data?.parentId,
snapNested.data?.extent
snapNested.data?.extent,
{
enabled: snapNested.enabled,
horizontalHandles: snapNested.horizontalHandles,
isWide: snapNested.isWide,
advancedMode: snapNested.advancedMode,
triggerMode: snapNested.triggerMode,
height: snapNested.height,
}
)
// Send to server with subBlocks included
@@ -1058,7 +1090,15 @@ export function useUndoRedo() {
duplicatedBlockSnapshot.position,
duplicatedBlockSnapshot.data,
duplicatedBlockSnapshot.data?.parentId,
duplicatedBlockSnapshot.data?.extent
duplicatedBlockSnapshot.data?.extent,
{
enabled: duplicatedBlockSnapshot.enabled,
horizontalHandles: duplicatedBlockSnapshot.horizontalHandles,
isWide: duplicatedBlockSnapshot.isWide,
advancedMode: duplicatedBlockSnapshot.advancedMode,
triggerMode: duplicatedBlockSnapshot.triggerMode,
height: duplicatedBlockSnapshot.height,
}
)
// Restore subblock values

View File

@@ -214,6 +214,9 @@ export class Serializer {
if (block.triggerMode === true || isTriggerCategory) {
params.triggerMode = true
}
if (block.advancedMode === true) {
params.advancedMode = true
}
} catch (_) {
// no-op: conservative, avoid blocking serialization if blockConfig is unexpected
}
@@ -672,10 +675,10 @@ export class Serializer {
subBlocks,
outputs: serializedBlock.outputs,
enabled: true,
// Restore trigger mode from serialized params; treat trigger category as triggers as well
triggerMode:
serializedBlock.config?.params?.triggerMode === true ||
serializedBlock.metadata?.category === 'triggers',
advancedMode: serializedBlock.config?.params?.advancedMode === true,
}
}
}