github/sim
1
0
Fork 0
mirror of https://github.com/simstudioai/sim.git synced 2026-02-17 01:42:43 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix(triggers): disabled trigger shouldn't be added to dag (#2012)

Browse Source 
* Fix disabled blocks

* Comments

* Fix api/chat trigger not found message
This commit is contained in:
Siddharth Ganesan
2025-11-15 12:19:37 -08:00
committed by GitHub
parent dccd9e9ce5
commit c25ea5c677
4 changed files with 37 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
apps/sim/executor/dag/construction/paths.ts
View File

@@ -28,6 +28,24 @@ export class PathConstructor {
const block = workflow.blocks.find((b) => b.id === triggerBlockId)
if (block) {
if (!block.enabled) {
logger.error('Provided triggerBlockId is disabled, finding alternative', {
triggerBlockId,
blockEnabled: block.enabled,
})
// Try to find an alternative enabled trigger instead of failing
const alternativeTrigger = this.findExplicitTrigger(workflow)
if (alternativeTrigger) {
logger.info('Using alternative enabled trigger', {
disabledTriggerId: triggerBlockId,
alternativeTriggerId: alternativeTrigger,
})
return alternativeTrigger
}
throw new Error(
`Trigger block ${triggerBlockId} is disabled and no alternative enabled trigger found`
)
}
return triggerBlockId
}
@@ -95,8 +113,13 @@ export class PathConstructor {
private buildAdjacencyMap(workflow: SerializedWorkflow): Map<string, string[]> {
const adjacency = new Map<string, string[]>()
const enabledBlocks = new Set(workflow.blocks.filter((b) => b.enabled).map((b) => b.id))
for (const connection of workflow.connections) {
if (!enabledBlocks.has(connection.source) || !enabledBlocks.has(connection.target)) {
continue
}
const neighbors = adjacency.get(connection.source) ?? []
neighbors.push(connection.target)
adjacency.set(connection.source, neighbors)