From cdb646e16a805c8cd6181b3e76cf285a9c6c9b8c Mon Sep 17 00:00:00 2001
From: Emir Karabeg <emirkarabeg@berkeley.edu>
Date: Fri, 31 Jan 2025 14:55:00 -0800
Subject: [PATCH] Removed terminal if error shown in entry

---
 .../console-entry/console-entry.tsx           | 12 +++--
 app/w/components/console/console.tsx          | 48 ++++++++++---------
 2 files changed, 33 insertions(+), 27 deletions(-)

diff --git a/app/w/components/console/components/console-entry/console-entry.tsx b/app/w/components/console/components/console-entry/console-entry.tsx
index d6112747e..c9b8ec962 100644
--- a/app/w/components/console/components/console-entry/console-entry.tsx
+++ b/app/w/components/console/components/console-entry/console-entry.tsx
@@ -78,12 +78,14 @@ export function ConsoleEntry({ entry, consoleWidth }: ConsoleEntryProps) {
         </div>
 
         <div className="space-y-4">
-          <div className="flex items-start gap-2">
-            <Terminal className="h-4 w-4 text-muted-foreground mt-1" />
-            <div className="text-sm font-mono flex-1">
-              <JSONView data={entry.output} />
+          {!entry.error && (
+            <div className="flex items-start gap-2">
+              <Terminal className="h-4 w-4 text-muted-foreground mt-1" />
+              <div className="text-sm font-mono flex-1">
+                <JSONView data={entry.output} />
+              </div>
             </div>
-          </div>
+          )}
 
           {entry.error && (
             <div className="flex items-start gap-2 border rounded-md p-3 border-red-500 bg-red-50 text-destructive dark:border-border dark:text-foreground dark:bg-background">
diff --git a/app/w/components/console/console.tsx b/app/w/components/console/console.tsx
index 50b070d22..8565918cb 100644
--- a/app/w/components/console/console.tsx
+++ b/app/w/components/console/console.tsx
@@ -80,7 +80,7 @@ export function Console() {
         onMouseDown={handleMouseDown}
       />
 
-      <div className="flex items-center justify-between p-4 border-b">
+      <div className="flex items-center justify-between h-14 px-4 border-b">
         <h2 className="text-sm font-medium">Console</h2>
         <Button
           variant="ghost"
@@ -93,29 +93,33 @@ export function Console() {
       </div>
 
       <ScrollArea className="h-[calc(100%-4rem)]">
-        {filteredEntries.length === 0 ? (
-          <div className="flex items-center justify-center h-full text-sm text-muted-foreground pt-4">
-            No console entries
-          </div>
-        ) : (
-          filteredEntries.map((entry) => (
-            <ConsoleEntry key={entry.id} entry={entry} consoleWidth={width} />
-          ))
-        )}
+        <div className="pb-16">
+          {filteredEntries.length === 0 ? (
+            <div className="flex items-center justify-center h-full text-sm text-muted-foreground pt-4">
+              No console entries
+            </div>
+          ) : (
+            filteredEntries.map((entry) => (
+              <ConsoleEntry key={entry.id} entry={entry} consoleWidth={width} />
+            ))
+          )}
+        </div>
       </ScrollArea>
 
-      <Tooltip>
-        <TooltipTrigger asChild>
-          <button
-            onClick={() => setIsCollapsed(true)}
-            className="absolute left-4 bottom-[18px] flex h-9 w-9 items-center justify-center rounded-lg text-muted-foreground transition-colors hover:text-foreground hover:bg-accent"
-          >
-            <PanelLeftClose className="h-5 w-5" />
-            <span className="sr-only">Close Console</span>
-          </button>
-        </TooltipTrigger>
-        <TooltipContent side="right">Close Console</TooltipContent>
-      </Tooltip>
+      <div className="absolute left-0 right-0 bottom-0 h-16 bg-background border-t">
+        <Tooltip>
+          <TooltipTrigger asChild>
+            <button
+              onClick={() => setIsCollapsed(true)}
+              className="absolute left-4 bottom-[18px] flex h-9 w-9 items-center justify-center rounded-lg text-muted-foreground transition-colors hover:text-foreground hover:bg-accent"
+            >
+              <PanelLeftClose className="h-5 w-5" />
+              <span className="sr-only">Close Console</span>
+            </button>
+          </TooltipTrigger>
+          <TooltipContent side="right">Close Console</TooltipContent>
+        </Tooltip>
+      </div>
     </div>
   )
 }