github/sim
1
0
Fork 0
mirror of https://github.com/simstudioai/sim.git synced 2026-02-06 12:45:07 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix(skills): consolidate redundant permission checks in POST and DELETE

Browse Source
This commit is contained in:
waleed
2026-02-05 22:58:05 -08:00
parent 6fea21c9aa
commit dfddb60cc5
1 changed files with 2 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
apps/sim/app/api/skills/route.ts
View File

@@ -89,14 +89,7 @@ export async function POST(req: NextRequest) {
}
const userPermission = await getUserEntityPermissions(userId, 'workspace', workspaceId)
if (!userPermission) {
logger.warn(
`[${requestId}] User ${userId} does not have access to workspace ${workspaceId}`
)
return NextResponse.json({ error: 'Access denied' }, { status: 403 })
}
if (userPermission !== 'admin' && userPermission !== 'write') {
if (!userPermission || (userPermission !== 'admin' && userPermission !== 'write')) {
logger.warn(
`[${requestId}] User ${userId} does not have write permission for workspace ${workspaceId}`
)
@@ -159,12 +152,7 @@ export async function DELETE(request: NextRequest) {
}
const userPermission = await getUserEntityPermissions(userId, 'workspace', workspaceId)
if (!userPermission) {
logger.warn(`[${requestId}] User ${userId} does not have access to workspace ${workspaceId}`)
return NextResponse.json({ error: 'Access denied' }, { status: 403 })
}
if (userPermission !== 'admin' && userPermission !== 'write') {
if (!userPermission || (userPermission !== 'admin' && userPermission !== 'write')) {
logger.warn(
`[${requestId}] User ${userId} does not have write permission for workspace ${workspaceId}`
)