mirror of
https://github.com/simstudioai/sim.git
synced 2026-04-06 03:00:16 -04:00
* feat(audit-log): add persistent audit log system with comprehensive route instrumentation
* fix(audit-log): address PR review — nullable workspaceId, enum usage, remove redundant queries
- Make audit_log.workspace_id nullable with ON DELETE SET NULL (logs survive workspace/user deletion)
- Make audit_log.actor_id nullable with ON DELETE SET NULL
- Replace all 53 routes' string literal action/resourceType with AuditAction.X and AuditResourceType.X enums
- Fix empty workspaceId ('') → null for OAuth, form, and org routes to avoid FK violations
- Remove redundant DB queries in chat manage route (use checkChatAccess return data)
- Fix organization routes to pass workspaceId: null instead of organizationId
* fix(audit-log): replace remaining workspaceId '' fallbacks with null
* fix(audit-log): credential-set org IDs, workspace deletion FK, actorId fallback, string literal action
* reran migrations
* fix(mcp,audit): tighten env var domain bypass, add post-resolution check, form workspaceId
- Only bypass MCP domain check when env var is in hostname/authority, not path/query
- Add post-resolution validateMcpDomain call in test-connection endpoint
- Match client-side isDomainAllowed to same hostname-only bypass logic
- Return workspaceId from checkFormAccess, use in form audit logs
- Add 49 comprehensive domain-check tests covering all edge cases
* fix(mcp): stateful regex lastIndex bug, RFC 3986 authority parsing
- Remove /g flag from module-level ENV_VAR_PATTERN to avoid lastIndex state
- Create fresh regex instances per call in server-side hasEnvVarInHostname
- Fix authority extraction to terminate at /, ?, or # per RFC 3986
- Prevents bypass via https://evil.com?token={{SECRET}} (no path)
- Add test cases for query-only and fragment-only env var URLs (53 total)
* fix(audit-log): try/catch for never-throw contract, accept null actorName/Email, fix misleading action
- Wrap recordAudit body in try/catch so nanoid() or header extraction can't throw
- Accept string | null for actorName and actorEmail (session.user.name can be null)
- Normalize null -> undefined before insert to match DB column types
- Fix org members route: ORG_MEMBER_ADDED -> ORG_INVITATION_CREATED (sends invite, not adds member)
* improvement(audit-log): add resource names and specific invitation actions
* fix(audit-log): use validated chat record, add mock sync tests
179 lines
4.9 KiB
TypeScript
179 lines
4.9 KiB
TypeScript
/**
|
|
* Tests for OAuth disconnect API route
|
|
*
|
|
* @vitest-environment node
|
|
*/
|
|
import { auditMock, createMockLogger, createMockRequest } from '@sim/testing'
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
|
|
|
|
describe('OAuth Disconnect API Route', () => {
|
|
const mockGetSession = vi.fn()
|
|
const mockSelectChain = {
|
|
from: vi.fn().mockReturnThis(),
|
|
innerJoin: vi.fn().mockReturnThis(),
|
|
where: vi.fn().mockResolvedValue([]),
|
|
}
|
|
const mockDb = {
|
|
delete: vi.fn().mockReturnThis(),
|
|
where: vi.fn(),
|
|
select: vi.fn().mockReturnValue(mockSelectChain),
|
|
}
|
|
const mockLogger = createMockLogger()
|
|
const mockSyncAllWebhooksForCredentialSet = vi.fn().mockResolvedValue({})
|
|
|
|
const mockUUID = 'mock-uuid-12345678-90ab-cdef-1234-567890abcdef'
|
|
|
|
beforeEach(() => {
|
|
vi.resetModules()
|
|
|
|
vi.stubGlobal('crypto', {
|
|
randomUUID: vi.fn().mockReturnValue(mockUUID),
|
|
})
|
|
|
|
vi.doMock('@/lib/auth', () => ({
|
|
getSession: mockGetSession,
|
|
}))
|
|
|
|
vi.doMock('@sim/db', () => ({
|
|
db: mockDb,
|
|
}))
|
|
|
|
vi.doMock('@sim/db/schema', () => ({
|
|
account: { userId: 'userId', providerId: 'providerId' },
|
|
credentialSetMember: {
|
|
id: 'id',
|
|
credentialSetId: 'credentialSetId',
|
|
userId: 'userId',
|
|
status: 'status',
|
|
},
|
|
credentialSet: { id: 'id', providerId: 'providerId' },
|
|
}))
|
|
|
|
vi.doMock('drizzle-orm', () => ({
|
|
and: vi.fn((...conditions) => ({ conditions, type: 'and' })),
|
|
eq: vi.fn((field, value) => ({ field, value, type: 'eq' })),
|
|
like: vi.fn((field, value) => ({ field, value, type: 'like' })),
|
|
or: vi.fn((...conditions) => ({ conditions, type: 'or' })),
|
|
}))
|
|
|
|
vi.doMock('@sim/logger', () => ({
|
|
createLogger: vi.fn().mockReturnValue(mockLogger),
|
|
}))
|
|
|
|
vi.doMock('@/lib/core/utils/request', () => ({
|
|
generateRequestId: vi.fn().mockReturnValue('test-request-id'),
|
|
}))
|
|
|
|
vi.doMock('@/lib/webhooks/utils.server', () => ({
|
|
syncAllWebhooksForCredentialSet: mockSyncAllWebhooksForCredentialSet,
|
|
}))
|
|
|
|
vi.doMock('@/lib/audit/log', () => auditMock)
|
|
})
|
|
|
|
afterEach(() => {
|
|
vi.clearAllMocks()
|
|
})
|
|
|
|
it('should disconnect provider successfully', async () => {
|
|
mockGetSession.mockResolvedValueOnce({
|
|
user: { id: 'user-123' },
|
|
})
|
|
|
|
mockDb.delete.mockReturnValueOnce(mockDb)
|
|
mockDb.where.mockResolvedValueOnce(undefined)
|
|
|
|
const req = createMockRequest('POST', {
|
|
provider: 'google',
|
|
})
|
|
|
|
const { POST } = await import('@/app/api/auth/oauth/disconnect/route')
|
|
|
|
const response = await POST(req)
|
|
const data = await response.json()
|
|
|
|
expect(response.status).toBe(200)
|
|
expect(data.success).toBe(true)
|
|
expect(mockLogger.info).toHaveBeenCalled()
|
|
})
|
|
|
|
it('should disconnect specific provider ID successfully', async () => {
|
|
mockGetSession.mockResolvedValueOnce({
|
|
user: { id: 'user-123' },
|
|
})
|
|
|
|
mockDb.delete.mockReturnValueOnce(mockDb)
|
|
mockDb.where.mockResolvedValueOnce(undefined)
|
|
|
|
const req = createMockRequest('POST', {
|
|
provider: 'google',
|
|
providerId: 'google-email',
|
|
})
|
|
|
|
const { POST } = await import('@/app/api/auth/oauth/disconnect/route')
|
|
|
|
const response = await POST(req)
|
|
const data = await response.json()
|
|
|
|
expect(response.status).toBe(200)
|
|
expect(data.success).toBe(true)
|
|
expect(mockLogger.info).toHaveBeenCalled()
|
|
})
|
|
|
|
it('should handle unauthenticated user', async () => {
|
|
mockGetSession.mockResolvedValueOnce(null)
|
|
|
|
const req = createMockRequest('POST', {
|
|
provider: 'google',
|
|
})
|
|
|
|
const { POST } = await import('@/app/api/auth/oauth/disconnect/route')
|
|
|
|
const response = await POST(req)
|
|
const data = await response.json()
|
|
|
|
expect(response.status).toBe(401)
|
|
expect(data.error).toBe('User not authenticated')
|
|
expect(mockLogger.warn).toHaveBeenCalled()
|
|
})
|
|
|
|
it('should handle missing provider', async () => {
|
|
mockGetSession.mockResolvedValueOnce({
|
|
user: { id: 'user-123' },
|
|
})
|
|
|
|
const req = createMockRequest('POST', {})
|
|
|
|
const { POST } = await import('@/app/api/auth/oauth/disconnect/route')
|
|
|
|
const response = await POST(req)
|
|
const data = await response.json()
|
|
|
|
expect(response.status).toBe(400)
|
|
expect(data.error).toBe('Provider is required')
|
|
expect(mockLogger.warn).toHaveBeenCalled()
|
|
})
|
|
|
|
it('should handle database error', async () => {
|
|
mockGetSession.mockResolvedValueOnce({
|
|
user: { id: 'user-123' },
|
|
})
|
|
|
|
mockDb.delete.mockReturnValueOnce(mockDb)
|
|
mockDb.where.mockRejectedValueOnce(new Error('Database error'))
|
|
|
|
const req = createMockRequest('POST', {
|
|
provider: 'google',
|
|
})
|
|
|
|
const { POST } = await import('@/app/api/auth/oauth/disconnect/route')
|
|
|
|
const response = await POST(req)
|
|
const data = await response.json()
|
|
|
|
expect(response.status).toBe(500)
|
|
expect(data.error).toBe('Internal server error')
|
|
expect(mockLogger.error).toHaveBeenCalled()
|
|
})
|
|
})
|