From 312bd356c743d1df0bd5b62faba42feb5cb8dda0 Mon Sep 17 00:00:00 2001 From: Damien Arrachequesne Date: Sat, 5 Dec 2020 01:22:13 +0100 Subject: [PATCH] ci: migrate to GitHub Actions Due to the recent changes to the Travis CI platform (see [1]), we will now use GitHub Actions to run the tests. Reference: https://docs.github.com/en/free-pro-team@latest/actions/guides/building-and-testing-nodejs [1]: https://blog.travis-ci.com/2020-11-02-travis-ci-new-billing --- .github/workflows/ci.yml | 26 ++++++++++++++++++++++++++ .travis.yml | 10 ---------- README.md | 2 +- test/server.js | 2 +- 4 files changed, 28 insertions(+), 12 deletions(-) create mode 100644 .github/workflows/ci.yml delete mode 100644 .travis.yml diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml new file mode 100644 index 00000000..4e1fe7b2 --- /dev/null +++ b/.github/workflows/ci.yml @@ -0,0 +1,26 @@ +name: CI + +on: + push: + pull_request: + schedule: + - cron: '0 0 * * 0' + +jobs: + test-node: + runs-on: ubuntu-latest + + strategy: + matrix: + node-version: [10.x, 12.x, 14.x] + + steps: + - uses: actions/checkout@v2 + - name: Use Node.js ${{ matrix.node-version }} + uses: actions/setup-node@v1 + with: + node-version: ${{ matrix.node-version }} + - run: npm ci + - run: npm test + env: + CI: true diff --git a/.travis.yml b/.travis.yml deleted file mode 100644 index e84f6c75..00000000 --- a/.travis.yml +++ /dev/null @@ -1,10 +0,0 @@ -sudo: false -language: node_js -node_js: - - "10" - - "12" - - "14" -git: - depth: 1 -notifications: - irc: "irc.freenode.org#socket.io" diff --git a/README.md b/README.md index 97e843c6..62c800e1 100644 --- a/README.md +++ b/README.md @@ -1,7 +1,7 @@ # Engine.IO: the realtime engine -[![Build Status](https://travis-ci.org/socketio/engine.io.svg?branch=master)](http://travis-ci.org/socketio/engine.io) +[![Build Status](https://github.com/socketio/engine.io/workflows/CI/badge.svg)](https://github.com/socketio/engine.io/actions) [![NPM version](https://badge.fury.io/js/engine.io.svg)](http://badge.fury.io/js/engine.io) `Engine.IO` is the implementation of transport-based diff --git a/test/server.js b/test/server.js index aeef7887..63b64557 100644 --- a/test/server.js +++ b/test/server.js @@ -1059,7 +1059,7 @@ describe("server", function() { it("should trigger transport close before open for ws", function(done) { var opts = { transports: ["websocket"] }; listen(opts, function(port) { - var url = "ws://%s:%d".s("0.0.0.50", port); + var url = "ws://%s:%d".s("0.0.0.0", port); var socket = new eioc.Socket(url); socket.on("open", function() { done(new Error("Test invalidation"));