From 693080cac7e97f549f55294ef3dfe8a33236e60e Mon Sep 17 00:00:00 2001 From: Damien Arrachequesne Date: Mon, 20 Oct 2025 09:51:38 +0200 Subject: [PATCH] refactor(sio-adapter): add more debug logs --- .../socket.io-adapter/lib/cluster-adapter.ts | 27 +++++++++++++------ .../socket.io-adapter/test/cluster-adapter.ts | 5 ---- 2 files changed, 19 insertions(+), 13 deletions(-) diff --git a/packages/socket.io-adapter/lib/cluster-adapter.ts b/packages/socket.io-adapter/lib/cluster-adapter.ts index 10caf5fc..c53a48b4 100644 --- a/packages/socket.io-adapter/lib/cluster-adapter.ts +++ b/packages/socket.io-adapter/lib/cluster-adapter.ts @@ -199,6 +199,14 @@ export abstract class ClusterAdapter extends Adapter { return debug("[%s] ignore message from self", this.uid); } + if (message.nsp !== this.nsp.name) { + return debug( + "[%s] ignore message from another namespace (%s)", + this.uid, + message.nsp, + ); + } + debug( "[%s] new event of type %d from %s", this.uid, @@ -671,6 +679,8 @@ export abstract class ClusterAdapter extends Adapter { protected publish( message: DistributiveOmit, ): void { + debug("[%s] sending message %s", this.uid, message.type); + this.publishAndReturnOffset(message).catch((err) => { debug("[%s] error while publishing message: %s", this.uid, err); }); @@ -699,6 +709,14 @@ export abstract class ClusterAdapter extends Adapter { ) { (response as ClusterResponse).uid = this.uid; (response as ClusterResponse).nsp = this.nsp.name; + + debug( + "[%s] sending response %s to %s", + this.uid, + response.type, + requesterUid, + ); + this.doPublishResponse(requesterUid, response as ClusterResponse).catch( (err) => { debug("[%s] error while publishing response: %s", this.uid, err); @@ -790,17 +808,10 @@ export abstract class ClusterAdapterWithHeartbeat extends ClusterAdapter { } if (message.uid && message.uid !== EMITTER_UID) { - // we track the UID of each sender, in order to know how many servers there are in the cluster + // we track the UID of each sender to know how many servers there are in the cluster this.nodesMap.set(message.uid, Date.now()); } - debug( - "[%s] new event of type %d from %s", - this.uid, - message.type, - message.uid, - ); - switch (message.type) { case MessageType.INITIAL_HEARTBEAT: this.publish({ diff --git a/packages/socket.io-adapter/test/cluster-adapter.ts b/packages/socket.io-adapter/test/cluster-adapter.ts index fe727c59..18af8d47 100644 --- a/packages/socket.io-adapter/test/cluster-adapter.ts +++ b/packages/socket.io-adapter/test/cluster-adapter.ts @@ -67,11 +67,6 @@ describe("cluster adapter", () => { serverSockets.push(socket); servers.push(io); if (servers.length === NODES_COUNT) { - // ensure all nodes know each other - servers[0].emit("ping"); - servers[1].emit("ping"); - servers[2].emit("ping"); - done(); } });