Commit Graph

71 Commits

Author SHA1 Message Date
albertyfwu
89de5f5975 fixed bug89 and added tests: writeBuffer not flushed until nextTick' 2013-03-12 02:59:47 -04:00
Yihui Saw
edfec30b77 Added tests for query string 2013-03-10 22:31:39 -04:00
Roman Shtylman
fd36eeaf02 Only end upgrade socket connections if unhandled
This fixes an issue where multiple engine.io instances (on different
paths) would result in the closing of websocket connections for all of
the instances. This happened because each engine.io instance would
register an `upgrade` handler on the server. This handler would check
for a matching path and otherwise call `socket.end()` Since multiple
upgrade events would be triggered with different paths, the peer
handlers would close each other.

This patch resolves this behavior in the following way:
- When an instance upgrade handler encounters a path which it does not
  recognize it creates a timeout for `destroyUpgradeTimeout`.
- At the end of the timeout, the socket is checked for writable state
  and bytes written. If there has been not activity and the socket is
  writable, then it will be ended.

This allows for peer socket handlers to keep the socket alive by sending
some data over it. This also mimics the core node behavior of closing
sockets on upgrade when no handler is specified. We consider not
handling an upgrade request similar to no handler. However, we cannot
immediately end the socket for the reasons noted above.

fixes #143
2013-01-31 22:42:11 -05:00
Sweet
b69264dad9 Removed the lib/index in all the files 2013-01-19 14:27:17 -08:00
Sweet
dd5a4cb939 Merge branch 'master' of github.com:LearnBoost/engine.io into ExstractParser
Conflicts:
	package.json
2013-01-19 12:37:37 -08:00
Sweet
face92f018 paerse.js: modified parser to be used with the parser repo
package.json: updated with the correct parser dependency
common.js: changed the parser path
server.js: also changed the parser path
2013-01-19 12:25:31 -08:00
Michal Srb
86366e86a5 Fixed should trigger ping timeout test 2013-01-19 18:20:25 +00:00
roam
148f654c92 Fixed bugs in previous send callback fix and updated test cases 2013-01-16 17:31:42 +08:00
roam
72861f3d49 Added a test case which makes the code before the send callback fix fail 2013-01-16 15:13:50 +08:00
Jxck
b4d60687ac add packetCreate event for #99 2012-11-06 20:34:10 +09:00
Guillermo Rauch
ec9334dc03 Merge pull request #114 from Jxck/master
refuctoring test which fales depends on timing
2012-11-05 08:09:00 -08:00
Jxck
dabc50b011 refuctoring test
this test dosen't pass in some timing in my machine.
so make it not to depends on timeout.
2012-11-06 00:50:34 +09:00
Guillermo Rauch
ee1eacf638 Merge pull request #109 from indutny/feature-visible-verification-failure
server: send validation failure reason to clients
2012-11-05 07:26:43 -08:00
Jxck
46f310462b add packet event to socket 2012-11-05 21:33:02 +09:00
Fedor Indutny
bb1f860239 server: send validation failure reason to clients 2012-11-01 00:35:49 +04:00
Guillermo Rauch
4f0f811001 test: make sure the many messages test has the right timeout config 2012-10-21 09:21:58 -07:00
Guillermo Rauch
1aa47406fd test: improve ping timeout tests 2012-10-21 09:16:44 -07:00
Guillermo Rauch
33c5806864 test: make client ping timeout test more reliable 2012-10-21 09:10:23 -07:00
Fedor Indutny
be7b4e7478 socket: reset ping timeout on incoming data 2012-10-16 23:39:57 +07:00
cadorn
6a8a77a65e remove console.log 2012-10-15 17:29:36 -07:00
cadorn
c4bf8edf43 mass data test 2012-10-15 17:11:27 -07:00
Guillermo Rauch
092576990a test: fixed tests not passing with node-xmlhttprequest 1.5.0 2012-10-07 17:33:26 -07:00
Guillermo Rauch
d32c9c1a80 test: fixed style 2012-10-04 09:21:09 -07:00
Guillermo Rauch
2f806d35b4 Merge pull request #84 from c9/better-pings2
Better pings 2
2012-10-04 08:41:27 -07:00
Dan Zajdband
3344ac4ed9 query instead of send get parameters in test/server.js tests. It was breaking tests 2012-09-21 15:44:07 -03:00
cadorn
16650233d9 ping from client 2012-09-12 16:12:46 -07:00
cadorn
0b9f7809bc changes for #78 2012-09-12 13:17:48 -07:00
Afshin Mehrabani
dd3440ced7 rebase with master 2012-09-10 21:01:20 +04:30
Afshin Mehrabani
a318a30ced fix code styling, bad indentation 2012-09-05 00:58:33 +04:30
Guillermo Rauch
95303cb3f3 test: fixed test for clearing callback references 2012-09-04 12:06:57 -07:00
Guillermo Rauch
eeacea93ff test: fix style, removed test that's not passing 2012-09-04 12:06:41 -07:00
Guillermo Rauch
6b725eb349 Merge pull request #71 from afshinm/master
add `send` callback feature
2012-09-04 11:12:22 -07:00
Afshin Mehrabani
b7ac48941e fix double \n 2012-09-04 22:40:46 +04:30
Afshin Mehrabani
8af0e2a253 two new test for send callback
in this new tests we assert that:
1- when socket get closed and one or more packet(s) are in writeBuffer,
callback references get cleaned to avoid memory leak.
2- callbacks still execute in polling mode
2012-09-04 21:32:25 +04:30
Afshin Mehrabani
37c91fc822 fix tests + code styling 2012-08-26 19:32:59 +04:30
Afshin Mehrabani
837ba76477 add new test
test the callback while polling
2012-08-26 00:42:21 +04:30
Afshin Mehrabani
c81cf614e1 fix code style problems, remove unnecessary clearing 2012-08-25 21:09:21 +04:30
Afshin Mehrabani
23004e8b6e fix code styling issues 2012-08-21 00:23:14 +04:30
Afshin Mehrabani
347639b117 add new send callback tests 2012-08-20 12:16:33 +04:30
Afshin Mehrabani
1434eaf78f add send callback tests + a little change in function 2012-08-15 22:27:03 +04:30
Guillermo Rauch
81a6e76426 test: added flush/drain events tests 2012-08-10 10:46:00 -07:00
Guillermo Rauch
02573b0652 test: added Connection: close test. 2012-08-06 15:08:43 -07:00
Guillermo Rauch
1d580fef07 test: added closing connection test 2012-08-06 11:51:35 -07:00
Guillermo Rauch
fb522c46fa test: updated tests 2012-08-06 09:18:39 -07:00
Guillermo Rauch
a86e1aeba1 server: added failing test courtesy of Contra 2012-08-01 16:10:28 -07:00
Guillermo Rauch
21f3e7033a Adapted test to new API 2012-07-03 14:20:16 -07:00
Guillermo Rauch
2edf01dd2c Added thorough cookie tests. 2012-07-03 14:20:05 -07:00
Guillermo Rauch
4fd56bf3f6 test: added io cookie handshake test 2012-07-02 11:03:24 -07:00
Guillermo Rauch
3a2b592398 test: added onopen and onclose to test 2012-07-02 07:43:15 -07:00
Guillermo Rauch
7b0699b10f Added default resource to test URLs. 2012-04-03 08:18:11 -03:00