Commit Graph

21 Commits

Author SHA1 Message Date
Damien Arrachequesne
cab895f477 refactor: use prettier to format tests 2020-10-06 00:21:14 +02:00
Damien Arrachequesne
0fe9439ff6 [fix] Fire an error event on middleware failure for non-root namespace (#1202)
In the following example:

```js
io.use((socket, next) => {
  next(new Error('Auth failed'));
});

// client-side
const socket = io('https://url/custom-namespace');

socket.on('error', (err) => {
  // ...
});
```

The 'error' event wasn't fired on the custom namespace.
2018-05-17 22:53:37 +02:00
Damien Arrachequesne
57cee214fb [test] Remove IE6 and IE7 tests (#1164)
Related: https://wiki.saucelabs.com/pages/viewpage.action?pageId=70074721
2017-10-22 15:08:16 +02:00
Damien Arrachequesne
8091591422 [fix] Do not update the opts.query reference (#1121) 2017-06-01 12:35:31 +02:00
Damien Arrachequesne
fcb5c43ffe [fix] Add nsp prefix to socket.id (#1058)
So the socket ids on the client and on the server are equals.
2017-01-13 16:53:44 +01:00
Zheng Weihan
4578f7ed35 Merge branch 'orgmaster' into queryStringFix
* orgmaster: (44 commits)
  bump zuul
  Remove jspm browser config
  Run lint before test instead of before build
  ESlint manual fix
  Eslint autofix
  Add env to eslintrc
  Exclude generated files from linting
  updated babel-eslint dep to 4.1.7 (4.1.6 broken)
  refactor gulpfile
  Add eslint to gulpfile and create gulp task default
  fixed regex
  Rename gulp task webpack to build
  Remove commented make recipe
  removed babel react preset
  Makefile use gulp from node_modules instead of global
  Remove browserify stuff, add zuul-builder-webpack devDep
  Migrate zuul config from yml to js
  Refactor webpack config out to support/webpack.config.js
  removed ide-specific entries from gitignore
  updated makefile to use gulp commands
  ...

Conflicts:
	lib/manager.js
	lib/socket.js
2016-04-12 19:17:09 +08:00
Diga Widyaprana
d1cbc68ea7 Eslint autofix 2016-02-28 02:36:06 +08:00
whattokingu
f01a349af8 add back changes made in previous commit
previous commit [here](3407f3f522).
2016-02-16 00:37:05 +08:00
whattokingu
bfa458941c fix error with test. 2016-02-13 13:50:43 +08:00
whattokingu
e0580ef475 Merge pull request #10 from whattokingu/queryStringFix
Query string fix
2016-02-13 13:47:53 +08:00
Zheng Weihan
e3c0f6a41e encodes queries using encodeURIComponent 2016-02-13 13:27:04 +08:00
Zhu Liang
3407f3f522 update test 2016-02-01 13:50:11 +08:00
Zhu Liang
b14018eed6 fixed test case 2016-02-01 13:00:13 +08:00
Zheng Weihan
1657971d8c remove console statement. 2016-01-31 16:07:21 +08:00
Zheng Weihan
9fa6b1c6d2 update tests 2016-01-31 15:33:16 +08:00
Zheng Weihan
3290bb43f1 move encoding of query string to lookup function.
handles passing of query via query strings
add tests for functionality
2016-01-31 15:29:49 +08:00
Guillermo Rauch
adbd0e3e36 added support for ping and pong events
https://github.com/Automattic/socket.io/issues/1951
2015-04-05 15:45:17 -07:00
Guillermo Rauch
2a2866b049 proper handling of disconnection while in opening state 2015-04-05 12:20:13 -07:00
Naoyuki Kanezawa
b15404e218 support compression 2015-01-22 06:51:49 +09:00
Tony Kovanen
5d96f92940 Make sure socket.id is defined 2015-01-17 22:20:00 +02:00
Tony Kovanen
b0c4c2edd0 Added socket.id property
- Make sure `socket.id` is defined on connect
- Make sure `socket.id` is cleared on disconnect
- Make sure `socket.id` is updated on reconnect
2015-01-14 18:18:02 +02:00