Guillermo Rauch
d352ccdcda
Revert "socket: clear timer after sending one noop packet ( fixes #174 )"
...
This reverts commit 752dab4c16
2013-06-15 16:22:40 -07:00
Guillermo Rauch
1f3d7f6eb6
Revert "WebSocket setTimeout wrap when on iOS"
...
This reverts commit bc5ba93296
2013-06-06 17:28:04 -07:00
Guillermo Rauch
8687ea4520
Revert "websocket:Improve send method"
...
This reverts commit 60c61af68e
2013-06-06 17:27:57 -07:00
Guillermo Rauch
752dab4c16
socket: clear timer after sending one noop packet ( fixes #174 )
2013-05-31 07:22:08 -07:00
Raynos
cb578ad70e
clear timers in onClose
2013-05-20 23:37:15 -07:00
Raynos
316c84eef3
Clear all timers on socket close
2013-05-20 22:14:27 -07:00
Malcom Gilbert
51ede1ec38
adding test for faulty websocket request
2013-03-24 18:21:55 -04:00
Malcom Gilbert
0280352f88
sending error on transport creation failure due to bad request
2013-03-22 17:08:37 -04:00
Guillermo Rauch
cbe8a2ef05
polling: implemented new protocol
2013-03-16 12:34:05 -07:00
Guillermo Rauch
f5cf2243ec
transports: implemented new parser
2013-03-16 09:10:32 -07:00
albertyfwu
300b096000
test writeBuffer isn't cleared onError, removed 'closing' check in .flush()
2013-03-12 20:16:46 -04:00
albertyfwu
89de5f5975
fixed bug89 and added tests: writeBuffer not flushed until nextTick'
2013-03-12 02:59:47 -04:00
Guillermo Rauch
81e599b344
Release 0.4.2
2013-02-08 11:12:15 -08:00
Guillermo Rauch
1059147fa3
Merge pull request #141 from pokermania/to_learnboost_20130130
...
close socket if upgrade is received and socket.readyState != open
2013-02-08 08:17:08 -08:00
stephen-bradshaw
f2bc5190b4
fix spelling errors
2013-02-08 09:27:52 +00:00
Roman Shtylman
fd36eeaf02
Only end upgrade socket connections if unhandled
...
This fixes an issue where multiple engine.io instances (on different
paths) would result in the closing of websocket connections for all of
the instances. This happened because each engine.io instance would
register an `upgrade` handler on the server. This handler would check
for a matching path and otherwise call `socket.end()` Since multiple
upgrade events would be triggered with different paths, the peer
handlers would close each other.
This patch resolves this behavior in the following way:
- When an instance upgrade handler encounters a path which it does not
recognize it creates a timeout for `destroyUpgradeTimeout`.
- At the end of the timeout, the socket is checked for writable state
and bytes written. If there has been not activity and the socket is
writable, then it will be ended.
This allows for peer socket handlers to keep the socket alive by sending
some data over it. This also mimics the core node behavior of closing
sockets on upgrade when no handler is specified. We consider not
handling an upgrade request similar to no handler. However, we cannot
immediately end the socket for the reasons noted above.
fixes #143
2013-01-31 22:42:11 -05:00
Andor Goetzendorff
4ef40991be
close socket if upgrade is received and socket.readyState != open
2013-01-30 16:57:44 +01:00
Sweet
b69264dad9
Removed the lib/index in all the files
2013-01-19 14:27:17 -08:00
Sweet
90c0cd0e3f
parser.js: deleted
...
package.json: updated the version for the client
everything else: fixed paths/requirements to the new protocol/parser repo
2013-01-19 13:14:00 -08:00
Sweet
dd5a4cb939
Merge branch 'master' of github.com:LearnBoost/engine.io into ExstractParser
...
Conflicts:
package.json
2013-01-19 12:37:37 -08:00
Sweet
face92f018
paerse.js: modified parser to be used with the parser repo
...
package.json: updated with the correct parser dependency
common.js: changed the parser path
server.js: also changed the parser path
2013-01-19 12:25:31 -08:00
Michal Srb
60c61af68e
websocket:Improve send method
2013-01-19 18:15:32 +00:00
Michal Srb
bc5ba93296
WebSocket setTimeout wrap when on iOS
2013-01-19 04:26:03 +00:00
roam
148f654c92
Fixed bugs in previous send callback fix and updated test cases
2013-01-16 17:31:42 +08:00
roam
06b39687eb
Fixed send callback test failures
2013-01-16 14:35:56 +08:00
roam
41ee77e3c6
Revert "Revert "Fixed packet send callback design issue""
...
This reverts commit ead08d6e5b
2013-01-15 17:17:47 +08:00
Guillermo Rauch
ead08d6e5b
Revert "Fixed packet send callback design issue"
...
This reverts commit 0dfa68c710
2012-12-26 17:19:41 -03:00
roam
0dfa68c710
Fixed packet send callback design issue
...
There were two issues here.
1. When Socket.send called with or without callback alternately,
the trigger order is incorrect.
2. The 'drain' event from transport is one per packet for transports
supporting framing like websocket and is all in one for those without
framing like polling.
2012-12-20 00:49:32 +08:00
Guillermo Rauch
9d9fe9e2e2
socket: emit data event (synonym with message)
2012-12-17 09:57:54 -03:00
Guillermo Rauch
95ded5d885
engine.io: style
2012-12-17 08:45:14 -03:00
Guillermo Rauch
12f1821f1c
socket: added Socket#write
2012-12-16 23:35:42 -03:00
Guillermo Rauch
01e06d7a4f
engine.io: cleanup
2012-12-16 20:35:54 -03:00
Guillermo Rauch
c59bb42e85
engine.io: deprecated resource
2012-12-16 20:25:08 -03:00
Guillermo Rauch
73c772d0b3
Revert "engine.io: added middleware attachment possibility (eg: for express)"
...
This reverts commit 7b3243dbea
2012-12-16 18:49:06 -03:00
Guillermo Rauch
7b3243dbea
engine.io: added middleware attachment possibility (eg: for express)
2012-12-13 12:29:37 -03:00
Guillermo Rauch
3bafecd882
Merge branch 'master' of github.com:/LearnBoost/engine.io
2012-11-06 08:25:07 -08:00
Jxck
b4d60687ac
add packetCreate event for #99
2012-11-06 20:34:10 +09:00
Guillermo Rauch
ee1eacf638
Merge pull request #109 from indutny/feature-visible-verification-failure
...
server: send validation failure reason to clients
2012-11-05 07:26:43 -08:00
Jxck
46f310462b
add packet event to socket
2012-11-05 21:33:02 +09:00
Guillermo Rauch
971199d19b
engine.io: some cleanup
2012-11-04 09:20:47 -08:00
Guillermo Rauch
a3798f3f15
Merge branch 'master' of github.com:/LearnBoost/engine.io
2012-11-04 09:12:51 -08:00
Guillermo Rauch
13e06795ac
transports: remove Connection headers and let node handle it ( fixes #111 )
2012-11-04 09:11:39 -08:00
Fedor Indutny
bb1f860239
server: send validation failure reason to clients
2012-11-01 00:35:49 +04:00
Andor Goetzendorff
7f08ee3f50
invoking as a function causes attach, refs #104
2012-10-29 13:40:07 +01:00
Lal Jérémy
bbe3d95513
Socket.flush: reset writeBuffer before send
...
This prevents legacy node versions from calling Socket.flush before it
could reset writeBuffer, leading to double-flush.
2012-10-24 23:32:23 +03:00
Fedor Indutny
be7b4e7478
socket: reset ping timeout on incoming data
2012-10-16 23:39:57 +07:00
Guillermo Rauch
689644247c
socket: added missing jsdoc (gross)
2012-10-11 12:43:36 -07:00
Joe Walnes
61d4c1a7b5
Slow upgrade should not take down server.
...
I noticed this on very heavily overloaded server - the typos raises an uncaught exception.
2012-10-10 16:44:37 -05:00
Guillermo Rauch
f0c7097738
transports: improved instrumentation
2012-10-08 17:22:33 -07:00
Guillermo Rauch
1c96ca4fe8
socket: improve check interval for upgrade
2012-10-08 15:41:13 -07:00
