Commit Graph

73 Commits

Author SHA1 Message Date
Guillermo Rauch
d352ccdcda Revert "socket: clear timer after sending one noop packet (fixes #174)"
This reverts commit 752dab4c16.
2013-06-15 16:22:40 -07:00
Guillermo Rauch
752dab4c16 socket: clear timer after sending one noop packet (fixes #174) 2013-05-31 07:22:08 -07:00
Raynos
cb578ad70e clear timers in onClose 2013-05-20 23:37:15 -07:00
Raynos
316c84eef3 Clear all timers on socket close 2013-05-20 22:14:27 -07:00
albertyfwu
300b096000 test writeBuffer isn't cleared onError, removed 'closing' check in .flush() 2013-03-12 20:16:46 -04:00
albertyfwu
89de5f5975 fixed bug89 and added tests: writeBuffer not flushed until nextTick' 2013-03-12 02:59:47 -04:00
Andor Goetzendorff
4ef40991be close socket if upgrade is received and socket.readyState != open 2013-01-30 16:57:44 +01:00
roam
148f654c92 Fixed bugs in previous send callback fix and updated test cases 2013-01-16 17:31:42 +08:00
roam
06b39687eb Fixed send callback test failures 2013-01-16 14:35:56 +08:00
roam
41ee77e3c6 Revert "Revert "Fixed packet send callback design issue""
This reverts commit ead08d6e5b.
2013-01-15 17:17:47 +08:00
Guillermo Rauch
ead08d6e5b Revert "Fixed packet send callback design issue"
This reverts commit 0dfa68c710.
2012-12-26 17:19:41 -03:00
roam
0dfa68c710 Fixed packet send callback design issue
There were two issues here.
1. When Socket.send called with or without callback alternately,
   the trigger order is incorrect.
2. The 'drain' event from transport is one per packet for transports
   supporting framing like websocket and is all in one for those without
   framing like polling.
2012-12-20 00:49:32 +08:00
Guillermo Rauch
9d9fe9e2e2 socket: emit data event (synonym with message) 2012-12-17 09:57:54 -03:00
Guillermo Rauch
12f1821f1c socket: added Socket#write 2012-12-16 23:35:42 -03:00
Jxck
b4d60687ac add packetCreate event for #99 2012-11-06 20:34:10 +09:00
Jxck
46f310462b add packet event to socket 2012-11-05 21:33:02 +09:00
Lal Jérémy
bbe3d95513 Socket.flush: reset writeBuffer before send
This prevents legacy node versions from calling Socket.flush before it
could reset writeBuffer, leading to double-flush.
2012-10-24 23:32:23 +03:00
Fedor Indutny
be7b4e7478 socket: reset ping timeout on incoming data 2012-10-16 23:39:57 +07:00
Guillermo Rauch
689644247c socket: added missing jsdoc (gross) 2012-10-11 12:43:36 -07:00
Joe Walnes
61d4c1a7b5 Slow upgrade should not take down server.
I noticed this on very heavily overloaded server - the typos raises an uncaught exception.
2012-10-10 16:44:37 -05:00
Guillermo Rauch
1c96ca4fe8 socket: improve check interval for upgrade 2012-10-08 15:41:13 -07:00
Guillermo Rauch
17c657957e socket: faster upgrades (we perform a check immediately) 2012-10-08 13:47:50 -07:00
cadorn
16650233d9 ping from client 2012-09-12 16:12:46 -07:00
cadorn
0b9f7809bc changes for #78 2012-09-12 13:17:48 -07:00
Guillermo Rauch
6b725eb349 Merge pull request #71 from afshinm/master
add `send` callback feature
2012-09-04 11:12:22 -07:00
Afshin Mehrabani
7f483042d4 styling problem 2012-08-25 22:04:58 +04:30
Afshin Mehrabani
7959e0a05b change in conditions 2012-08-25 21:58:14 +04:30
Afshin Mehrabani
175a3f003e fix styling problem 2012-08-25 21:52:34 +04:30
Afshin Mehrabani
1e3a0ef614 fix styling problem 2012-08-25 21:47:22 +04:30
Afshin Mehrabani
148a10209a Revert "fix style problem"
This reverts commit 514e728433.
2012-08-25 21:45:16 +04:30
Afshin Mehrabani
514e728433 fix style problem 2012-08-25 21:42:29 +04:30
Afshin Mehrabani
c81cf614e1 fix code style problems, remove unnecessary clearing 2012-08-25 21:09:21 +04:30
Afshin Mehrabani
8f4d6f9e13 remove unnecessary sequence id & drain emit parameter 2012-08-24 04:01:36 +04:30
Afshin Mehrabani
23004e8b6e fix code styling issues 2012-08-21 00:23:14 +04:30
Afshin Mehrabani
ab4393fbd8 fix indentation 2012-08-20 23:21:35 +04:30
Afshin Mehrabani
d5dff2dd62 change comment 2012-08-20 12:18:22 +04:30
Afshin Mehrabani
cb02a97d0c add sequence id, change websocket send function 2012-08-18 12:14:17 +04:30
Afshin Mehrabani
1434eaf78f add send callback tests + a little change in function 2012-08-15 22:27:03 +04:30
Afshin Mehrabani
634b11af71 add send callback
issue #57
2012-08-13 22:34:50 +04:30
Guillermo Rauch
b948f858fb socket: fix flush event parameter 2012-08-10 10:45:48 -07:00
Guillermo Rauch
271585189f socket: added flush/drain events (fixes #56) 2012-08-10 10:39:09 -07:00
Guillermo Rauch
73cf06cc34 Added accessor to transport handshake request 2012-07-03 14:17:17 -07:00
Guillermo Rauch
566acd1ffd socket: transfer sid to transport upon opening 2012-07-02 11:02:39 -07:00
Guillermo Rauch
82ec5a8bc9 socket: ignore transport errors from discarded transports (fixes #26) 2012-07-02 07:52:36 -07:00
Guillermo Rauch
00f9738292 socket: added polling cycle force for fast upgrade 2012-07-02 07:34:02 -07:00
Lal Jérémy
d1d35263b1 Socket.ping() should be idempotent, if not race conditions can appear and connection closes. 2012-02-22 15:13:01 +01:00
Lal Jérémy
b56354c84b Update lib/socket.js 2012-02-22 00:20:16 +01:00
einaros
89a30ec268 avoid suggesting upgrades which arent enabled on the server 2012-01-26 09:28:35 -08:00
Guillermo Rauch
e305e16ad7 Stopped sending interval to client. 2012-01-17 09:51:44 -08:00
Guillermo Rauch
cf57b9a01a Empty packet data translates into empty message. 2012-01-16 09:25:34 -08:00