mirror of
https://github.com/socketio/socket.io.git
synced 2026-04-30 03:00:39 -04:00
285e7cd0d8
The binary detection was moved from the parser to the client/server in
[1], in order to allow the user to skip the binary detection for huge
JSON payloads.
```js
socket.binary(false).emit(...);
```
The binary detection is needed in the default parser, because the
payload is encoded with JSON.stringify(), which does not support binary
content (ArrayBuffer, Blob, ...).
But other parsers (like [2] or [3]) do not need this check, so we'll
move the binary detection back here and remove the socket.binary()
method, as this use case is now covered by the ability to provide your
own parser.
Note: the hasBinary method was copied from [4].
[1]: f44256c523
[2]: https://github.com/darrachequesne/socket.io-msgpack-parser
[3]: https://github.com/darrachequesne/socket.io-json-parser
[4]: https://github.com/darrachequesne/has-binary
29 lines
569 B
JavaScript
29 lines
569 B
JavaScript
const { PacketType } = require("..");
|
|
const helpers = require("./helpers.js");
|
|
|
|
describe("parser", () => {
|
|
it("encodes a Buffer", (done) => {
|
|
helpers.test_bin(
|
|
{
|
|
type: PacketType.EVENT,
|
|
data: ["a", Buffer.from("abc", "utf8")],
|
|
id: 23,
|
|
nsp: "/cool",
|
|
},
|
|
done
|
|
);
|
|
});
|
|
|
|
it("encodes a binary ack with Buffer", (done) => {
|
|
helpers.test_bin(
|
|
{
|
|
type: PacketType.ACK,
|
|
data: ["a", Buffer.from("xxx", "utf8"), {}],
|
|
id: 127,
|
|
nsp: "/back",
|
|
},
|
|
done
|
|
);
|
|
});
|
|
});
|