From 09abc8eede0126e2a4490e4018a576cebebf313f Mon Sep 17 00:00:00 2001 From: Allan Odgaard Date: Mon, 24 Dec 2012 14:09:41 +0100 Subject: [PATCH] Fix software update logic It would previously not ask to update (but go directly to download) when doing a manual update check. --- Frameworks/SoftwareUpdate/src/SoftwareUpdate.mm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Frameworks/SoftwareUpdate/src/SoftwareUpdate.mm b/Frameworks/SoftwareUpdate/src/SoftwareUpdate.mm index 30e5514d..3647ef6e 100644 --- a/Frameworks/SoftwareUpdate/src/SoftwareUpdate.mm +++ b/Frameworks/SoftwareUpdate/src/SoftwareUpdate.mm @@ -173,7 +173,7 @@ static SoftwareUpdate* SharedInstance; } else if(info.version > thisVersion) { - if(!backgroundFlag && [[NSUserDefaults standardUserDefaults] boolForKey:kUserDefaultsAskBeforeUpdatingKey]) + if(!backgroundFlag || [[NSUserDefaults standardUserDefaults] boolForKey:kUserDefaultsAskBeforeUpdatingKey]) { NSInteger choice = NSRunInformationalAlertPanel(@"New Version Available", @"%@ %ld is now available—you have %ld. Would you like to download it now?", @"Download & Install", nil, @"Later", appName, info.version, thisVersion); if(choice == NSAlertDefaultReturn) // “Download & Install”