From 2d6930cfee958bf2079cd2de84bd13bb2aaedd3c Mon Sep 17 00:00:00 2001 From: Allan Odgaard Date: Sun, 8 Jul 2018 20:28:54 +0200 Subject: [PATCH] Provide OFBFinderTagsChooser with non-favorite tags MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Since OFBFinderTagsChooser always show only the favorite tags, any non-favorite tag set as selected or removable will simply be ignored, so there is no reason to filter these out at the call-site. In fact, whether or not to show non-favorite tags should probably be an OFBFinderTagsChooser decision. Furthermore, the tag’s favorite status is set during initialization, so it could actually be outdated when showing the OFBFinderTagsChooser. --- Frameworks/OakFileBrowser/src/OakFileBrowser.mm | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Frameworks/OakFileBrowser/src/OakFileBrowser.mm b/Frameworks/OakFileBrowser/src/OakFileBrowser.mm index e8eb26d1..36d75239 100644 --- a/Frameworks/OakFileBrowser/src/OakFileBrowser.mm +++ b/Frameworks/OakFileBrowser/src/OakFileBrowser.mm @@ -969,8 +969,7 @@ static bool is_binary (std::string const& path) for(FSItem* item in self.selectedItems) for(OakFinderTag* tag in item.finderTags) - if(tag.isMarkedFavorite) - [finderTagsCountedSet addObject:tag.displayName]; + [finderTagsCountedSet addObject:tag.displayName]; for(NSString* tagName in finderTagsCountedSet) {