From 2df18d80b005bfaa56589ab28f72614eadd60386 Mon Sep 17 00:00:00 2001 From: Allan Odgaard Date: Sun, 26 May 2013 15:40:03 +0800 Subject: [PATCH] =?UTF-8?q?The=20bundle=E2=80=99s=20info.plist=20can=20now?= =?UTF-8?q?=20specify=20requiredCommands?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This will apply to all items in the bundle so it’s questionable if it’s something we want to use, as it would not allow the user to run a “Help” command from the bundle without first setting up the requirements. OTOH setting requiredCommands for all but a few items in e.g. the Git bundle seems redundant — perhaps items should be able to eclipse keys from the bundle’s info.plist to effectively unset the requiredCommands for a select few items. --- Frameworks/bundles/src/wrappers.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Frameworks/bundles/src/wrappers.cc b/Frameworks/bundles/src/wrappers.cc index d37ef27e..ecb969da 100644 --- a/Frameworks/bundles/src/wrappers.cc +++ b/Frameworks/bundles/src/wrappers.cc @@ -30,6 +30,8 @@ namespace bundles static std::vector requirements (item_ptr const& item) { std::vector res; + if(item->kind() != kItemTypeBundle) + res = requirements(item->bundle()); plist::array_t array; if(plist::get_key_path(item->plist(), "requiredCommands", array))