From a6e6437262522d6d2097a4e7b396069b19dfe024 Mon Sep 17 00:00:00 2001 From: Allan Odgaard Date: Wed, 5 Dec 2018 21:16:25 +0700 Subject: [PATCH] =?UTF-8?q?Set=20=E2=80=98accessibilityElement=E2=80=99=20?= =?UTF-8?q?on=20NSControl=E2=80=99s=20cell=20object?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit An alternative to accessing the cell directly is using NSAccessibilityUnignoredDescendant to obtain the object, but while it seems to abstract away whether or not it is the control or its cell which participates in accessibility, we forego the type checker. --- Frameworks/OakTabBarView/src/OakTabBarView.mm | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/Frameworks/OakTabBarView/src/OakTabBarView.mm b/Frameworks/OakTabBarView/src/OakTabBarView.mm index d0840439..8fea3dac 100644 --- a/Frameworks/OakTabBarView/src/OakTabBarView.mm +++ b/Frameworks/OakTabBarView/src/OakTabBarView.mm @@ -378,17 +378,15 @@ static void* kOakTabViewSelectedContext = &kOakTabViewSelectedContext; if(_tabItem) { - self.accessibilityElement = YES; - self.closeButton.hidden = NO; - self.closeButton.accessibilityElement = YES; - self.overflowButton.accessibilityElement = YES; + self.accessibilityElement = YES; + self.closeButton.cell.accessibilityElement = YES; + self.overflowButton.cell.accessibilityElement = YES; } else { - self.accessibilityElement = NO; - self.closeButton.hidden = YES; - self.closeButton.accessibilityElement = NO; - self.overflowButton.accessibilityElement = NO; + self.accessibilityElement = NO; + self.closeButton.cell.accessibilityElement = NO; + self.overflowButton.cell.accessibilityElement = NO; self.textField.alphaValue = 0.0; self.backgroundView.alphaValue = 0.1;