github/textmate
1
1
Fork 0
mirror of https://github.com/textmate/textmate.git synced 2026-04-28 03:00:34 -04:00
Code Issues Packages Projects Releases Wiki Activity

Perform cache invalidation for value_for_setting cache

Browse Source
This commit is contained in:
Allan Odgaard
2014-09-16 14:22:54 +02:00
parent 1d3ccb157a
commit b265927501
1 changed files with 23 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
Frameworks/bundles/src/wrappers.cc
View File

@@ -187,20 +187,35 @@ namespace bundles
plist::any_t value_for_setting (std::string const& setting, scope::context_t const& scope, item_ptr* match)
{
static std::map<std::string, item_ptr> cache;
struct cache_t : bundles::callback_t
{
cache_t ()
{
bundles::add_callback(this);
}
static std::mutex mutex;
std::lock_guard<std::mutex> lock(mutex);
void bundles_did_change ()
{
std::lock_guard<std::mutex> lock(mutex);
map.clear();
}
std::map<std::string, item_ptr> map;
std::mutex mutex;
};
static cache_t cache;
std::lock_guard<std::mutex> lock(cache.mutex);
std::string const key = setting + "\037" + to_s(scope);
auto iter = cache.find(key);
if(iter == cache.end())
auto iter = cache.map.find(key);
if(iter == cache.map.end())
{
if(cache.size() > 1000)
cache.clear();
if(cache.map.size() > 1000)
cache.map.clear();
auto items = query(kFieldSettingName, setting, scope, kItemTypeSettings);
iter = cache.emplace(key, items.empty() ? item_ptr() : items.front()).first;
iter = cache.map.emplace(key, items.empty() ? item_ptr() : items.front()).first;
}
plist::any_t res;