From d96dbc426958e097fe6cd60e66ed362ea92a982b Mon Sep 17 00:00:00 2001 From: Allan Odgaard Date: Sun, 6 Jan 2013 15:31:10 +0100 Subject: [PATCH] =?UTF-8?q?Clicking=20a=20=E2=80=98find=20all=E2=80=99=20r?= =?UTF-8?q?esult=20would=20be=20handled=20twice?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Normally this wouldn’t be noticed, as the second action would do the same as the first (go to the result in the associated project window), but when there was no project window a new window opens (to show the result), and that would be done twice. This fixes issue #281. There is still an issue with successive selections for the “no project window” situation, as each time, a new window is opened, rather than reuse the first one that opened. --- Frameworks/Find/src/FFWindowController.mm | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Frameworks/Find/src/FFWindowController.mm b/Frameworks/Find/src/FFWindowController.mm index 4ba47abe..9ba4d909 100644 --- a/Frameworks/Find/src/FFWindowController.mm +++ b/Frameworks/Find/src/FFWindowController.mm @@ -1119,6 +1119,11 @@ Any other string: } - (void)didSingleClickFindAllResults:(id)sender +{ + // This is implicitly handled by outlineViewSelectionDidChange: +} + +- (void)outlineViewSelectionDidChange:(NSNotification*)aNotification { if([findAllResultsOutlineView numberOfSelectedRows] == 1) { @@ -1128,11 +1133,6 @@ Any other string: } } -- (void)outlineViewSelectionDidChange:(NSNotification*)aNotification -{ - [self didSingleClickFindAllResults:self]; -} - - (BOOL)commitEditing { id oldResponder = [[self window] firstResponder];