From ded37a128c44145072ee4e9579e1b355d0052a11 Mon Sep 17 00:00:00 2001
From: Allan Odgaard <git@abetarda.com>
Date: Wed, 1 May 2013 10:03:51 +0700
Subject: [PATCH] =?UTF-8?q?Add=20link=20arrows=20to=20Preferences=20?=
 =?UTF-8?q?=E2=86=92=20Bundles?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This takes the user to the bundle’s home (generally a GitHub page) which should make it easier to clone the source repository or report issues via the bundle’s issue tracker.
---
 .../English.lproj/BundlesPreferences.xib      | 131 +++++++++++++++---
 .../Preferences/src/BundlesPreferences.h      |   1 +
 .../Preferences/src/BundlesPreferences.mm     |   8 ++
 3 files changed, 120 insertions(+), 20 deletions(-)

diff --git a/Frameworks/Preferences/resources/English.lproj/BundlesPreferences.xib b/Frameworks/Preferences/resources/English.lproj/BundlesPreferences.xib
index 6ac5d2a7..4b7fd775 100644
--- a/Frameworks/Preferences/resources/English.lproj/BundlesPreferences.xib
+++ b/Frameworks/Preferences/resources/English.lproj/BundlesPreferences.xib
@@ -110,17 +110,20 @@
 									<object class="NSTableView" id="872489274">
 										<reference key="NSNextResponder" ref="1070777099"/>
 										<int key="NSvFlags">256</int>
-										<string key="NSFrameSize">{438, 165}</string>
+										<object class="NSMutableArray" key="NSSubviews">
+											<bool key="EncodedWithXMLCoder">YES</bool>
+										</object>
+										<string key="NSFrameSize">{439, 165}</string>
 										<reference key="NSSuperview" ref="1070777099"/>
 										<reference key="NSWindow"/>
-										<reference key="NSNextKeyView" ref="194902321"/>
+										<reference key="NSNextKeyView" ref="509710393"/>
 										<bool key="NSEnabled">YES</bool>
 										<bool key="NSAllowsLogicalLayoutDirection">NO</bool>
 										<bool key="NSControlAllowsExpansionToolTips">YES</bool>
 										<object class="NSTableHeaderView" key="NSHeaderView" id="522392350">
 											<reference key="NSNextResponder" ref="58869742"/>
 											<int key="NSvFlags">256</int>
-											<string key="NSFrameSize">{438, 17}</string>
+											<string key="NSFrameSize">{439, 17}</string>
 											<reference key="NSSuperview" ref="58869742"/>
 											<reference key="NSWindow"/>
 											<reference key="NSNextKeyView" ref="1070777099"/>
@@ -183,7 +186,7 @@
 											</object>
 											<object class="NSTableColumn" id="394696490">
 												<string key="NSIdentifier">name</string>
-												<double key="NSWidth">200</double>
+												<double key="NSWidth">128</double>
 												<double key="NSMinWidth">40</double>
 												<double key="NSMaxWidth">1000</double>
 												<object class="NSTableHeaderCell" key="NSHeaderCell">
@@ -212,15 +215,15 @@
 												<bool key="NSIsResizeable">YES</bool>
 												<reference key="NSTableView" ref="872489274"/>
 											</object>
-											<object class="NSTableColumn" id="1060157466">
-												<string key="NSIdentifier">date</string>
-												<double key="NSWidth">100</double>
-												<double key="NSMinWidth">10</double>
-												<double key="NSMaxWidth">3.4028234663852886e+38</double>
+											<object class="NSTableColumn" id="962336456">
+												<string key="NSIdentifier">link</string>
+												<double key="NSWidth">16</double>
+												<double key="NSMinWidth">16</double>
+												<double key="NSMaxWidth">16</double>
 												<object class="NSTableHeaderCell" key="NSHeaderCell">
 													<int key="NSCellFlags">75497536</int>
 													<int key="NSCellFlags2">2048</int>
-													<string key="NSContents">Updated</string>
+													<string key="NSContents"/>
 													<reference key="NSSupport" ref="26"/>
 													<object class="NSColor" key="NSBackgroundColor" id="15636082">
 														<int key="NSColorSpace">6</int>
@@ -233,6 +236,46 @@
 													</object>
 													<reference key="NSTextColor" ref="505101241"/>
 												</object>
+												<object class="NSButtonCell" key="NSDataCell" id="643723585">
+													<int key="NSCellFlags">67108864</int>
+													<int key="NSCellFlags2">134217728</int>
+													<string key="NSContents"/>
+													<object class="NSFont" key="NSSupport">
+														<string key="NSName">LucidaGrande-Bold</string>
+														<double key="NSSize">11</double>
+														<int key="NSfFlags">3357</int>
+													</object>
+													<string key="NSCellIdentifier">_NS:9</string>
+													<reference key="NSControlView" ref="872489274"/>
+													<int key="NSButtonFlags">138952704</int>
+													<int key="NSButtonFlags2">39</int>
+													<object class="NSCustomResource" key="NSNormalImage">
+														<string key="NSClassName">NSImage</string>
+														<string key="NSResourceName">NSFollowLinkFreestandingTemplate</string>
+													</object>
+													<string key="NSAlternateContents"/>
+													<string key="NSKeyEquivalent"/>
+													<int key="NSPeriodicDelay">200</int>
+													<int key="NSPeriodicInterval">25</int>
+												</object>
+												<int key="NSResizingMask">3</int>
+												<bool key="NSIsResizeable">YES</bool>
+												<bool key="NSIsEditable">YES</bool>
+												<reference key="NSTableView" ref="872489274"/>
+											</object>
+											<object class="NSTableColumn" id="1060157466">
+												<string key="NSIdentifier">date</string>
+												<double key="NSWidth">100</double>
+												<double key="NSMinWidth">100</double>
+												<double key="NSMaxWidth">100</double>
+												<object class="NSTableHeaderCell" key="NSHeaderCell">
+													<int key="NSCellFlags">75497536</int>
+													<int key="NSCellFlags2">2048</int>
+													<string key="NSContents">Updated</string>
+													<reference key="NSSupport" ref="26"/>
+													<reference key="NSBackgroundColor" ref="15636082"/>
+													<reference key="NSTextColor" ref="505101241"/>
+												</object>
 												<object class="NSTextFieldCell" key="NSDataCell" id="976513516">
 													<int key="NSCellFlags">337641536</int>
 													<int key="NSCellFlags2">2048</int>
@@ -249,7 +292,7 @@
 											</object>
 											<object class="NSTableColumn" id="592763632">
 												<string key="NSIdentifier">description</string>
-												<double key="NSWidth">110</double>
+												<double key="NSWidth">164</double>
 												<double key="NSMinWidth">10</double>
 												<double key="NSMaxWidth">3.4028234663852886e+38</double>
 												<object class="NSTableHeaderCell" key="NSHeaderCell">
@@ -313,7 +356,7 @@
 								<string key="NSFrame">{{424, 17}, {15, 175}}</string>
 								<reference key="NSSuperview" ref="10756270"/>
 								<reference key="NSWindow"/>
-								<reference key="NSNextKeyView" ref="509710393"/>
+								<reference key="NSNextKeyView" ref="593847072"/>
 								<bool key="NSAllowsLogicalLayoutDirection">NO</bool>
 								<reference key="NSTarget" ref="10756270"/>
 								<string key="NSAction">_doScroller:</string>
@@ -321,16 +364,17 @@
 							</object>
 							<object class="NSScroller" id="509710393">
 								<reference key="NSNextResponder" ref="10756270"/>
-								<int key="NSvFlags">-2147483392</int>
-								<string key="NSFrame">{{1, 192}, {438, 15}}</string>
+								<int key="NSvFlags">256</int>
+								<string key="NSFrame">{{1, 166}, {438, 16}}</string>
 								<reference key="NSSuperview" ref="10756270"/>
 								<reference key="NSWindow"/>
-								<reference key="NSNextKeyView" ref="593847072"/>
+								<reference key="NSNextKeyView" ref="194902321"/>
+								<bool key="NSEnabled">YES</bool>
 								<bool key="NSAllowsLogicalLayoutDirection">NO</bool>
 								<int key="NSsFlags">1</int>
 								<reference key="NSTarget" ref="10756270"/>
 								<string key="NSAction">_doScroller:</string>
-								<double key="NSPercent">0.82954545454545459</double>
+								<double key="NSPercent">0.99772209567198178</double>
 							</object>
 							<object class="NSClipView" id="58869742">
 								<reference key="NSNextResponder" ref="10756270"/>
@@ -352,7 +396,7 @@
 						<reference key="NSSuperview" ref="1005"/>
 						<reference key="NSWindow"/>
 						<reference key="NSNextKeyView" ref="58869742"/>
-						<int key="NSsFlags">133682</int>
+						<int key="NSsFlags">133810</int>
 						<reference key="NSVScroller" ref="194902321"/>
 						<reference key="NSHScroller" ref="509710393"/>
 						<reference key="NSContentView" ref="1070777099"/>
@@ -414,6 +458,14 @@
 					</object>
 					<int key="connectionID">35</int>
 				</object>
+				<object class="IBConnectionRecord">
+					<object class="IBActionConnection" key="connection">
+						<string key="label">didClickBundleLink:</string>
+						<reference key="source" ref="1001"/>
+						<reference key="destination" ref="643723585"/>
+					</object>
+					<int key="connectionID">72</int>
+				</object>
 				<object class="IBConnectionRecord">
 					<object class="IBOutletConnection" key="connection">
 						<string key="label">dataSource</string>
@@ -601,6 +653,7 @@
 							<reference ref="394696490"/>
 							<reference ref="1060157466"/>
 							<reference ref="592763632"/>
+							<reference ref="962336456"/>
 						</object>
 						<reference key="parent" ref="10756270"/>
 					</object>
@@ -690,6 +743,20 @@
 						<reference key="object" ref="678243497"/>
 						<reference key="parent" ref="1005"/>
 					</object>
+					<object class="IBObjectRecord">
+						<int key="objectID">48</int>
+						<reference key="object" ref="962336456"/>
+						<object class="NSMutableArray" key="children">
+							<bool key="EncodedWithXMLCoder">YES</bool>
+							<reference ref="643723585"/>
+						</object>
+						<reference key="parent" ref="872489274"/>
+					</object>
+					<object class="IBObjectRecord">
+						<int key="objectID">71</int>
+						<reference key="object" ref="643723585"/>
+						<reference key="parent" ref="962336456"/>
+					</object>
 				</object>
 			</object>
 			<object class="NSMutableDictionary" key="flattenedProperties">
@@ -712,9 +779,11 @@
 					<string>32.IBPluginDependency</string>
 					<string>33.IBPluginDependency</string>
 					<string>4.IBPluginDependency</string>
+					<string>48.IBPluginDependency</string>
 					<string>5.IBPluginDependency</string>
 					<string>6.IBPluginDependency</string>
 					<string>7.IBPluginDependency</string>
+					<string>71.IBPluginDependency</string>
 					<string>8.IBPluginDependency</string>
 					<string>9.IBPluginDependency</string>
 				</object>
@@ -741,6 +810,8 @@
 					<string>com.apple.InterfaceBuilder.CocoaPlugin</string>
 					<string>com.apple.InterfaceBuilder.CocoaPlugin</string>
 					<string>com.apple.InterfaceBuilder.CocoaPlugin</string>
+					<string>com.apple.InterfaceBuilder.CocoaPlugin</string>
+					<string>com.apple.InterfaceBuilder.CocoaPlugin</string>
 				</object>
 			</object>
 			<object class="NSMutableDictionary" key="unlocalizedProperties">
@@ -755,7 +826,7 @@
 				<reference key="dict.values" ref="0"/>
 			</object>
 			<nil key="sourceID"/>
-			<int key="maxID">47</int>
+			<int key="maxID">72</int>
 		</object>
 		<object class="IBClassDescriber" key="IBDocument.Classes">
 			<object class="NSMutableArray" key="referencedPartialClassDescriptions">
@@ -763,6 +834,17 @@
 				<object class="IBPartialClassDescription">
 					<string key="className">BundlesPreferences</string>
 					<string key="superclassName">NSViewController</string>
+					<object class="NSMutableDictionary" key="actions">
+						<string key="NS.key.0">didClickBundleLink:</string>
+						<string key="NS.object.0">id</string>
+					</object>
+					<object class="NSMutableDictionary" key="actionInfosByName">
+						<string key="NS.key.0">didClickBundleLink:</string>
+						<object class="IBActionInfo" key="NS.object.0">
+							<string key="name">didClickBundleLink:</string>
+							<string key="candidateClassName">id</string>
+						</object>
+					</object>
 					<object class="NSMutableDictionary" key="outlets">
 						<bool key="EncodedWithXMLCoder">YES</bool>
 						<object class="NSArray" key="dict.sortedKeys">
@@ -841,8 +923,17 @@
 		<bool key="IBDocument.PluginDeclaredDependenciesTrackSystemTargetVersion">YES</bool>
 		<int key="IBDocument.defaultPropertyAccessControl">3</int>
 		<object class="NSMutableDictionary" key="IBDocument.LastKnownImageSizes">
-			<string key="NS.key.0">NSSwitch</string>
-			<string key="NS.object.0">{15, 15}</string>
+			<bool key="EncodedWithXMLCoder">YES</bool>
+			<object class="NSArray" key="dict.sortedKeys">
+				<bool key="EncodedWithXMLCoder">YES</bool>
+				<string>NSFollowLinkFreestandingTemplate</string>
+				<string>NSSwitch</string>
+			</object>
+			<object class="NSArray" key="dict.values">
+				<bool key="EncodedWithXMLCoder">YES</bool>
+				<string>{10, 10}</string>
+				<string>{15, 15}</string>
+			</object>
 		</object>
 	</data>
 </archive>
diff --git a/Frameworks/Preferences/src/BundlesPreferences.h b/Frameworks/Preferences/src/BundlesPreferences.h
index 3b8c4000..d4c2c95b 100644
--- a/Frameworks/Preferences/src/BundlesPreferences.h
+++ b/Frameworks/Preferences/src/BundlesPreferences.h
@@ -17,4 +17,5 @@
 @property (nonatomic, readonly) NSString* identifier;
 @property (nonatomic, readonly) NSImage*  toolbarItemImage;
 @property (nonatomic, readonly) NSString* toolbarItemLabel;
+- (IBAction)didClickBundleLink:(id)sender;
 @end
diff --git a/Frameworks/Preferences/src/BundlesPreferences.mm b/Frameworks/Preferences/src/BundlesPreferences.mm
index 44268b35..05c82bad 100644
--- a/Frameworks/Preferences/src/BundlesPreferences.mm
+++ b/Frameworks/Preferences/src/BundlesPreferences.mm
@@ -205,4 +205,12 @@ static std::string textify (std::string str)
 		else	[_bundlesManager uninstallBundle:bundle];
 	}
 }
+
+- (IBAction)didClickBundleLink:(NSTableView*)aTableView
+{
+	NSInteger rowIndex = [aTableView clickedRow];
+	bundles_db::bundle_ptr bundle = bundles[rowIndex];
+	if(bundle->html_url() != NULL_STR)
+		[[NSWorkspace sharedWorkspace] openURL:[NSURL URLWithString:[NSString stringWithCxxString:bundle->html_url()]]];
+}
 @end