github/textmate
1
1
Fork 0
mirror of https://github.com/textmate/textmate.git synced 2026-04-28 03:00:34 -04:00
Code Issues Packages Projects Releases Wiki Activity

Remove custom NSCell subclass used for file browser’s folder pop-up

Browse Source 
The purpose was to render text with a shadow and fade the text when the window is inactive, but the former has not been used since 10.10 and the latter doesn’t actually seem to work.
This commit is contained in:
Allan Odgaard
2018-10-30 21:22:13 +07:00
parent 392c1ae954
commit fa5e3cf869
1 changed files with 1 additions and 72 deletions
Download Patch File Download Diff File Expand all files Collapse all files

73
Frameworks/FileBrowser/src/OFB/OFBHeaderView.mm
View File

@@ -15,17 +15,10 @@ static NSButton* OakCreateImageButton (NSString* imageName)
return res;
}
@interface OFBHeaderViewPopupButtonCell : NSPopUpButtonCell
@property (nonatomic) NSDictionary* activeAttributes;
@property (nonatomic) NSDictionary* inactiveAttributes;
@end
static NSPopUpButton* OakCreateFolderPopUpButton ()
{
NSPopUpButton* res = [[NSPopUpButton alloc] initWithFrame:NSZeroRect pullsDown:YES];
OFBHeaderViewPopupButtonCell* cell = [[OFBHeaderViewPopupButtonCell alloc] initTextCell:@"" pullsDown:YES];
[res setCell:cell];
[cell setArrowPosition:NSPopUpArrowAtBottom];
[[res cell] setBackgroundStyle:NSBackgroundStyleRaised];
[res setContentCompressionResistancePriority:NSLayoutPriorityDefaultLow forOrientation:NSLayoutConstraintOrientationHorizontal];
[res setContentHuggingPriority:NSLayoutPriorityFittingSizeCompression forOrientation:NSLayoutConstraintOrientationHorizontal];
[res setContentHuggingPriority:NSLayoutPriorityDefaultLow forOrientation:NSLayoutConstraintOrientationVertical];
@@ -38,70 +31,6 @@ static NSPopUpButton* OakCreateFolderPopUpButton ()
@property (nonatomic) NSView* bottomDivider;
@end
@implementation OFBHeaderViewPopupButtonCell
- (id)initTextCell:(NSString*)title pullsDown:(BOOL)pullsDown
{
if(self = [super initTextCell:title pullsDown:pullsDown])
{
NSMutableParagraphStyle* parStyle = [NSMutableParagraphStyle new];
[parStyle setLineBreakMode:NSLineBreakByTruncatingMiddle];
// MAC_OS_X_VERSION_10_10
if(OAK_AVAILABLE(10, 10))
{
NSFont* font = [NSFont systemFontOfSize:12];
_activeAttributes = @{
NSParagraphStyleAttributeName: parStyle,
NSFontAttributeName: font,
NSForegroundColorAttributeName: [NSColor colorWithCalibratedWhite:0.2 alpha:1]
};
_inactiveAttributes = @{
NSParagraphStyleAttributeName: parStyle,
NSFontAttributeName: font,
NSForegroundColorAttributeName: [NSColor colorWithCalibratedWhite:0.5 alpha:1]
};
}
else
{
NSShadow* shadow = [NSShadow new];
[shadow setShadowColor:[NSColor colorWithCalibratedWhite:1 alpha:0.5]];
[shadow setShadowOffset:NSMakeSize(0, -1)];
[shadow setShadowBlurRadius:1];
NSFont* font = [NSFont boldSystemFontOfSize:12];
_activeAttributes = @{
NSParagraphStyleAttributeName: parStyle,
NSFontAttributeName: font,
NSForegroundColorAttributeName: [NSColor colorWithCalibratedWhite:0.2 alpha:1],
NSShadowAttributeName: shadow,
};
_inactiveAttributes = @{
NSParagraphStyleAttributeName: parStyle,
NSFontAttributeName: font,
NSForegroundColorAttributeName: [NSColor colorWithCalibratedWhite:0.5 alpha:1],
NSShadowAttributeName: shadow,
};
}
}
return self;
}
- (NSRect)drawTitle:(NSAttributedString*)title withFrame:(NSRect)frame inView:(NSView*)controlView
{
OFBHeaderView* headerView = (OFBHeaderView*)controlView.superview;
if(headerView.inTabBar)
{
NSDictionary* attrs = headerView.active ? _activeAttributes : _inactiveAttributes;
frame.origin.y += 1;
frame.size.height -= 1;
return [super drawTitle:[[NSAttributedString alloc] initWithString:title.string attributes:attrs] withFrame:frame inView:controlView];
}
return [super drawTitle:title withFrame:frame inView:controlView];
}
@end
@implementation OFBHeaderView
- (id)initWithFrame:(NSRect)aRect
{