Commit Graph

3448 Commits

Author SHA1 Message Date
Allan Odgaard
553e89ceb6 Update include statements and link declarations 2016-09-11 12:47:39 +02:00
Allan Odgaard
e38df4dbca Use start/finish times for animation instead of durations 2016-09-11 11:53:07 +02:00
Jacob Bandes-Storch
877eabb28c Tweaks to pop-out animation 2016-09-11 02:36:33 -07:00
Jacob Bandes-Storch
d16cd01f67 Minor visual tweaks to OakPasteboardSelector 2016-09-11 11:20:52 +02:00
Allan Odgaard
4a328a84e4 Restoring previous commit message now use project specific settings
Related to 8fd1e1088d
2016-09-11 11:03:40 +02:00
Allan Odgaard
2ef853d4ff Add crash report info for CFCharacterSetIsLongCharacterMember 2016-09-11 10:55:57 +02:00
Allan Odgaard
d4050ea44a Use symbolic name for NSF2FunctionKey 2016-09-11 09:18:25 +02:00
Allan Odgaard
da5fdd78a8 Remove document_t from OakDocumentView
This also updates the commit window to only use OakDocument API.

The bundle editor and document controller still require updating.
2016-09-11 08:49:32 +02:00
Allan Odgaard
ab80413f21 Move bundle editor’s instance variables to implementation file 2016-09-11 08:47:37 +02:00
Allan Odgaard
9f4ff49529 Change kBookmarkIdentifier → OakDocumentBookmarkIdentifier 2016-09-11 08:46:11 +02:00
Allan Odgaard
04def9dfd0 Add convenience constructor to OakDocument 2016-09-11 08:45:30 +02:00
Allan Odgaard
149dfd884d Prepare to drop cppDocument property 2016-09-11 08:45:12 +02:00
Allan Odgaard
ebf6ae9346 Rename document property to cppDocument as intermediate refactoring step 2016-09-11 08:43:46 +02:00
Allan Odgaard
cdcb5a4836 Use OakDocument API to load/close document
We sort of assume that OakDocumentView is only given documents which are already loaded.
2016-09-11 08:43:04 +02:00
Allan Odgaard
f2289039da Calling document_t::show/hide is now done by DocumentController
This is only done for LRU tracking so it sort of makes sense to move this outside the document view itself (e.g. commit window and bundle editor does not require any LRU tracking).
2016-09-11 08:42:20 +02:00
Allan Odgaard
1e6102fb6e Observe OakDocumentMarksDidChangeNotification instead of adding callback 2016-09-11 08:42:01 +02:00
Allan Odgaard
ec0be36078 Post OakDocumentMarksDidChangeNotification when changing marks
This is instead of posting the GVColumnDataSourceDidChange notification.
2016-09-11 08:40:55 +02:00
Allan Odgaard
b9f7d23283 Make all tabSize properties use NSUInteger as their type 2016-09-11 08:40:22 +02:00
Allan Odgaard
102f22e266 Rename property isMacroRecording → isRecordingMacro/recordingMacro 2016-09-11 08:38:27 +02:00
Allan Odgaard
91190cdf9f No need to have dealloc clear properties with weak storage 2016-09-11 08:36:52 +02:00
Allan Odgaard
76183d63dd Observe OakDocument for fileType, tabSize, and softTabs 2016-09-11 08:36:30 +02:00
Allan Odgaard
dae362060d Fix crash if symbol chooser was open when closing window
This was introduced in 50dabac467.
2016-09-11 08:34:46 +02:00
Allan Odgaard
b57cde0886 Improve implementation of document_view_t::has_marks
The previous version was proportional in time with number of marks, since it requested (a copy of) all the marks.
2016-09-11 08:33:07 +02:00
Allan Odgaard
8676827ede Support calling marks_t::prev when there are no marks 2016-09-11 08:32:58 +02:00
Allan Odgaard
358ce2f3fc Use new bookmark API from OakDocumentView 2016-09-11 08:32:36 +02:00
Allan Odgaard
f961b5a683 Treat nil as empty payload when setting a mark 2016-09-11 08:31:21 +02:00
Allan Odgaard
2ba9366669 Add API to enumerate all marks for a single line 2016-09-11 08:30:59 +02:00
Allan Odgaard
da847e71d0 Use OakDocument’s bookmark enumeration API to construct navigation mneu 2016-09-11 08:30:50 +02:00
Allan Odgaard
d252e262be Add API to enumerate all bookmarks 2016-09-11 08:29:09 +02:00
Allan Odgaard
654a3f8483 Let OakTextView be responsible for most bookmark actions
Actions such as next/previous bookmark and toggle current, rely on the caret/selection, so these should be handled by the text view.
2016-09-11 08:28:49 +02:00
Allan Odgaard
067f8014ff Let OakTextView be responsible for “current symbol”
Since this depends on the caret position/selection, it makes sense to place this with the text view.
2016-09-11 08:26:58 +02:00
Jacob Bandes-Storch
f7c11c2436 Update visual style of OakChooser matches 2016-09-11 07:46:09 +02:00
Jacob Bandes-Storch
b3e1e3bf0f Fix the Find window status bar font 2016-09-10 10:49:37 -07:00
Allan Odgaard
468f95cb45 Use OakDocument API for symbols menu 2016-09-10 12:56:03 +02:00
Allan Odgaard
2c925dd9be Let OakDocumentView go via OakDocument for a few properties 2016-09-10 12:55:57 +02:00
Allan Odgaard
63fd2e4f76 Rename instance variable document → cppDocument
This is just an intermediate step (until we get rid of document_t).
2016-09-10 12:54:47 +02:00
Jacob Bandes-Storch
73330e29db Highlight the selection again when it’s the only find result
This more closely matches the behavior of NSTextView.
2016-09-10 12:52:25 +02:00
Jacob Bandes-Storch
7c325ff90b Add “Check for Updates” to the app menu
Another common practice among Mac apps.
2016-09-10 02:11:35 -07:00
Jacob Bandes-Storch
e0a49637f9 Use yellow background and underline for project find results
This style is a de facto standard across a handful of popular Mac apps.
2016-09-10 10:18:21 +02:00
Jacob Bandes-Storch
7ec00a5bea Add “git config commit.gpgsign false” to SCM tests
This allows tests to pass even when a global .gitconfig has gpgsign=true.
2016-09-10 10:18:21 +02:00
Allan Odgaard
2bccfb9b58 Remove check to see if we have the NSUserNotification class (10.8) 2016-09-10 10:18:21 +02:00
Allan Odgaard
24f98894e7 Ignore folders when opening multiple items from file browser
Previously we would descend into the first selected folder, ignoring all other items selected. Now we ignore the folders, unless all items selected are folders, in that case, we descend into the first one.
2016-09-09 11:38:09 +02:00
Allan Odgaard
3e2fa79945 Use normal (small) buttons in bundle item chooser
This is so that we can see which one is actually the default one, as the textured button style does not have a special style for the default button.
2016-09-09 11:12:06 +02:00
Allan Odgaard
4c5d02a441 Holding option will now change the bundle item chooser’s default button 2016-09-09 11:08:43 +02:00
Allan Odgaard
01ced8ecf5 Order out last tool tip immediately when showing a new one
When holding e.g. ⌘G with no matches, we repeatedly create new tool tips and the queue with the “orderOut:” messages appear to not be handled until ⌘G is released, resulting in a lot of tool tips being created.
2016-09-09 05:32:19 +02:00
Allan Odgaard
eba19a8fe2 Let the bundle item chooser handle “option return to edit”
Previously using option return would only work for editing bundle items, not key binding files.
2016-09-09 05:32:19 +02:00
Ronald Wampler
0c71b54a9e Don't set our document with a default constructed document_ptr
This was never necessary since our documentView will set this to
document_ptr() when it's released, though it was harmless. But now,
document_ptr is just a thin wrapper around OakDocument and the default
constructor does nothing. As a result we were basically setting the
text view OakDocument instance to nil.

After commit f9e02d9, when the commit window closes, this would
noticeably cause the text view to turn "white" when using a dark theme.
2016-09-09 05:32:19 +02:00
Allan Odgaard
7a89742f6d Handle most/all movement keys for snippet pop-up menu 2016-09-08 20:14:08 +02:00
Allan Odgaard
db99892a96 Use our OakAppKit support for translating actions to table view movement 2016-09-08 20:14:08 +02:00
Allan Odgaard
ed3c8b7ab0 Use our OakAppKit support for translating actions to table view movement 2016-09-08 20:14:08 +02:00