diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index e8fb08c21..f2bb17612 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -5,7 +5,7 @@ This document provides guidance on how to contribute to **TFHE-rs**. There are two ways to contribute: - **Report issues:** Open issues on GitHub to report bugs, suggest improvements, or note typos. -- **Submit codes**: To become an official contributor, you must sign our Contributor License Agreement (CLA). Our CLA-bot will guide you through this process when you open your first pull request. +- **Submit code**: To become an official contributor, you must sign our Contributor License Agreement (CLA). Our CLA-bot will guide you through this process when you open your first pull request. ## 1. Setting up the project diff --git a/implementation_notes/tfhe-ntt/gh_issue_2037_barrett_range.md b/implementation_notes/tfhe-ntt/gh_issue_2037_barrett_range.md index 03339622c..2008ed2cb 100644 --- a/implementation_notes/tfhe-ntt/gh_issue_2037_barrett_range.md +++ b/implementation_notes/tfhe-ntt/gh_issue_2037_barrett_range.md @@ -26,7 +26,7 @@ $$ Note that $q = \lfloor \frac{v}{p} \rfloor$. -The Barret reduction algorithm is explained and analyzed in this blog post: https://blog.zksecurity.xyz/posts/barrett-tighter-bound/ a major distinction to note is that the blog-post derives functions word-wise meaning that $b = 2^{32}$ or $2^{64}$. `tfhe-ntt` code is writtent in terms of bits so $b = 2$. +The Barrett reduction algorithm is explained and analyzed in this blog post: https://blog.zksecurity.xyz/posts/barrett-tighter-bound/ a major distinction to note is that the blog-post derives functions word-wise meaning that $b = 2^{32}$ or $2^{64}$. `tfhe-ntt` code is written in terms of bits so $b = 2$. The `tfhe-ntt` code uses the Barrett reduction algorithm to compute a good first approximation $q_{barrett}$ of the quotient $q$ of the division of a given value $v$ by $p$. This in turns allows to compute a first approximation $r_{barrett}$ of $r$: diff --git a/tfhe/src/error.rs b/tfhe/src/error.rs index 9a3fe287c..31cba7ee9 100644 --- a/tfhe/src/error.rs +++ b/tfhe/src/error.rs @@ -3,7 +3,7 @@ use std::fmt::{Debug, Display, Formatter}; #[derive(Debug, Clone, Eq, PartialEq)] pub enum ErrorKind { Message(String), - /// The provide range for a slicing operation was invalid + /// The provided range for a slicing operation was invalid InvalidRange(InvalidRangeError), /// The zero knowledge proof and the content it is supposed to prove /// failed to correctly prove