From 5b574706520bc1731911a8644533e84f8490cd7d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Test=C3=A9?= Date: Tue, 22 Apr 2025 12:00:02 +0200 Subject: [PATCH] chore(ci): fix slack notify in case of cancelled step If a step is cancelled, it is not considered as failure by GitHub. So if a user cancelled a task or if a job timed out, then no Slack notification was sent and devs weren't able to track down these events. --- .github/workflows/aws_tfhe_backward_compat_tests.yml | 2 +- .github/workflows/aws_tfhe_fast_tests.yml | 2 +- .github/workflows/aws_tfhe_integer_tests.yml | 2 +- .github/workflows/aws_tfhe_signed_integer_tests.yml | 2 +- .github/workflows/aws_tfhe_tests.yml | 2 +- .github/workflows/aws_tfhe_wasm_tests.yml | 2 +- .github/workflows/benchmark_boolean.yml | 2 +- .github/workflows/benchmark_core_crypto.yml | 2 +- .github/workflows/benchmark_erc20.yml | 2 +- .github/workflows/benchmark_gpu_4090.yml | 4 ++-- .github/workflows/benchmark_integer.yml | 2 +- .github/workflows/benchmark_shortint.yml | 2 +- .github/workflows/benchmark_signed_integer.yml | 2 +- .github/workflows/benchmark_tfhe_fft.yml | 2 +- .github/workflows/benchmark_tfhe_ntt.yml | 2 +- .github/workflows/benchmark_tfhe_zk_pok.yml | 2 +- .github/workflows/benchmark_wasm_client.yml | 2 +- .github/workflows/benchmark_zk_pke.yml | 2 +- .github/workflows/code_coverage.yml | 2 +- .github/workflows/csprng_randomness_tests.yml | 2 +- .github/workflows/gpu_4090_tests.yml | 2 +- .github/workflows/integer_long_run_tests.yml | 2 +- .github/workflows/make_release.yml | 2 +- .github/workflows/make_release_cuda.yml | 2 +- .github/workflows/make_release_tfhe_csprng.yml | 2 +- .github/workflows/make_release_tfhe_fft.yml | 2 +- .github/workflows/make_release_tfhe_ntt.yml | 2 +- .github/workflows/make_release_tfhe_versionable.yml | 4 ++-- .github/workflows/make_release_zk_pok.yml | 2 +- 29 files changed, 31 insertions(+), 31 deletions(-) diff --git a/.github/workflows/aws_tfhe_backward_compat_tests.yml b/.github/workflows/aws_tfhe_backward_compat_tests.yml index 523e9e7bd..ed5d0fb70 100644 --- a/.github/workflows/aws_tfhe_backward_compat_tests.yml +++ b/.github/workflows/aws_tfhe_backward_compat_tests.yml @@ -124,7 +124,7 @@ jobs: echo "PULL_REQUEST_MD_LINK=[pull-request](${{ vars.PR_BASE_URL }}${{ github.event.pull_request.number }}), " >> "${GITHUB_ENV}" - name: Slack Notification - if: ${{ failure() }} + if: ${{ failure() || (cancelled() && github.event_name != 'pull_request') }} continue-on-error: true uses: rtCamp/action-slack-notify@e31e87e03dd19038e411e38ae27cbad084a90661 env: diff --git a/.github/workflows/aws_tfhe_fast_tests.yml b/.github/workflows/aws_tfhe_fast_tests.yml index d23a25b7f..2faa2ee3b 100644 --- a/.github/workflows/aws_tfhe_fast_tests.yml +++ b/.github/workflows/aws_tfhe_fast_tests.yml @@ -297,7 +297,7 @@ jobs: label: ${{ needs.setup-instance.outputs.runner-name }} - name: Slack Notification - if: ${{ failure() }} + if: ${{ failure() || (cancelled() && github.event_name != 'pull_request') }} continue-on-error: true uses: rtCamp/action-slack-notify@e31e87e03dd19038e411e38ae27cbad084a90661 env: diff --git a/.github/workflows/aws_tfhe_integer_tests.yml b/.github/workflows/aws_tfhe_integer_tests.yml index 8fec1d9e4..5e2841654 100644 --- a/.github/workflows/aws_tfhe_integer_tests.yml +++ b/.github/workflows/aws_tfhe_integer_tests.yml @@ -142,7 +142,7 @@ jobs: echo "PULL_REQUEST_MD_LINK=[pull-request](${{ vars.PR_BASE_URL }}${{ github.event.pull_request.number }}), " >> "${GITHUB_ENV}" - name: Slack Notification - if: ${{ failure() }} + if: ${{ failure() || (cancelled() && github.event_name != 'pull_request') }} continue-on-error: true uses: rtCamp/action-slack-notify@e31e87e03dd19038e411e38ae27cbad084a90661 env: diff --git a/.github/workflows/aws_tfhe_signed_integer_tests.yml b/.github/workflows/aws_tfhe_signed_integer_tests.yml index 16ec6ac84..1ea5f10e7 100644 --- a/.github/workflows/aws_tfhe_signed_integer_tests.yml +++ b/.github/workflows/aws_tfhe_signed_integer_tests.yml @@ -147,7 +147,7 @@ jobs: echo "PULL_REQUEST_MD_LINK=[pull-request](${{ vars.PR_BASE_URL }}${{ github.event.pull_request.number }}), " >> "${GITHUB_ENV}" - name: Slack Notification - if: ${{ failure() }} + if: ${{ failure() || (cancelled() && github.event_name != 'pull_request') }} continue-on-error: true uses: rtCamp/action-slack-notify@e31e87e03dd19038e411e38ae27cbad084a90661 env: diff --git a/.github/workflows/aws_tfhe_tests.yml b/.github/workflows/aws_tfhe_tests.yml index 7a51750d5..e19103794 100644 --- a/.github/workflows/aws_tfhe_tests.yml +++ b/.github/workflows/aws_tfhe_tests.yml @@ -254,7 +254,7 @@ jobs: echo "PULL_REQUEST_MD_LINK=[pull-request](${{ vars.PR_BASE_URL }}${{ github.event.pull_request.number }}), " >> "${GITHUB_ENV}" - name: Slack Notification - if: ${{ failure() }} + if: ${{ failure() || (cancelled() && github.event_name != 'pull_request') }} continue-on-error: true uses: rtCamp/action-slack-notify@e31e87e03dd19038e411e38ae27cbad084a90661 env: diff --git a/.github/workflows/aws_tfhe_wasm_tests.yml b/.github/workflows/aws_tfhe_wasm_tests.yml index fa6441be1..6a1ddc21c 100644 --- a/.github/workflows/aws_tfhe_wasm_tests.yml +++ b/.github/workflows/aws_tfhe_wasm_tests.yml @@ -123,7 +123,7 @@ jobs: echo "PULL_REQUEST_MD_LINK=[pull-request](${{ vars.PR_BASE_URL }}${{ github.event.pull_request.number }}), " >> "${GITHUB_ENV}" - name: Slack Notification - if: ${{ failure() }} + if: ${{ failure() || (cancelled() && github.event_name != 'pull_request') }} continue-on-error: true uses: rtCamp/action-slack-notify@e31e87e03dd19038e411e38ae27cbad084a90661 env: diff --git a/.github/workflows/benchmark_boolean.yml b/.github/workflows/benchmark_boolean.yml index c43cc84b6..b3ce54afb 100644 --- a/.github/workflows/benchmark_boolean.yml +++ b/.github/workflows/benchmark_boolean.yml @@ -114,7 +114,7 @@ jobs: --slab-url "${{ secrets.SLAB_URL }}" - name: Slack Notification - if: ${{ failure() }} + if: ${{ failure() || (cancelled() && github.event_name != 'pull_request') }} continue-on-error: true uses: rtCamp/action-slack-notify@e31e87e03dd19038e411e38ae27cbad084a90661 env: diff --git a/.github/workflows/benchmark_core_crypto.yml b/.github/workflows/benchmark_core_crypto.yml index bcb1ca8c4..95c437e38 100644 --- a/.github/workflows/benchmark_core_crypto.yml +++ b/.github/workflows/benchmark_core_crypto.yml @@ -106,7 +106,7 @@ jobs: --slab-url "${{ secrets.SLAB_URL }}" - name: Slack Notification - if: ${{ failure() }} + if: ${{ failure() || (cancelled() && github.event_name != 'pull_request') }} continue-on-error: true uses: rtCamp/action-slack-notify@e31e87e03dd19038e411e38ae27cbad084a90661 env: diff --git a/.github/workflows/benchmark_erc20.yml b/.github/workflows/benchmark_erc20.yml index 5f699989f..a940416cb 100644 --- a/.github/workflows/benchmark_erc20.yml +++ b/.github/workflows/benchmark_erc20.yml @@ -111,7 +111,7 @@ jobs: --slab-url "${{ secrets.SLAB_URL }}" - name: Slack Notification - if: ${{ failure() }} + if: ${{ failure() || (cancelled() && github.event_name != 'pull_request') }} continue-on-error: true uses: rtCamp/action-slack-notify@e31e87e03dd19038e411e38ae27cbad084a90661 env: diff --git a/.github/workflows/benchmark_gpu_4090.yml b/.github/workflows/benchmark_gpu_4090.yml index 026134a00..a16dcffaa 100644 --- a/.github/workflows/benchmark_gpu_4090.yml +++ b/.github/workflows/benchmark_gpu_4090.yml @@ -92,7 +92,7 @@ jobs: --slab-url "${{ secrets.SLAB_URL }}" - name: Slack Notification - if: ${{ failure() }} + if: ${{ failure() || (cancelled() && github.event_name != 'pull_request') }} continue-on-error: true uses: rtCamp/action-slack-notify@e31e87e03dd19038e411e38ae27cbad084a90661 env: @@ -177,7 +177,7 @@ jobs: ${{ secrets.SLAB_URL }} - name: Slack Notification - if: ${{ failure() }} + if: ${{ failure() || (cancelled() && github.event_name != 'pull_request') }} continue-on-error: true uses: rtCamp/action-slack-notify@e31e87e03dd19038e411e38ae27cbad084a90661 env: diff --git a/.github/workflows/benchmark_integer.yml b/.github/workflows/benchmark_integer.yml index a696e9998..fdd8f17e9 100644 --- a/.github/workflows/benchmark_integer.yml +++ b/.github/workflows/benchmark_integer.yml @@ -184,7 +184,7 @@ jobs: --slab-url "${{ secrets.SLAB_URL }}" - name: Slack Notification - if: ${{ failure() }} + if: ${{ failure() || (cancelled() && github.event_name != 'pull_request') }} continue-on-error: true uses: rtCamp/action-slack-notify@e31e87e03dd19038e411e38ae27cbad084a90661 env: diff --git a/.github/workflows/benchmark_shortint.yml b/.github/workflows/benchmark_shortint.yml index cb42f6238..bbb4bddc2 100644 --- a/.github/workflows/benchmark_shortint.yml +++ b/.github/workflows/benchmark_shortint.yml @@ -150,7 +150,7 @@ jobs: --slab-url "${{ secrets.SLAB_URL }}" - name: Slack Notification - if: ${{ failure() }} + if: ${{ failure() || (cancelled() && github.event_name != 'pull_request') }} continue-on-error: true uses: rtCamp/action-slack-notify@e31e87e03dd19038e411e38ae27cbad084a90661 env: diff --git a/.github/workflows/benchmark_signed_integer.yml b/.github/workflows/benchmark_signed_integer.yml index 6c687fd34..813a2509f 100644 --- a/.github/workflows/benchmark_signed_integer.yml +++ b/.github/workflows/benchmark_signed_integer.yml @@ -178,7 +178,7 @@ jobs: --slab-url "${{ secrets.SLAB_URL }}" - name: Slack Notification - if: ${{ failure() }} + if: ${{ failure() || (cancelled() && github.event_name != 'pull_request') }} continue-on-error: true uses: rtCamp/action-slack-notify@e31e87e03dd19038e411e38ae27cbad084a90661 env: diff --git a/.github/workflows/benchmark_tfhe_fft.yml b/.github/workflows/benchmark_tfhe_fft.yml index e806759f8..afed36434 100644 --- a/.github/workflows/benchmark_tfhe_fft.yml +++ b/.github/workflows/benchmark_tfhe_fft.yml @@ -112,7 +112,7 @@ jobs: ${{ secrets.SLAB_URL }} - name: Slack Notification - if: ${{ failure() }} + if: ${{ failure() || (cancelled() && github.event_name != 'pull_request') }} continue-on-error: true uses: rtCamp/action-slack-notify@e31e87e03dd19038e411e38ae27cbad084a90661 env: diff --git a/.github/workflows/benchmark_tfhe_ntt.yml b/.github/workflows/benchmark_tfhe_ntt.yml index ca0ae34cc..badaab2d2 100644 --- a/.github/workflows/benchmark_tfhe_ntt.yml +++ b/.github/workflows/benchmark_tfhe_ntt.yml @@ -112,7 +112,7 @@ jobs: ${{ secrets.SLAB_URL }} - name: Slack Notification - if: ${{ failure() }} + if: ${{ failure() || (cancelled() && github.event_name != 'pull_request') }} continue-on-error: true uses: rtCamp/action-slack-notify@e31e87e03dd19038e411e38ae27cbad084a90661 env: diff --git a/.github/workflows/benchmark_tfhe_zk_pok.yml b/.github/workflows/benchmark_tfhe_zk_pok.yml index 9c453efd9..db82b4a40 100644 --- a/.github/workflows/benchmark_tfhe_zk_pok.yml +++ b/.github/workflows/benchmark_tfhe_zk_pok.yml @@ -152,7 +152,7 @@ jobs: --slab-url "${{ secrets.SLAB_URL }}" - name: Slack Notification - if: ${{ failure() }} + if: ${{ failure() || (cancelled() && github.event_name != 'pull_request') }} continue-on-error: true uses: rtCamp/action-slack-notify@e31e87e03dd19038e411e38ae27cbad084a90661 env: diff --git a/.github/workflows/benchmark_wasm_client.yml b/.github/workflows/benchmark_wasm_client.yml index efc823992..027e82d78 100644 --- a/.github/workflows/benchmark_wasm_client.yml +++ b/.github/workflows/benchmark_wasm_client.yml @@ -187,7 +187,7 @@ jobs: --slab-url "${{ secrets.SLAB_URL }}" - name: Slack Notification - if: ${{ failure() }} + if: ${{ failure() || (cancelled() && github.event_name != 'pull_request') }} continue-on-error: true uses: rtCamp/action-slack-notify@e31e87e03dd19038e411e38ae27cbad084a90661 env: diff --git a/.github/workflows/benchmark_zk_pke.yml b/.github/workflows/benchmark_zk_pke.yml index 511ed494a..bb2579434 100644 --- a/.github/workflows/benchmark_zk_pke.yml +++ b/.github/workflows/benchmark_zk_pke.yml @@ -199,7 +199,7 @@ jobs: --slab-url "${{ secrets.SLAB_URL }}" - name: Slack Notification - if: ${{ failure() }} + if: ${{ failure() || (cancelled() && github.event_name != 'pull_request') }} continue-on-error: true uses: rtCamp/action-slack-notify@e31e87e03dd19038e411e38ae27cbad084a90661 env: diff --git a/.github/workflows/code_coverage.yml b/.github/workflows/code_coverage.yml index 39d868b63..20fa13861 100644 --- a/.github/workflows/code_coverage.yml +++ b/.github/workflows/code_coverage.yml @@ -106,7 +106,7 @@ jobs: files: integer/cobertura.xml - name: Slack Notification - if: ${{ failure() }} + if: ${{ failure() || (cancelled() && github.event_name != 'pull_request') }} continue-on-error: true uses: rtCamp/action-slack-notify@e31e87e03dd19038e411e38ae27cbad084a90661 env: diff --git a/.github/workflows/csprng_randomness_tests.yml b/.github/workflows/csprng_randomness_tests.yml index df3ec46cc..0597cbb13 100644 --- a/.github/workflows/csprng_randomness_tests.yml +++ b/.github/workflows/csprng_randomness_tests.yml @@ -72,7 +72,7 @@ jobs: make dieharder_csprng - name: Slack Notification - if: ${{ failure() }} + if: ${{ failure() || (cancelled() && github.event_name != 'pull_request') }} continue-on-error: true uses: rtCamp/action-slack-notify@e31e87e03dd19038e411e38ae27cbad084a90661 env: diff --git a/.github/workflows/gpu_4090_tests.yml b/.github/workflows/gpu_4090_tests.yml index dc2a91fc2..67bf9dbe9 100644 --- a/.github/workflows/gpu_4090_tests.yml +++ b/.github/workflows/gpu_4090_tests.yml @@ -77,7 +77,7 @@ jobs: github_token: ${{ secrets.GITHUB_TOKEN }} - name: Slack Notification - if: ${{ failure() }} + if: ${{ failure() || (cancelled() && github.event_name != 'pull_request') }} continue-on-error: true uses: rtCamp/action-slack-notify@e31e87e03dd19038e411e38ae27cbad084a90661 env: diff --git a/.github/workflows/integer_long_run_tests.yml b/.github/workflows/integer_long_run_tests.yml index e5d0a66f3..a2805da3d 100644 --- a/.github/workflows/integer_long_run_tests.yml +++ b/.github/workflows/integer_long_run_tests.yml @@ -63,7 +63,7 @@ jobs: make test_integer_long_run - name: Slack Notification - if: ${{ failure() }} + if: ${{ failure() || (cancelled() && github.event_name != 'pull_request') }} continue-on-error: true uses: rtCamp/action-slack-notify@e31e87e03dd19038e411e38ae27cbad084a90661 env: diff --git a/.github/workflows/make_release.yml b/.github/workflows/make_release.yml index 3a4b8cf8c..c2fd0f4d7 100644 --- a/.github/workflows/make_release.yml +++ b/.github/workflows/make_release.yml @@ -156,7 +156,7 @@ jobs: provenance: true - name: Slack Notification - if: ${{ failure() }} + if: ${{ failure() || (cancelled() && github.event_name != 'pull_request') }} continue-on-error: true uses: rtCamp/action-slack-notify@e31e87e03dd19038e411e38ae27cbad084a90661 # v2.3.3 env: diff --git a/.github/workflows/make_release_cuda.yml b/.github/workflows/make_release_cuda.yml index 4c2959dfa..e1c98b73e 100644 --- a/.github/workflows/make_release_cuda.yml +++ b/.github/workflows/make_release_cuda.yml @@ -176,7 +176,7 @@ jobs: SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }} - name: Slack Notification - if: ${{ failure() }} + if: ${{ failure() || (cancelled() && github.event_name != 'pull_request') }} continue-on-error: true uses: rtCamp/action-slack-notify@e31e87e03dd19038e411e38ae27cbad084a90661 # v2.3.3 env: diff --git a/.github/workflows/make_release_tfhe_csprng.yml b/.github/workflows/make_release_tfhe_csprng.yml index 13de55bab..d50068414 100644 --- a/.github/workflows/make_release_tfhe_csprng.yml +++ b/.github/workflows/make_release_tfhe_csprng.yml @@ -91,7 +91,7 @@ jobs: SLACK_USERNAME: ${{ secrets.BOT_USERNAME }} SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }} - name: Slack Notification - if: ${{ failure() }} + if: ${{ failure() || (cancelled() && github.event_name != 'pull_request') }} continue-on-error: true uses: rtCamp/action-slack-notify@e31e87e03dd19038e411e38ae27cbad084a90661 # v2.3.3 env: diff --git a/.github/workflows/make_release_tfhe_fft.yml b/.github/workflows/make_release_tfhe_fft.yml index 2e40619e3..a2027c9ad 100644 --- a/.github/workflows/make_release_tfhe_fft.yml +++ b/.github/workflows/make_release_tfhe_fft.yml @@ -91,7 +91,7 @@ jobs: SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }} - name: Slack Notification - if: ${{ failure() }} + if: ${{ failure() || (cancelled() && github.event_name != 'pull_request') }} continue-on-error: true uses: rtCamp/action-slack-notify@e31e87e03dd19038e411e38ae27cbad084a90661 # v2.3.3 env: diff --git a/.github/workflows/make_release_tfhe_ntt.yml b/.github/workflows/make_release_tfhe_ntt.yml index 476d2ca47..78049c824 100644 --- a/.github/workflows/make_release_tfhe_ntt.yml +++ b/.github/workflows/make_release_tfhe_ntt.yml @@ -90,7 +90,7 @@ jobs: SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }} - name: Slack Notification - if: ${{ failure() }} + if: ${{ failure() || (cancelled() && github.event_name != 'pull_request') }} continue-on-error: true uses: rtCamp/action-slack-notify@e31e87e03dd19038e411e38ae27cbad084a90661 # v2.3.3 env: diff --git a/.github/workflows/make_release_tfhe_versionable.yml b/.github/workflows/make_release_tfhe_versionable.yml index 641115fa9..b675ef11d 100644 --- a/.github/workflows/make_release_tfhe_versionable.yml +++ b/.github/workflows/make_release_tfhe_versionable.yml @@ -84,7 +84,7 @@ jobs: SLACK_COLOR: failure SLACK_MESSAGE: "SLSA tfhe-versionable-derive - hash comparison failure: (${{ env.ACTION_RUN_URL }})" - name: Slack Notification - if: ${{ failure() }} + if: ${{ failure() || (cancelled() && github.event_name != 'pull_request') }} continue-on-error: true uses: rtCamp/action-slack-notify@e31e87e03dd19038e411e38ae27cbad084a90661 # v2.3.3 env: @@ -157,7 +157,7 @@ jobs: SLACK_COLOR: failure SLACK_MESSAGE: "SLSA tfhe-versionable - hash comparison failure: (${{ env.ACTION_RUN_URL }})" - name: Slack Notification - if: ${{ failure() }} + if: ${{ failure() || (cancelled() && github.event_name != 'pull_request') }} continue-on-error: true uses: rtCamp/action-slack-notify@e31e87e03dd19038e411e38ae27cbad084a90661 # v2.3.3 env: diff --git a/.github/workflows/make_release_zk_pok.yml b/.github/workflows/make_release_zk_pok.yml index 8fe521355..28463251a 100644 --- a/.github/workflows/make_release_zk_pok.yml +++ b/.github/workflows/make_release_zk_pok.yml @@ -89,7 +89,7 @@ jobs: SLACK_USERNAME: ${{ secrets.BOT_USERNAME }} SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }} - name: Slack Notification - if: ${{ failure() }} + if: ${{ failure() || (cancelled() && github.event_name != 'pull_request') }} continue-on-error: true uses: rtCamp/action-slack-notify@e31e87e03dd19038e411e38ae27cbad084a90661 # v2.3.3 env: