From 87421e83076f2b882301ae4b21512e4924271960 Mon Sep 17 00:00:00 2001 From: Arthur Meyre Date: Tue, 17 Oct 2023 11:12:10 +0200 Subject: [PATCH] chore(ci): update M1 workflow to not explode the 6h GitHub limit - run doc tests for CI with LTO off following M1 investigation - LTO fat may be a cause of the wopbs flaky tests, disabling to check --- .github/workflows/aws_tfhe_fast_tests.yml | 2 +- .github/workflows/aws_tfhe_tests.yml | 2 +- .github/workflows/m1_tests.yml | 3 +-- scripts/integer-tests.sh | 6 ++++-- 4 files changed, 7 insertions(+), 6 deletions(-) diff --git a/.github/workflows/aws_tfhe_fast_tests.yml b/.github/workflows/aws_tfhe_fast_tests.yml index 871e4b002..29c7ea870 100644 --- a/.github/workflows/aws_tfhe_fast_tests.yml +++ b/.github/workflows/aws_tfhe_fast_tests.yml @@ -80,7 +80,7 @@ jobs: - name: Run user docs tests run: | - make test_user_doc + CARGO_PROFILE=release_lto_off make test_user_doc - name: Run js on wasm API tests run: | diff --git a/.github/workflows/aws_tfhe_tests.yml b/.github/workflows/aws_tfhe_tests.yml index 383f731ae..fa0a58e24 100644 --- a/.github/workflows/aws_tfhe_tests.yml +++ b/.github/workflows/aws_tfhe_tests.yml @@ -83,7 +83,7 @@ jobs: - name: Run user docs tests run: | - make test_user_doc + CARGO_PROFILE=release_lto_off make test_user_doc - name: Gen Keys if required run: | diff --git a/.github/workflows/m1_tests.yml b/.github/workflows/m1_tests.yml index 13cbc6cba..0f6a90406 100644 --- a/.github/workflows/m1_tests.yml +++ b/.github/workflows/m1_tests.yml @@ -15,7 +15,6 @@ env: CARGO_TERM_COLOR: always RUSTFLAGS: "-C target-cpu=native" ACTION_RUN_URL: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }} - CARGO_PROFILE: release_lto_off FAST_TESTS: "TRUE" concurrency: @@ -86,7 +85,7 @@ jobs: - name: Run user docs tests run: | - make test_user_doc + CARGO_PROFILE=release_lto_off make test_user_doc # JS tests are more easily launched in docker, we won't test that on M1 as docker is pretty # slow on Apple machines due to the virtualization layer. diff --git a/scripts/integer-tests.sh b/scripts/integer-tests.sh index 805b3482e..11695013f 100755 --- a/scripts/integer-tests.sh +++ b/scripts/integer-tests.sh @@ -17,6 +17,8 @@ RUST_TOOLCHAIN="+stable" multi_bit="" not_multi_bit="_multi_bit" cargo_profile="release" +# TODO: revert to release once the bug is properly fixed/identified +cargo_profile_doctests="release_lto_off" avx512_feature="" while [ -n "$1" ] @@ -119,7 +121,7 @@ and not test(/.*default_add_sequence_multi_thread_param_message_3_carry_3_ks_pbs if [[ "${multi_bit}" == "" ]]; then cargo "${RUST_TOOLCHAIN}" test \ - --profile "${cargo_profile}" \ + --profile "${cargo_profile_doctests}" \ --package tfhe \ --features="${ARCH_FEATURE}",integer,internal-keycache,"${avx512_feature}" \ --doc \ @@ -163,7 +165,7 @@ and not test(/.*default_add_sequence_multi_thread_param_message_3_carry_3_ks_pbs if [[ "${multi_bit}" == "" ]]; then cargo "${RUST_TOOLCHAIN}" test \ - --profile "${cargo_profile}" \ + --profile "${cargo_profile_doctests}" \ --package tfhe \ --features="${ARCH_FEATURE}",integer,internal-keycache,"${avx512_feature}" \ --doc \