From d88caff6dd9cc39c2936055f37b287bc5b8f4298 Mon Sep 17 00:00:00 2001 From: Nicolas Sarlin Date: Mon, 15 Sep 2025 13:52:42 +0200 Subject: [PATCH] fix(ci): fix serde root crate in tfhe-lints --- utils/tfhe-lints/Cargo.toml | 6 +++--- utils/tfhe-lints/src/serialize_without_versionize.rs | 8 ++++++-- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/utils/tfhe-lints/Cargo.toml b/utils/tfhe-lints/Cargo.toml index a2ea1d454..27d77e691 100644 --- a/utils/tfhe-lints/Cargo.toml +++ b/utils/tfhe-lints/Cargo.toml @@ -10,12 +10,12 @@ crate-type = ["cdylib"] [dependencies] clippy_utils = { git = "https://github.com/rust-lang/rust-clippy", rev = "334fb906aef13d20050987b13448f37391bb97a2" } -dylint_linting = "4.0.0" +dylint_linting = "4.1.0" [dev-dependencies] -dylint_testing = "4.0.0" +dylint_testing = "4.1.0" serde = { version = "1.0", features = ["derive"] } -tfhe-versionable = "0.4.0" +tfhe-versionable = "0.6.1" [package.metadata.rust-analyzer] rustc_private = true diff --git a/utils/tfhe-lints/src/serialize_without_versionize.rs b/utils/tfhe-lints/src/serialize_without_versionize.rs index d2600fda6..a720fba16 100644 --- a/utils/tfhe-lints/src/serialize_without_versionize.rs +++ b/utils/tfhe-lints/src/serialize_without_versionize.rs @@ -12,7 +12,9 @@ pub struct SerializeWithoutVersionizeInner { } const VERSIONIZE_TRAIT: [&str; 2] = ["tfhe_versionable", "Versionize"]; -const SERIALIZE_TRAIT: [&str; 3] = ["serde", "ser", "Serialize"]; +const SERIALIZE_TRAIT: [&str; 3] = ["serde_core", "ser", "Serialize"]; +// Serialize trait root definition has been moved from the serde crate to serde_core +const SERIALIZE_TRAIT_LEGACY: [&str; 3] = ["serde", "ser", "Serialize"]; const LINT_NAME: &str = "serialize_without_versionize"; impl SerializeWithoutVersionizeInner { @@ -86,7 +88,9 @@ impl<'tcx> LateLintPass<'tcx> for SerializeWithoutVersionize { // Check if the implemented trait is `Serialize` if let Some(def_id) = trait_ref.trait_def_id() { let path = cx.get_def_path(def_id); - if path == symbols_list_from_str(&SERIALIZE_TRAIT) { + if path == symbols_list_from_str(&SERIALIZE_TRAIT) + || path == symbols_list_from_str(&SERIALIZE_TRAIT_LEGACY) + { // Try to find an implementation of versionize for this type let mut found_impl = false; if let Some(versionize_trait) = self.0.versionize_trait(cx) {