From de6db4bc9d9653eed2f4f5b2ce6e596b9148aef4 Mon Sep 17 00:00:00 2001
From: "Mayeul@Zama" <69792125+mayeul-zama@users.noreply.github.com>
Date: Wed, 13 Mar 2024 10:45:47 +0100
Subject: [PATCH] fix(trivium): check warnings in benches

---
 Makefile                                  | 2 +-
 apps/trivium/benches/kreyvium_shortint.rs | 5 +----
 apps/trivium/benches/trivium_shortint.rs  | 5 +----
 3 files changed, 3 insertions(+), 9 deletions(-)

diff --git a/Makefile b/Makefile
index 0fcc47767..090c781b3 100644
--- a/Makefile
+++ b/Makefile
@@ -268,7 +268,7 @@ clippy_tasks:
 
 .PHONY: clippy_trivium # Run clippy lints on Trivium app
 clippy_trivium: install_rs_check_toolchain
-	RUSTFLAGS="$(RUSTFLAGS)" cargo "$(CARGO_RS_CHECK_TOOLCHAIN)" clippy \
+	RUSTFLAGS="$(RUSTFLAGS)" cargo "$(CARGO_RS_CHECK_TOOLCHAIN)" clippy --all-targets \
 		-p tfhe-trivium -- --no-deps -D warnings
 
 .PHONY: clippy_all_targets # Run clippy lints on all targets (benches, examples, etc.)
diff --git a/apps/trivium/benches/kreyvium_shortint.rs b/apps/trivium/benches/kreyvium_shortint.rs
index 62a27c295..a03ebff5d 100644
--- a/apps/trivium/benches/kreyvium_shortint.rs
+++ b/apps/trivium/benches/kreyvium_shortint.rs
@@ -1,12 +1,9 @@
+use criterion::Criterion;
 use tfhe::prelude::*;
 use tfhe::shortint::prelude::*;
-use tfhe::shortint::KeySwitchingKey;
 use tfhe::{generate_keys, ConfigBuilder, FheUint64};
-
 use tfhe_trivium::{KreyviumStreamShortint, TransCiphering};
 
-use criterion::Criterion;
-
 pub fn kreyvium_shortint_warmup(c: &mut Criterion) {
     let config = ConfigBuilder::default().build();
     let (hl_client_key, hl_server_key) = generate_keys(config);
diff --git a/apps/trivium/benches/trivium_shortint.rs b/apps/trivium/benches/trivium_shortint.rs
index 367ec9686..3e0a54d61 100644
--- a/apps/trivium/benches/trivium_shortint.rs
+++ b/apps/trivium/benches/trivium_shortint.rs
@@ -1,12 +1,9 @@
+use criterion::Criterion;
 use tfhe::prelude::*;
 use tfhe::shortint::prelude::*;
-use tfhe::shortint::KeySwitchingKey;
 use tfhe::{generate_keys, ConfigBuilder, FheUint64};
-
 use tfhe_trivium::{TransCiphering, TriviumStreamShortint};
 
-use criterion::Criterion;
-
 pub fn trivium_shortint_warmup(c: &mut Criterion) {
     let config = ConfigBuilder::default().build();
     let (hl_client_key, hl_server_key) = generate_keys(config);