From 45f0891a8f142f8f4b83df211642e9ddd404be26 Mon Sep 17 00:00:00 2001
From: chenyu <chenyu@fastmail.com>
Date: Mon, 9 Oct 2023 20:26:36 -0400
Subject: [PATCH] use "<" instead of "<=" in codegen for loop (#2027)

---
 tinygrad/codegen/linearizer.py | 4 ++--
 tinygrad/renderer/cstyle.py    | 2 +-
 tinygrad/renderer/llvmir.py    | 2 +-
 tinygrad/renderer/wgsl.py      | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/tinygrad/codegen/linearizer.py b/tinygrad/codegen/linearizer.py
index 98d4cc5fb8..d6670bbb84 100644
--- a/tinygrad/codegen/linearizer.py
+++ b/tinygrad/codegen/linearizer.py
@@ -198,8 +198,8 @@ class Linearizer(OptimizedKernel):
     # global and local loops
     def render_loop(xx:List[Variable]):
       self.loop_uops.update({x.expr:self.uop(UOps.LOOP, dtypes.int32, (
-        self.const(x.min) if isinstance(x.min, int) else cast(Variable, x.min).render(self.render_ops, self),
-        self.const(x.max) if isinstance(x.max, int) else cast(Variable, x.max).render(self.render_ops, self)), cachable=False) for x in xx if not isinstance(x, NumNode) and x.expr is not None})
+        self.const(x.min) if isinstance(x.min, int) else cast(Node, x.min).render(self.render_ops, self),
+        self.const(x.max+1) if isinstance(x.max, int) else cast(Node, x.max+1).render(self.render_ops, self)), cachable=False) for x in xx if not isinstance(x, NumNode) and x.expr is not None})
     def end_loop(xx:List[Variable]):
       for x in xx[::-1]:
         if not isinstance(x, NumNode) and x.expr is not None:
diff --git a/tinygrad/renderer/cstyle.py b/tinygrad/renderer/cstyle.py
index bf988796ed..3836d7252b 100644
--- a/tinygrad/renderer/cstyle.py
+++ b/tinygrad/renderer/cstyle.py
@@ -74,7 +74,7 @@ class CStyleLanguage(NamedTuple):
     return self.smem_align + self.smem_prefix + f"float {name}[{size}];"
 
   def render_for(self, expr: str, _min:Union[int,str], _max:Union[int,str]) -> str:
-    return f"for (int {expr} = {_min}; {expr} <= {_max}; ++{expr}) {{"
+    return f"for (int {expr} = {_min}; {expr} < {_max}; ++{expr}) {{"
 
   def render_conditional(self, cond: str, x:str, y:str) -> str:
     return f"({cond})?({x}):{y}"
diff --git a/tinygrad/renderer/llvmir.py b/tinygrad/renderer/llvmir.py
index cd034dcf6c..b1f2ab6eeb 100644
--- a/tinygrad/renderer/llvmir.py
+++ b/tinygrad/renderer/llvmir.py
@@ -106,7 +106,7 @@ def uops_to_llvm_ir(function_name:str, uops:List[UOp]) -> str:
       lvars[vin[0]].add_incoming(idx_p1, bb[-1]._block)
       for n,phi in phis: phi.add_incoming(lvars[n], bb[-1]._block)
       bb.append(ir.IRBuilder(func.append_basic_block(f"loop_exit_{len(loop_blocks)}")))
-      bb[-2].cbranch(bb[-2].icmp_unsigned(">", idx_p1, lvars[vin[0].vin[1]]), bb[-1]._block, block._block)
+      bb[-2].cbranch(bb[-2].icmp_unsigned("<", idx_p1, lvars[vin[0].vin[1]]), block._block, bb[-1]._block)
     if uop == UOps.DEFINE_GLOBAL:
       lvars[u] = func.args[buf_index[args[0]]]
     if uop == UOps.DEFINE_ACC:
diff --git a/tinygrad/renderer/wgsl.py b/tinygrad/renderer/wgsl.py
index c4b3487d25..202600b55d 100644
--- a/tinygrad/renderer/wgsl.py
+++ b/tinygrad/renderer/wgsl.py
@@ -41,7 +41,7 @@ class WGSLLanguage(CStyleLanguage):
     return prg
 
   def render_for(self, expr:str, _min:Union[int,str], _max:Union[int,str]) -> str:
-    return f"for(var {expr} = {_min}; {expr} <= {_max}; {expr}++) {{"
+    return f"for(var {expr} = {_min}; {expr} < {_max}; {expr}++) {{"
 
   def render_conditional(self, cond:str, x:str, y:str) -> str:
     return f"select(f32({y}), {x}, bool({cond}))"