From 577afc9f054ded40fe6032fd8f012221020702ed Mon Sep 17 00:00:00 2001 From: nimlgen <138685161+nimlgen@users.noreply.github.com> Date: Fri, 4 Jul 2025 21:49:47 +0300 Subject: [PATCH] hcq: remove redunt syncs and fix typing (#11096) Before this patch the code could issues reduntdant syncs because of the typing issue. Current tests should cover all correctness checks. --- tinygrad/runtime/graph/hcq.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tinygrad/runtime/graph/hcq.py b/tinygrad/runtime/graph/hcq.py index 4bcf17dba5..7f384fba13 100644 --- a/tinygrad/runtime/graph/hcq.py +++ b/tinygrad/runtime/graph/hcq.py @@ -92,9 +92,9 @@ class HCQGraph(MultiGraphRunner): if (qa:=queue_access[enqueue_queue][dep_queue]) is None or qa < dep_val: opt_deps.append((self.signals[dep_queue], dep_val)) queue_access[enqueue_queue][dep_queue] = dep_val + dev_access[enqueue_queue].update(dev_access[dep_queue]) # Ensure device is ready for use in current context: the graph has initialized the device and it's safe to operate on it within this graph. - for dep_queue, _ in opt_deps: dev_access[enqueue_queue].update(dev_access[dep_queue]) sync_signals = [(self.signals[d], self.kickoff_var) for b in ji.bufs if (d:=Device[cast(Buffer, b).device]) not in dev_access[enqueue_queue]] dev_access[enqueue_queue].update(cast(HCQCompiled, Device[cast(Buffer, b).device]) for b in ji.bufs)