diff --git a/tinygrad/viz/js/index.js b/tinygrad/viz/js/index.js index 8d387761af..36cd5ad97d 100644 --- a/tinygrad/viz/js/index.js +++ b/tinygrad/viz/js/index.js @@ -796,11 +796,11 @@ async function main() { } if (ret.cols != null) { renderTable(root, ret); - metadata.appendChild(tabulate(ret.summary.map(s => { - const div = d3.create("div").style("background", cycleColors(colorScheme.CATEGORICAL, s.idx)).style("width", "100%").style("height", "100%"); - return [s.label.trim(), div.text(s.value.toLocaleString()).node()]; - })).node()); } else root.append(() => codeBlock(ret.src, ret.lang || "txt")); + if (ret.metadata != null) metadata.appendChild(tabulate(ret.metadata.map(({ label, value, idx }) => { + const div = d3.create("div").style("background", cycleColors(colorScheme.CATEGORICAL, idx)).style("width", "100%").style("height", "100%"); + return [label.trim(), div.text(typeof value === "string" ? value : formatUnit(value)).node()]; + })).node()); return document.querySelector("#custom").replaceChildren(root.node()); } // ** UOp view (default) diff --git a/tinygrad/viz/serve.py b/tinygrad/viz/serve.py index df614190ce..5159472a21 100755 --- a/tinygrad/viz/serve.py +++ b/tinygrad/viz/serve.py @@ -275,7 +275,7 @@ def load_sqtt(profile:list[ProfileEvent]) -> None: row[2]["rows"].append(sample+(val,)) ptr += 1 rows.append(row) - steps.append(create_step("PMC", ("/pmc", len(ctxs), len(steps)), {"rows":rows, "cols":agg_cols, "summary":[]}, depth=2)) + steps.append(create_step("PMC", ("/pmc", len(ctxs), len(steps)), {"rows":rows, "cols":agg_cols}, depth=2)) for cu in prg_cu: events = [ProfilePointEvent(unit, "start", unit, ts=Decimal(0)) for unit in units]+cu_events[cu] steps.append(create_step(f"{cu} {len(cu_events[cu])}", ("/counters", len(ctxs), len(steps)), @@ -343,10 +343,10 @@ def get_llvm_mca(asm:str, mtriple:str, mcpu:str) -> dict: instr_usage.setdefault(i:=d["InstructionIndex"], {}).setdefault(r:=d["ResourceIndex"], 0) instr_usage[i][r] += d["ResourceUsage"] # last row is the usage summary - summary = [{"idx":k, "label":resource_labels[k], "value":v} for k,v in instr_usage.pop(len(rows), {}).items()] + metadata = [{"idx":k, "label":resource_labels[k], "value":v} for k,v in instr_usage.pop(len(rows), {}).items()] max_usage = max([sum(v.values()) for i,v in instr_usage.items() if i str: buf = io.StringIO() @@ -391,9 +391,9 @@ def get_render(i:int, j:int, fmt:str) -> dict: inst["stall"] += e.stall inst["hits"]["rows"].append((inst["hit_count"]-1, e.time, max(0, e.time-prev_instr), e.dur, e.stall)) prev_instr = max(prev_instr, e.time + e.dur) - summary = [{"label":"Total Cycles", "value":w.end_time-w.begin_time}, {"label":"SE", "value":w.se}, {"label":"CU", "value":w.cu}, + metadata = [{"label":"Total Cycles", "value":w.end_time-w.begin_time}, {"label":"SE", "value":w.se}, {"label":"CU", "value":w.cu}, {"label":"SIMD", "value":w.simd}, {"label":"Wave ID", "value":w.wave_id}, {"label":"Run number", "value":data["run_number"]}] - return {"rows":[tuple(v.values()) for v in rows.values()], "cols":columns, "summary":summary} + return {"rows":[tuple(v.values()) for v in rows.values()], "cols":columns, "metadata":metadata} return data # ** HTTP server