From 733ef0452ca82a8cbe67f546290fdeadc5975f78 Mon Sep 17 00:00:00 2001 From: chenyu Date: Sat, 20 Dec 2025 12:40:59 -0500 Subject: [PATCH] update test_uop_resolve (#13777) plain @unittest.expectedFailure is too broad --- test/unit/test_uop_resolve.py | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/test/unit/test_uop_resolve.py b/test/unit/test_uop_resolve.py index 83db03317b..4cdd8b30ac 100644 --- a/test/unit/test_uop_resolve.py +++ b/test/unit/test_uop_resolve.py @@ -95,21 +95,24 @@ class TestUOpResolve(unittest.TestCase): x = UOp.variable("i", 1, 10) self.assertFalse(x < x) - @unittest.expectedFailure def test_x_lt_xp1(self): x = UOp.variable("i", 1, 10) - self.assertTrue(x < (x+1)) + u = x < (x+1) + # TODO: improve + with self.assertRaises(ValueError): + bool(u) def test_and_true(self): + u = UOp.variable("b", False, True, dtypes.bool) & True with self.assertRaises(ValueError): - u = UOp.variable("b", False, True, dtypes.bool) & True - self.assertFalse(u) + bool(u) - @unittest.expectedFailure def test_var_cmp_range(self): v = UOp.variable("i", 1, 10) u = (v > 4) | (v < 6) - self.assertTrue(u) + # TODO: improve + with self.assertRaises(ValueError): + bool(u) def test_var_cmp_assert(self): with self.assertRaises(ValueError):